Fix gai_strerror() thread-safety on Windows.

Thomas Munro <tmunro@postgresql.org>

Commit: 0460e4ecc0fa532468331a4b71ad0fbe8ff1a416
Author: Thomas Munro <tmunro@postgresql.org>
Date: 2024-02-11T22:14:42Z
Releases: 16.3
Fix gai_strerror() thread-safety on Windows.

Commit 5579388d removed code that supplied a fallback implementation of
getaddrinfo(), which was dead code on modern systems.  One tiny piece of
the removed code was still doing something useful on Windows, though:
that OS's own gai_strerror()/gai_strerrorA() function returns a pointer
to a static buffer that it overwrites each time, so it's not
thread-safe.  In rare circumstances, a multi-threaded client program
could get an incorrect or corrupted error message.

Restore the replacement gai_strerror() function, though now that it's
only for Windows we can put it into a win32-specific file and cut it
down to the errors that Windows documents.  The error messages here are
taken from FreeBSD, because Windows' own messages seemed too verbose.

Back-patch to 16.

Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CA%2BhUKGKz%2BF9d2PTiXwfYV7qJw%2BWg2jzACgSDgPizUw7UG%3Di58A%40mail.gmail.com

Files

PathChange+/−
configure modified +6 −0
configure.ac modified +1 −0
src/include/port/win32/sys/socket.h modified +8 −0
src/port/meson.build modified +1 −0
src/port/win32gai_strerror.c added +45 −0
src/tools/msvc/Mkvcbuild.pm modified +1 −0

Discussion