Fix inadequacies in recently added wait events
Alvaro Herrera <alvherre@alvh.no-ip.org>
Fix inadequacies in recently added wait events In commit 9915de6c1cb2, we introduced a new wait point for replication slots and incorrectly labelled it as wait event PG_WAIT_LOCK. That's wrong, so invent an appropriate new wait event instead, and document it properly. While at it, fix numerous other problems in the vicinity: - two different walreceiver wait events were being mixed up in a single wait event (which wasn't documented either); split it out so that they can be distinguished, and document the new events properly. - ParallelBitmapPopulate was documented but didn't exist. - ParallelBitmapScan was not documented (I think this should be called "ParallelBitmapScanInit" instead.) - Logical replication wait events weren't documented - various symbols had been added in dartboard order in various places. Put them in alphabetical order instead, as was originally intended. Discussion: https://postgr.es/m/20170808181131.mu4fjepuh5m75cyq@alvherre.pgsql
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/monitoring.sgml | modified | +30 −2 |
| src/backend/postmaster/pgstat.c | modified | +21 −15 |
| src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | modified | +2 −2 |
| src/backend/replication/slot.c | modified | +2 −1 |
| src/include/pgstat.h | modified | +9 −7 |
Documentation touched
Discussion
- More race conditions in logical replication 28 messages · 2017-07-02 → 2017-08-13