Horton

Fix handling of NULL distances in KNN-GiST

Alexander Korotkov <akorotkov@postgresql.org>

View on postgr.es
Commit: 02f90879e75b3d4ccdba1ec7c3cad6af08dff77d
Author: Alexander Korotkov <akorotkov@postgresql.org>
Date: 2019-09-08T19:08:12Z
Releases: 13.0 
Fix handling of NULL distances in KNN-GiST

In order to implement NULL LAST semantic GiST previously assumed distance to
the NULL value to be Inf.  However, our distance functions can return Inf and
NaN for non-null values.  In such cases, NULL LAST semantic appears to be
broken.  This commit fixes that by introducing separate array of null flags for
distances.

Backpatch to all supported versions.

Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com
Author: Alexander Korotkov
Backpatch-through: 9.4

Files

PathChange+/−
src/backend/access/gist/gistget.c modified +48 −22
src/backend/access/gist/gistscan.c modified +21 −4
src/backend/access/index/indexam.c modified +10 −4
src/backend/access/spgist/spgscan.c modified +1 −0
src/include/access/genam.h modified +3 −1
src/include/access/gist_private.h modified +22 −4
src/test/regress/expected/create_index.out modified +1 −1

Discussion