Horton

Remove redundant null pointer checks before free()

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 02c408e21a6e78ff246ea7a1beb4669634fa9c4c
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2022-07-03T09:47:15Z
Releases: 16.0 
Remove redundant null pointer checks before free()

Per applicable standards, free() with a null pointer is a no-op.
Systems that don't observe that are ancient and no longer relevant.
Some PostgreSQL code already required this behavior, so this change
does not introduce any new requirements, just makes the code more
consistent.

Discussion: https://www.postgresql.org/message-id/flat/dac5d2d0-98f5-94d9-8e69-46da2413593d%40enterprisedb.com

Files

PathChange+/−
contrib/pg_stat_statements/pg_stat_statements.c modified +4 −8
contrib/uuid-ossp/uuid-ossp.c modified +2 −4
src/backend/bootstrap/bootstrap.c modified +1 −2
src/backend/libpq/auth.c modified +1 −4
src/backend/postmaster/postmaster.c modified +1 −2
src/backend/regex/regc_pg_locale.c modified +2 −4
src/backend/tcop/postgres.c modified +1 −2
src/backend/utils/adt/pg_locale.c modified +10 −20
src/backend/utils/error/elog.c modified +1 −2
src/backend/utils/init/miscinit.c modified +1 −2
src/backend/utils/misc/guc.c modified +8 −16
src/bin/pg_basebackup/pg_basebackup.c modified +1 −2
src/bin/pg_basebackup/streamutil.c modified +1 −2
src/bin/pgbench/pgbench.c modified +2 −4
src/bin/pg_dump/dumputils.c modified +7 −14
src/bin/pg_dump/pg_backup_archiver.c modified +20 −40
src/bin/pg_dump/pg_backup_custom.c modified +2 −4
src/bin/pg_dump/pg_backup_db.c modified +1 −2
src/bin/pg_dump/pg_backup_tar.c modified +1 −2
src/bin/pg_dump/pg_dumpall.c modified +2 −4
src/bin/pg_dump/pg_dump.c modified +10 −20
src/bin/psql/command.c modified +22 −44
src/bin/psql/copy.c modified +1 −2
src/bin/psql/describe.c modified +2 −4
src/bin/psql/input.c modified +1 −2
src/bin/psql/tab-complete.c modified +5 −10
src/common/fe_memutils.c modified +1 −2
src/fe_utils/connect_utils.c modified +1 −2
src/fe_utils/string_utils.c modified +2 −4
src/interfaces/ecpg/pgtypeslib/numeric.c modified +1 −5
src/interfaces/ecpg/preproc/descriptor.c modified +1 −2
src/interfaces/libpq/fe-auth.c modified +6 −12
src/interfaces/libpq/fe-auth-scram.c modified +11 −22
src/interfaces/libpq/fe-connect.c modified +70 −141
src/interfaces/libpq/fe-exec.c modified +2 −4
src/interfaces/libpq/fe-print.c modified +7 −16
src/interfaces/libpq/fe-secure-common.c modified +1 −2
src/port/getaddrinfo.c modified +1 −2

Discussion