jit: Correct parameter type for generated expression evaluation functions.

Andres Freund <andres@anarazel.de>

Commit: 01c6370a32e5875a63400c6e465de775a51ef1b8
Author: Andres Freund <andres@anarazel.de>
Date: 2020-12-08T02:33:03Z
Releases: 13.2
jit: Correct parameter type for generated expression evaluation functions.

clang only uses the 'i1' type for scalar booleans, not for pointers to
booleans (as the pointer might be pointing into a larger memory
allocation). Therefore a pointer-to-bool needs to the "storage" boolean.

There's no known case of wrong code generation due to this, but it seems quite
possible that it could cause problems (see e.g. 72559438f92).

Author: Andres Freund
Discussion: https://postgr.es/m/20201207212142.wz5tnbk2jsaqzogb@alap3.anarazel.de
Backpatch: 11-, where jit support was added

Files

PathChange+/−
src/backend/jit/llvm/llvmjit_expr.c modified +1 −3

Discussion