Minor cleanup of backend SCRAM code.

Heikki Linnakangas <heikki.linnakangas@iki.fi>

Commit: 00707fa58275e370dc445fa7e1130085aa04f37b
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: 2017-04-13T14:44:15Z
Releases: 10.0
Minor cleanup of backend SCRAM code.

Free each SASL message after sending it. It's not a lot of wasted memory,
and it's short-lived, but the authentication code in general tries to
pfree() stuff, so let's follow the example.

Adding the pfree() revealed a little bug in build_server_first_message().
It attempts to keeps a copy of the sent message, but it was missing a
pstrdup(), so the pointer started to dangle, after adding the pfree()
into CheckSCRAMAuth().

Reword comments and debug messages slightly, while we're at it.

Reviewed by Michael Paquier.

Discussion: https://www.postgresql.org/message-id/6490b975-5ee1-6280-ac1d-af975b19fb9a@iki.fi

Files

PathChange+/−
src/backend/libpq/auth.c modified +7 −5
src/backend/libpq/auth-scram.c modified +5 −5

Discussion