Fix crash in error report of invalid tuple lock

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: 0009462e985b90d07dc430bb3c4f1e6f57e0c318
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2013-08-02T17:37:40Z
Releases: 9.3.0
Fix crash in error report of invalid tuple lock

My tweak of these error messages in commit c359a1b082 contained the
thinko that a query would always have rowMarks set for a query
containing a locking clause.  Not so: when declaring a cursor, for
instance, rowMarks isn't set at the point we're checking, so we'd be
dereferencing a NULL pointer.

The fix is to pass the lock strength to the function raising the error,
instead of trying to reverse-engineer it.  The result not only is more
robust, but it also seems cleaner overall.

Per report from Robert Haas.

Files