v28-review-0008-review.patch
text/x-patch
Filename: v28-review-0008-review.patch
Type: text/x-patch
Part: 7
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch v28-0008
Subject: review
| File | + | − |
|---|---|---|
| contrib/amcheck/amcheck--1.4--1.5.sql | 1 | 1 |
| contrib/amcheck/verify_gin.c | 1 | 0 |
From 7ed4f7a82663d576bdb928a2767920fff36d60f9 Mon Sep 17 00:00:00 2001 From: Tomas Vondra <tv@fuzzy.cz> Date: Wed, 10 Jul 2024 15:40:22 +0200 Subject: [PATCH v28-review 08/13] review --- contrib/amcheck/amcheck--1.4--1.5.sql | 2 +- contrib/amcheck/verify_gin.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/amcheck/amcheck--1.4--1.5.sql b/contrib/amcheck/amcheck--1.4--1.5.sql index a2bca7c2037..7414b611e06 100644 --- a/contrib/amcheck/amcheck--1.4--1.5.sql +++ b/contrib/amcheck/amcheck--1.4--1.5.sql @@ -14,7 +14,7 @@ LANGUAGE C STRICT; REVOKE ALL ON FUNCTION gist_index_check(regclass, boolean) FROM PUBLIC; -- gin_index_parent_check() --- +-- XXX why is this not called simply gin_index_check? CREATE FUNCTION gin_index_parent_check(index regclass) RETURNS VOID AS 'MODULE_PATHNAME', 'gin_index_parent_check' diff --git a/contrib/amcheck/verify_gin.c b/contrib/amcheck/verify_gin.c index 877ecacb9c1..2a63ba6b83e 100644 --- a/contrib/amcheck/verify_gin.c +++ b/contrib/amcheck/verify_gin.c @@ -732,6 +732,7 @@ gin_refind_parent(Relation rel, BlockNumber parentblkno, return result; } +/* XXX yet another copy of this? */ static ItemId PageGetItemIdCareful(Relation rel, BlockNumber block, Page page, OffsetNumber offset) -- 2.45.2