PS_NITPICKS_20240701_SEQ_0002.txt

text/plain

Filename: PS_NITPICKS_20240701_SEQ_0002.txt
Type: text/plain
Part: 0
Message: Re: Logical Replication of sequences
diff --git a/doc/src/sgml/ref/create_publication.sgml b/doc/src/sgml/ref/create_publication.sgml
index 107ce63..de66031 100644
--- a/doc/src/sgml/ref/create_publication.sgml
+++ b/doc/src/sgml/ref/create_publication.sgml
@@ -247,7 +247,7 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
 
   <para>
    If <literal>FOR TABLE</literal>, <literal>FOR ALL TABLES</literal>,
-   <literal>FOR ALL SEQUENCES</literal>,or <literal>FOR TABLES IN SCHEMA</literal>
+   <literal>FOR ALL SEQUENCES</literal> or <literal>FOR TABLES IN SCHEMA</literal>
    are not specified, then the publication starts out with an empty set of
    tables.  That is useful if tables or schemas are to be added later.
   </para>
@@ -266,7 +266,7 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
   <para>
    To add a table to a publication, the invoking user must have ownership
    rights on the table.  The <command>FOR ALL TABLES</command>,
-   <command>FOR ALL SEQUENCES</command>, and
+   <command>FOR ALL SEQUENCES</command> and
    <command>FOR TABLES IN SCHEMA</command> clauses require the invoking
    user to be a superuser.
   </para>
diff --git a/src/backend/catalog/pg_publication.c b/src/backend/catalog/pg_publication.c
index 175caf2..998a840 100644
--- a/src/backend/catalog/pg_publication.c
+++ b/src/backend/catalog/pg_publication.c
@@ -999,7 +999,7 @@ GetAllSchemaPublicationRelations(Oid pubid, PublicationPartOpt pub_partopt)
 }
 
 /*
- * Gets list of all relation published by FOR ALL SEQUENCES publication(s).
+ * Gets list of all relations published by FOR ALL SEQUENCES publication(s).
  */
 List *
 GetAllSequencesPublicationRelations(void)
diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index 482c756..a609ab5 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -2113,6 +2113,7 @@ describeOneTableDetails(const char *schemaname,
 	res = PSQLexec(buf.data);
 	if (!res)
 		goto error_return;
+
 	numrows = PQntuples(res);
 
 	/* Generate table cells to be printed */
@@ -6510,7 +6511,7 @@ describePublications(const char *pattern)
 		if (has_pubviaroot)
 			ncols++;
 		if (has_pubsequence)
-			ncols ++;
+			ncols++;
 
 		initPQExpBuffer(&title);
 		printfPQExpBuffer(&title, _("Publication %s"), pubname);
diff --git a/src/include/catalog/pg_publication.h b/src/include/catalog/pg_publication.h
index 8cc0fe9..4b402a6 100644
--- a/src/include/catalog/pg_publication.h
+++ b/src/include/catalog/pg_publication.h
@@ -143,6 +143,7 @@ typedef enum PublicationPartOpt
 extern List *GetPublicationRelations(Oid pubid, PublicationPartOpt pub_partopt);
 extern List *GetAllTablesPublications(void);
 extern List *GetAllTablesPublicationRelations(bool pubviaroot);
+extern List *GetAllSequencesPublicationRelations(void);
 extern List *GetPublicationSchemas(Oid pubid);
 extern List *GetSchemaPublications(Oid schemaid);
 extern List *GetSchemaPublicationRelations(Oid schemaid,
@@ -155,8 +156,6 @@ extern List *GetPubPartitionOptionRelations(List *result,
 extern Oid	GetTopMostAncestorInPublication(Oid puboid, List *ancestors,
 											int *ancestor_level);
 
-extern  List *GetAllSequencesPublicationRelations(void);
-
 extern bool is_publishable_relation(Relation rel);
 extern bool is_schema_publication(Oid pubid);
 extern ObjectAddress publication_add_relation(Oid pubid, PublicationRelInfo *pri,