v22b-0017-review.patch

text/x-patch

Filename: v22b-0017-review.patch
Type: text/x-patch
Part: 16
Message: Re: BitmapHeapScan streaming read user and prelim refactoring

Patch

Format: format-patch
Series: patch 0017
Subject: review
File+
src/include/access/relscan.h 7 0
From b974ff18088d296f7efa72cfc58abdb507356a39 Mon Sep 17 00:00:00 2001
From: Tomas Vondra <tv@fuzzy.cz>
Date: Tue, 18 Jun 2024 23:06:55 +0200
Subject: [PATCH v22b 17/29] review

---
 src/include/access/relscan.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/include/access/relscan.h b/src/include/access/relscan.h
index 036ef29e7d5..9c711ce0eb0 100644
--- a/src/include/access/relscan.h
+++ b/src/include/access/relscan.h
@@ -52,6 +52,13 @@ typedef struct TableScanDescData
 } TableScanDescData;
 typedef struct TableScanDescData *TableScanDesc;
 
+/*
+ * XXX I don't understand why we should have this special node if we
+ * don't have special nodes for other scan types.
+ *
+ * XXX Also, maybe this should do the naming convention with Data at
+ * the end (mostly for consistency).
+ */
 typedef struct BitmapTableScanDesc
 {
 	Relation	rs_rd;			/* heap relation descriptor */
-- 
2.45.2