v22b-0002-review.patch

text/x-patch

Filename: v22b-0002-review.patch
Type: text/x-patch
Part: 1
Message: Re: BitmapHeapScan streaming read user and prelim refactoring

Patch

Format: format-patch
Series: patch 0002
Subject: review
File+
src/backend/access/heap/heapam_handler.c 1 0
From 58ebda69284ab9c61c0b9855978fbb5a9cf007c4 Mon Sep 17 00:00:00 2001
From: Tomas Vondra <tv@fuzzy.cz>
Date: Tue, 18 Jun 2024 20:42:24 +0200
Subject: [PATCH v22b 02/29] review

---
 src/backend/access/heap/heapam_handler.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c
index 72ba9ed4dcf..6f744f727d0 100644
--- a/src/backend/access/heap/heapam_handler.c
+++ b/src/backend/access/heap/heapam_handler.c
@@ -2249,6 +2249,7 @@ heapam_scan_bitmap_next_block(TableScanDesc scan,
 	Assert(ntup <= MaxHeapTuplesPerPage);
 	hscan->rs_ntuples = ntup;
 
+	/* XXX why inverted condition, compared to the original one in BitmapHeapNext? */
 	if (tbmres->ntuples < 0)
 		(*lossy_pages)++;
 	else
-- 
2.45.2