v1-0004-BitmapPrefetch-use-prefetch-block-recheck-for-ski.patch
text/x-patch
Filename: v1-0004-BitmapPrefetch-use-prefetch-block-recheck-for-ski.patch
Type: text/x-patch
Part: 4
Patch
Format: format-patch
Series: patch v1-0004
Subject: BitmapPrefetch use prefetch block recheck for skip fetch
| File | + | − |
|---|---|---|
| src/backend/executor/nodeBitmapHeapscan.c | 2 | 2 |
From a3f62e4299663d418531ae61bb16ea39f0836fac Mon Sep 17 00:00:00 2001 From: Melanie Plageman <melanieplageman@gmail.com> Date: Mon, 12 Feb 2024 19:03:24 -0500 Subject: [PATCH v1 04/11] BitmapPrefetch use prefetch block recheck for skip fetch Previously BitmapPrefetch() used the recheck flag for the current block to determine whether or not it could skip prefetching the proposed prefetch block. It makes more sense for it to use the recheck flag from the TBMIterateResult for the prefetch block instead. --- src/backend/executor/nodeBitmapHeapscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/executor/nodeBitmapHeapscan.c b/src/backend/executor/nodeBitmapHeapscan.c index fd697d16c72..ab97f308a5f 100644 --- a/src/backend/executor/nodeBitmapHeapscan.c +++ b/src/backend/executor/nodeBitmapHeapscan.c @@ -519,7 +519,7 @@ BitmapPrefetch(BitmapHeapScanState *node, TableScanDesc scan) * but is true in many cases. */ skip_fetch = (node->can_skip_fetch && - (node->tbmres ? !node->tbmres->recheck : false) && + !tbmpre->recheck && VM_ALL_VISIBLE(node->ss.ss_currentRelation, tbmpre->blockno, &node->pvmbuffer)); @@ -570,7 +570,7 @@ BitmapPrefetch(BitmapHeapScanState *node, TableScanDesc scan) /* As above, skip prefetch if we expect not to need page */ skip_fetch = (node->can_skip_fetch && - (node->tbmres ? !node->tbmres->recheck : false) && + !tbmpre->recheck && VM_ALL_VISIBLE(node->ss.ss_currentRelation, tbmpre->blockno, &node->pvmbuffer)); -- 2.37.2