v19-0004-Fix-argument-for-get_base_conninfo.patch
application/octet-stream
Filename: v19-0004-Fix-argument-for-get_base_conninfo.patch
Type: application/octet-stream
Part: 5
Message:
RE: speed up a logical replica setup
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch v19-0004
Subject: Fix argument for get_base_conninfo
| File | + | − |
|---|---|---|
| src/bin/pg_basebackup/pg_createsubscriber.c | 4 | 4 |
From eb4b4e6076e46751db9cccc2f7149754fc991271 Mon Sep 17 00:00:00 2001
From: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Date: Thu, 8 Feb 2024 13:58:48 +0000
Subject: [PATCH v19 4/9] Fix argument for get_base_conninfo
---
src/bin/pg_basebackup/pg_createsubscriber.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/bin/pg_basebackup/pg_createsubscriber.c b/src/bin/pg_basebackup/pg_createsubscriber.c
index 0ef670ae6d..291fc3967f 100644
--- a/src/bin/pg_basebackup/pg_createsubscriber.c
+++ b/src/bin/pg_basebackup/pg_createsubscriber.c
@@ -62,7 +62,7 @@ typedef struct LogicalRepInfo
static void cleanup_objects_atexit(void);
static void usage();
-static char *get_base_conninfo(char *conninfo, char *dbname);
+static char *get_base_conninfo(char *conninfo, char **dbname);
static char *get_bin_directory(const char *path);
static bool check_data_directory(const char *datadir);
static char *concat_conninfo_dbname(const char *conninfo, const char *dbname);
@@ -205,7 +205,7 @@ usage(void)
* dbname.
*/
static char *
-get_base_conninfo(char *conninfo, char *dbname)
+get_base_conninfo(char *conninfo, char **dbname)
{
PQExpBuffer buf = createPQExpBuffer();
PQconninfoOption *conn_opts = NULL;
@@ -227,7 +227,7 @@ get_base_conninfo(char *conninfo, char *dbname)
if (strcmp(conn_opt->keyword, "dbname") == 0 && conn_opt->val != NULL)
{
if (dbname)
- dbname = pg_strdup(conn_opt->val);
+ *dbname = pg_strdup(conn_opt->val);
continue;
}
@@ -1721,7 +1721,7 @@ main(int argc, char **argv)
}
pg_log_info("validating connection string on publisher");
pub_base_conninfo = get_base_conninfo(opt.pub_conninfo_str,
- dbname_conninfo);
+ &dbname_conninfo);
if (pub_base_conninfo == NULL)
exit(1);
--
2.43.0