v2-0005-DO-NOT-MERGE-enable-compression-for-CI.patch
application/octet-stream
Filename: v2-0005-DO-NOT-MERGE-enable-compression-for-CI.patch
Type: application/octet-stream
Part: 1
Message:
Re: libpq compression (part 3)
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch v2-0005
Subject: DO NOT MERGE: enable compression for CI
| File | + | − |
|---|---|---|
| src/backend/libpq/compression.c | 1 | 1 |
| src/backend/utils/misc/guc_tables.c | 1 | 1 |
| src/backend/utils/misc/postgresql.conf.sample | 1 | 1 |
| src/common/zpq_stream.c | 2 | 1 |
| src/interfaces/libpq/fe-connect.c | 1 | 1 |
From a130f1f2ec03c8feee2d3b1885b81d27735500dd Mon Sep 17 00:00:00 2001
From: Jacob Burroughs <jburroughs@instructure.com>
Date: Sun, 17 Dec 2023 16:09:23 -0600
Subject: [PATCH v2 5/5] DO NOT MERGE: enable compression for CI
---
src/backend/libpq/compression.c | 2 +-
src/backend/utils/misc/guc_tables.c | 2 +-
src/backend/utils/misc/postgresql.conf.sample | 2 +-
src/common/zpq_stream.c | 3 ++-
src/interfaces/libpq/fe-connect.c | 2 +-
5 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/backend/libpq/compression.c b/src/backend/libpq/compression.c
index bb17a23231..35c32eb926 100644
--- a/src/backend/libpq/compression.c
+++ b/src/backend/libpq/compression.c
@@ -17,7 +17,7 @@
#include "utils/guc_hooks.h"
/* GUC variable containing the allowed compression algorithms list (separated by semicolon) */
-char *libpq_compress_algorithms = "off";
+char *libpq_compress_algorithms = "on";
pg_compress_specification libpq_compressors[COMPRESSION_ALGORITHM_COUNT];
size_t libpq_n_compressors = 0;
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
index 0d36ca52f2..bd084e184a 100644
--- a/src/backend/utils/misc/guc_tables.c
+++ b/src/backend/utils/misc/guc_tables.c
@@ -4539,7 +4539,7 @@ struct config_string ConfigureNamesString[] =
GUC_REPORT
},
&libpq_compress_algorithms,
- "off",
+ "on",
check_libpq_compression, assign_libpq_compression, NULL
},
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index 0411571c02..24a4d6e05a 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -74,7 +74,7 @@
# (change requires restart)
#bonjour_name = '' # defaults to the computer name
# (change requires restart)
-#libpq_compression = off # on to allow all supported compression
+#libpq_compression = on # on to allow all supported compression
# methods; off to disable all compression;
# semicolon separated list of algorithms to allow some
diff --git a/src/common/zpq_stream.c b/src/common/zpq_stream.c
index b2a47c7537..acbe070734 100644
--- a/src/common/zpq_stream.c
+++ b/src/common/zpq_stream.c
@@ -217,7 +217,8 @@ zpq_choose_algorithm(ZpqStream * zpq, char msg_type, uint32 msg_len)
* has not yet been enabled) for message types that would most obviously
* benefit from compression
*/
- if (msg_len >= ZPQ_COMPRESS_THRESHOLD && (msg_type == PqMsg_CopyData || msg_type == PqMsg_DataRow || msg_type == PqMsg_Query))
+ /* force enable for testing */
+ if (true || (msg_len >= ZPQ_COMPRESS_THRESHOLD && (msg_type == PqMsg_CopyData || msg_type == PqMsg_DataRow || msg_type == PqMsg_Query)))
{
return zpq->compress_algs[0];
}
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index 2356b9719c..92edcca0c8 100644
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -399,7 +399,7 @@ static const internalPQconninfoOption PQconninfoOptions[] = {
"Replication", "D", 5,
offsetof(struct pg_conn, replication)},
- {"compression", "PGCOMPRESSION", "off", NULL,
+ {"compression", "PGCOMPRESSION", "on", NULL,
"Libpq-compression", "", 16,
offsetof(struct pg_conn, compression)},
--
2.42.0