user-mapping-not-found-message-improvement.v1.patch
text/x-patch
Filename: user-mapping-not-found-message-improvement.v1.patch
Type: text/x-patch
Part: 0
Patch
Format: unified
Series: patch v1
| File | + | − |
|---|---|---|
| src/backend/foreign/foreign.c | 7 | 2 |
commit 1e08150c0bba813050b00e4e35cdba1572fd5564
Author: Ian Barwick <barwick@gmail.com>
Date: Fri Jun 23 16:36:41 2023 +0900
Improve "user mapping not found" error message
Display the name of the foreign server for which the user mapping
was not found.
diff --git a/src/backend/foreign/foreign.c b/src/backend/foreign/foreign.c
index ca3ad55b62..b649064141 100644
--- a/src/backend/foreign/foreign.c
+++ b/src/backend/foreign/foreign.c
@@ -217,10 +217,15 @@ GetUserMapping(Oid userid, Oid serverid)
}
if (!HeapTupleIsValid(tp))
+ {
+ ForeignServer *server = GetForeignServer(serverid);
+
ereport(ERROR,
(errcode(ERRCODE_UNDEFINED_OBJECT),
- errmsg("user mapping not found for \"%s\"",
- MappingUserName(userid))));
+ errmsg("user mapping not found for user \"%s\", server \"%s\"",
+ MappingUserName(userid),
+ server->servername)));
+ }
um = (UserMapping *) palloc(sizeof(UserMapping));
um->umid = ((Form_pg_user_mapping) GETSTRUCT(tp))->oid;