Horton

remove-useless-if-test.patch

application/octet-stream

Download
Filename: remove-useless-if-test.patch
Type: application/octet-stream
Part: 0
Message: postgres_fdw: Useless if-test in GetConnection()

Patch

Format: unified
File+−
contrib/postgres_fdw/connection.c 1 2 
diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
index 12b54f15cd..8eb9194506 100644
--- a/contrib/postgres_fdw/connection.c
+++ b/contrib/postgres_fdw/connection.c
@@ -271,8 +271,7 @@ GetConnection(UserMapping *user, bool will_prep_stmt, PgFdwConnState **state)
 			 entry->conn);
 		disconnect_pg_server(entry);
 
-		if (entry->conn == NULL)
-			make_new_connection(entry, user);
+		make_new_connection(entry, user);
 
 		begin_remote_xact(entry);
 	}