From 2ca25bd5bbe1aa6849c55cab58dafe202adacce9 Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Wed, 18 Jan 2023 19:52:46 +0100 Subject: [PATCH 5/5] review comments --- src/backend/optimizer/path/allpaths.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c index eaa972ec64b..9dd10a1274c 100644 --- a/src/backend/optimizer/path/allpaths.c +++ b/src/backend/optimizer/path/allpaths.c @@ -3025,10 +3025,10 @@ generate_gather_paths(PlannerInfo *root, RelOptInfo *rel, bool override_rows) if (rel->partial_pathlist == NIL) return; + /* FIXME ??? */ if (!bms_is_subset(required_outer, rel->relids)) return; - /* Should we override the rel's rowcount estimate? */ if (override_rows) rowsp = &rows; @@ -3062,6 +3062,7 @@ generate_gather_paths(PlannerInfo *root, RelOptInfo *rel, bool override_rows) if (subpath->pathkeys == NIL) continue; + /* FIXME ??? */ if (subpath->param_info != NULL && !bms_is_subset(subpath->param_info->ppi_req_outer, rel->relids)) break; -- 2.39.0