From aaa75322540a306510a71f26cf2d6198ce90d42a Mon Sep 17 00:00:00 2001 From: "houzj.fnst" Date: Wed, 20 Apr 2022 16:45:07 +0800 Subject: [PATCH v24 1/5] Perform streaming logical transactions by background workers Currently, for large transactions, the publisher sends the data in multiple streams (changes divided into chunks depending upon logical_decoding_work_mem), and then on the subscriber-side, the apply worker writes the changes into temporary files and once it receives the commit, it reads from the file and applies the entire transaction. To improve the performance of such transactions, we can instead allow them to be applied via background workers. In this approach, we assign a new apply background worker (if available) as soon as the xact's first stream is received and the main apply worker will send changes to this new worker via shared memory. The apply background worker will directly apply the change instead of writing it to temporary files. We keep this worker assigned till the transaction commit is received and also wait for the worker to finish at commit. This preserves commit ordering and avoids writing to and reading from file in most cases. We still need to spill if there is no worker available. This patch also extends the SUBSCRIPTION 'streaming' parameter so that the user can control whether to apply the streaming transaction in an apply background worker or spill the change to disk. The user can set the streaming parameter to 'on/off', 'parallel'. The parameter value 'parallel' means the streaming will be applied via an apply background worker, if available. The parameter value 'on' means the streaming transaction will be spilled to disk. The default value is 'off' (same as current behaviour). In addition, the patch extends the logical replication STREAM_ABORT message so that abort_time and abort_lsn can also be sent which can be used to update the replication origin in apply background worker when the streaming transaction is aborted. --- doc/src/sgml/catalogs.sgml | 11 +- doc/src/sgml/config.sgml | 28 +- doc/src/sgml/logical-replication.sgml | 13 +- doc/src/sgml/protocol.sgml | 29 +- doc/src/sgml/ref/create_subscription.sgml | 24 +- src/backend/access/transam/xact.c | 13 + src/backend/commands/subscriptioncmds.c | 66 +- src/backend/libpq/pqmq.c | 10 + src/backend/postmaster/bgworker.c | 3 + src/backend/replication/logical/Makefile | 1 + src/backend/replication/logical/applybgworker.c | 973 ++++++++++++++++++++++++ src/backend/replication/logical/decode.c | 10 +- src/backend/replication/logical/launcher.c | 153 +++- src/backend/replication/logical/origin.c | 23 +- src/backend/replication/logical/proto.c | 41 +- src/backend/replication/logical/reorderbuffer.c | 10 +- src/backend/replication/logical/tablesync.c | 10 +- src/backend/replication/logical/worker.c | 798 ++++++++++++++----- src/backend/replication/pgoutput/pgoutput.c | 6 +- src/backend/storage/ipc/procsignal.c | 4 + src/backend/tcop/postgres.c | 3 + src/backend/utils/activity/wait_event.c | 3 + src/backend/utils/misc/guc.c | 12 + src/backend/utils/misc/postgresql.conf.sample | 1 + src/bin/pg_dump/pg_dump.c | 6 +- src/include/catalog/pg_subscription.h | 21 +- src/include/replication/logicallauncher.h | 1 + src/include/replication/logicalproto.h | 27 +- src/include/replication/logicalworker.h | 5 + src/include/replication/origin.h | 2 +- src/include/replication/reorderbuffer.h | 7 +- src/include/replication/worker_internal.h | 130 +++- src/include/storage/procsignal.h | 1 + src/include/utils/wait_event.h | 1 + src/test/regress/expected/subscription.out | 12 +- src/test/regress/sql/subscription.sql | 6 +- src/tools/pgindent/typedefs.list | 5 + 37 files changed, 2209 insertions(+), 260 deletions(-) create mode 100644 src/backend/replication/logical/applybgworker.c diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index 2ce539a..673c812 100644 --- a/doc/src/sgml/catalogs.sgml +++ b/doc/src/sgml/catalogs.sgml @@ -7882,11 +7882,16 @@ SCRAM-SHA-256$<iteration count>:&l - substream bool + substream char - If true, the subscription will allow streaming of in-progress - transactions + Controls how to handle the streaming of in-progress transactions: + f = disallow streaming of in-progress transactions, + t = spill the changes of in-progress transactions to + disk and apply at once after the transaction is committed on the + publisher, + p = apply changes directly using a background + worker if available (same as 't' if no worker is available) diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index a5cd4e4..e39e95b 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -4940,7 +4940,8 @@ ANY num_sync ( num_sync ( + max_apply_bgworkers_per_subscription (integer) + + max_apply_bgworkers_per_subscription configuration parameter + + + + + Maximum number of apply background workers per subscription. This + parameter controls the amount of parallelism for streaming of + in-progress transactions with subscription parameter + streaming = parallel. + + + The apply background workers are taken from the pool defined by + max_logical_replication_workers. + + + The default value is 2. This parameter can only be set in the + postgresql.conf file or on the server command + line. + + + + diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index bdf1e7b..35a25c3 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -1153,6 +1153,16 @@ CONTEXT: processing remote data for replication origin "pg_16395" during "INSER might not violate any constraint. This can easily make the subscriber inconsistent. + + + When the streaming mode is parallel, the finish LSN of + failed transactions may not be logged. In that case, it may be necessary to + change the streaming mode to on or off and + cause the same conflicts again so the finish LSN of the failed transaction will + be written to the server log. For the usage of finish LSN, please refer to ALTER SUBSCRIPTION ... + SKIP. + @@ -1334,7 +1344,8 @@ CONTEXT: processing remote data for replication origin "pg_16395" during "INSER subscription. A disabled subscription or a crashed subscription will have zero rows in this view. If the initial data synchronization of any table is in progress, there will be additional workers for the tables - being synchronized. + being synchronized. Moreover, if the streaming transaction is applied in + parallel, there will be additional workers. diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml index 87870c5..d107dd2 100644 --- a/doc/src/sgml/protocol.sgml +++ b/doc/src/sgml/protocol.sgml @@ -3096,7 +3096,7 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;" Protocol version. Currently versions 1, 2, - and 3 are supported. + 3, and 4 are supported. Version 2 is supported only for server version 14 @@ -3106,6 +3106,11 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;" Version 3 is supported only for server version 15 and above, and it allows streaming of two-phase commits. + + Version 4 is supported only for server version 16 + and above, and it allows applying streams of large in-progress + transactions in parallel. + @@ -6876,6 +6881,28 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;" + + + Int64 (XLogRecPtr) + + + The LSN of the abort. This field is available since protocol version + 4. + + + + + + Int64 (TimestampTz) + + + Abort timestamp of the transaction. The value is in number + of microseconds since PostgreSQL epoch (2000-01-01). This field is + available since protocol version 4. + + + + diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index 7390c71..e2f9968 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -217,13 +217,29 @@ CREATE SUBSCRIPTION subscription_name - streaming (boolean) + streaming (enum) Specifies whether to enable streaming of in-progress transactions - for this subscription. By default, all transactions - are fully decoded on the publisher and only then sent to the - subscriber as a whole. + for this subscription. The default value is off, + meaning all transactions are fully decoded on the publisher and only + then sent to the subscriber as a whole. + + + + If set to on, the incoming changes are written to + temporary files and then applied only after the transaction is + committed on the publisher and received by the subscriber. + + + + If set to parallel, incoming changes are directly + applied via one of the apply background workers, if available. If no + background worker is free to handle streaming transactions then the + changes are written to temporary files and applied after the + transaction is committed. Note that if an error happens when + applying changes in a background worker, the finish LSN of the + remote transaction might not be reported in the server log. diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c index 50f092d..5a76d9c 100644 --- a/src/backend/access/transam/xact.c +++ b/src/backend/access/transam/xact.c @@ -1711,6 +1711,7 @@ RecordTransactionAbort(bool isSubXact) int nchildren; TransactionId *children; TimestampTz xact_time; + bool replorigin; /* * If we haven't been assigned an XID, nobody will care whether we aborted @@ -1741,6 +1742,13 @@ RecordTransactionAbort(bool isSubXact) elog(PANIC, "cannot abort transaction %u, it was already committed", xid); + /* + * Are we using the replication origins feature? Or, in other words, + * are we replaying remote actions? + */ + replorigin = (replorigin_session_origin != InvalidRepOriginId && + replorigin_session_origin != DoNotReplicateId); + /* Fetch the data we need for the abort record */ nrels = smgrGetPendingDeletes(false, &rels); nchildren = xactGetCommittedChildren(&children); @@ -1765,6 +1773,11 @@ RecordTransactionAbort(bool isSubXact) MyXactFlags, InvalidTransactionId, NULL); + if (replorigin) + /* Move LSNs forward for this replication origin */ + replorigin_session_advance(replorigin_session_origin_lsn, + XactLastRecEnd); + /* * Report the latest async abort LSN, so that the WAL writer knows to * flush this abort. There's nothing to be gained by delaying this, since diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c index 670b219..3dc03dc 100644 --- a/src/backend/commands/subscriptioncmds.c +++ b/src/backend/commands/subscriptioncmds.c @@ -84,7 +84,7 @@ typedef struct SubOpts bool copy_data; bool refresh; bool binary; - bool streaming; + char streaming; bool twophase; bool disableonerr; char *origin; @@ -98,6 +98,62 @@ static void ReportSlotConnectionError(List *rstates, Oid subid, char *slotname, /* + * Extract the streaming mode value from a DefElem. This is like + * defGetBoolean() but also accepts the special value of "parallel". + */ +static char +defGetStreamingMode(DefElem *def) +{ + /* + * If no parameter value given, assume "true" is meant. + */ + if (def->arg == NULL) + return SUBSTREAM_ON; + + /* + * Allow 0, 1, "false", "true", "off", "on" or "parallel". + */ + switch (nodeTag(def->arg)) + { + case T_Integer: + switch (intVal(def->arg)) + { + case 0: + return SUBSTREAM_OFF; + case 1: + return SUBSTREAM_ON; + default: + /* otherwise, error out below */ + break; + } + break; + default: + { + char *sval = defGetString(def); + + /* + * The set of strings accepted here should match up with the + * grammar's opt_boolean_or_string production. + */ + if (pg_strcasecmp(sval, "false") == 0 || + pg_strcasecmp(sval, "off") == 0) + return SUBSTREAM_OFF; + if (pg_strcasecmp(sval, "true") == 0 || + pg_strcasecmp(sval, "on") == 0) + return SUBSTREAM_ON; + if (pg_strcasecmp(sval, "parallel") == 0) + return SUBSTREAM_PARALLEL; + } + break; + } + ereport(ERROR, + (errcode(ERRCODE_SYNTAX_ERROR), + errmsg("%s requires a Boolean value or \"parallel\"", + def->defname))); + return SUBSTREAM_OFF; /* keep compiler quiet */ +} + +/* * Common option parsing function for CREATE and ALTER SUBSCRIPTION commands. * * Since not all options can be specified in both commands, this function @@ -134,7 +190,7 @@ parse_subscription_options(ParseState *pstate, List *stmt_options, if (IsSet(supported_opts, SUBOPT_BINARY)) opts->binary = false; if (IsSet(supported_opts, SUBOPT_STREAMING)) - opts->streaming = false; + opts->streaming = SUBSTREAM_OFF; if (IsSet(supported_opts, SUBOPT_TWOPHASE_COMMIT)) opts->twophase = false; if (IsSet(supported_opts, SUBOPT_DISABLE_ON_ERR)) @@ -237,7 +293,7 @@ parse_subscription_options(ParseState *pstate, List *stmt_options, errorConflictingDefElem(defel, pstate); opts->specified_opts |= SUBOPT_STREAMING; - opts->streaming = defGetBoolean(defel); + opts->streaming = defGetStreamingMode(defel); } else if (strcmp(defel->defname, "two_phase") == 0) { @@ -627,7 +683,7 @@ CreateSubscription(ParseState *pstate, CreateSubscriptionStmt *stmt, values[Anum_pg_subscription_subowner - 1] = ObjectIdGetDatum(owner); values[Anum_pg_subscription_subenabled - 1] = BoolGetDatum(opts.enabled); values[Anum_pg_subscription_subbinary - 1] = BoolGetDatum(opts.binary); - values[Anum_pg_subscription_substream - 1] = BoolGetDatum(opts.streaming); + values[Anum_pg_subscription_substream - 1] = CharGetDatum(opts.streaming); values[Anum_pg_subscription_subtwophasestate - 1] = CharGetDatum(opts.twophase ? LOGICALREP_TWOPHASE_STATE_PENDING : @@ -1089,7 +1145,7 @@ AlterSubscription(ParseState *pstate, AlterSubscriptionStmt *stmt, if (IsSet(opts.specified_opts, SUBOPT_STREAMING)) { values[Anum_pg_subscription_substream - 1] = - BoolGetDatum(opts.streaming); + CharGetDatum(opts.streaming); replaces[Anum_pg_subscription_substream - 1] = true; } diff --git a/src/backend/libpq/pqmq.c b/src/backend/libpq/pqmq.c index 4d0415e..728301f 100644 --- a/src/backend/libpq/pqmq.c +++ b/src/backend/libpq/pqmq.c @@ -162,10 +162,20 @@ mq_putmessage(char msgtype, const char *s, size_t len) result = shm_mq_sendv(pq_mq_handle, iov, 2, true, true); if (pq_mq_parallel_leader_pid != 0) + { SendProcSignal(pq_mq_parallel_leader_pid, PROCSIG_PARALLEL_MESSAGE, pq_mq_parallel_leader_backend_id); + /* + * XXX maybe we can reuse the PROCSIG_PARALLEL_MESSAGE instead of + * introducing a new signal reason. + */ + SendProcSignal(pq_mq_parallel_leader_pid, + PROCSIG_APPLY_BGWORKER_MESSAGE, + pq_mq_parallel_leader_backend_id); + } + if (result != SHM_MQ_WOULD_BLOCK) break; diff --git a/src/backend/postmaster/bgworker.c b/src/backend/postmaster/bgworker.c index 40601ae..40ccb89 100644 --- a/src/backend/postmaster/bgworker.c +++ b/src/backend/postmaster/bgworker.c @@ -128,6 +128,9 @@ static const struct }, { "ApplyWorkerMain", ApplyWorkerMain + }, + { + "ApplyBgworkerMain", ApplyBgworkerMain } }; diff --git a/src/backend/replication/logical/Makefile b/src/backend/replication/logical/Makefile index c4e2fde..cbfb5d7 100644 --- a/src/backend/replication/logical/Makefile +++ b/src/backend/replication/logical/Makefile @@ -15,6 +15,7 @@ include $(top_builddir)/src/Makefile.global override CPPFLAGS := -I$(srcdir) $(CPPFLAGS) OBJS = \ + applybgworker.o \ decode.o \ launcher.o \ logical.o \ diff --git a/src/backend/replication/logical/applybgworker.c b/src/backend/replication/logical/applybgworker.c new file mode 100644 index 0000000..0852ffa --- /dev/null +++ b/src/backend/replication/logical/applybgworker.c @@ -0,0 +1,973 @@ +/*------------------------------------------------------------------------- + * applybgworker.c + * Support routines for applying xact by apply background worker + * + * Copyright (c) 2016-2022, PostgreSQL Global Development Group + * + * IDENTIFICATION + * src/backend/replication/logical/applybgworker.c + * + * This file contains routines that are intended to support setting up, using, + * and tearing down a ApplyBgworkerInfo. + * + * Refer to the comments in file header of logical/worker.c to see more + * information about apply background worker. + * + *------------------------------------------------------------------------- + */ + +#include "postgres.h" + +#include "libpq/pqformat.h" +#include "libpq/pqmq.h" +#include "mb/pg_wchar.h" +#include "pgstat.h" +#include "postmaster/interrupt.h" +#include "replication/logicallauncher.h" +#include "replication/logicalworker.h" +#include "replication/origin.h" +#include "replication/walreceiver.h" +#include "replication/worker_internal.h" +#include "storage/ipc.h" +#include "storage/procarray.h" +#include "tcop/tcopprot.h" +#include "utils/inval.h" +#include "utils/memutils.h" +#include "utils/resowner.h" +#include "utils/syscache.h" + +#define PG_LOGICAL_APPLY_SHM_MAGIC 0x787ca067 + +/* + * DSM keys for apply background worker. Unlike other parallel execution code, + * since we don't need to worry about DSM keys conflicting with plan_node_id we + * can use small integers. + */ +#define APPLY_BGWORKER_KEY_SHARED 1 +#define APPLY_BGWORKER_KEY_MQ 2 +#define APPLY_BGWORKER_KEY_ERROR_QUEUE 3 + +/* Queue size of DSM, 16 MB for now. */ +#define DSM_QUEUE_SIZE (16 * 1024 * 1024) + +/* + * Error queue size of DSM. It is desirable to make it large enough that a + * typical ErrorResponse can be sent without blocking. That way, a worker that + * errors out can write the whole message into the queue and terminate without + * waiting for the user backend. + */ +#define DSM_ERROR_QUEUE_SIZE 16384 + +/* + * There are three fields in message: start_lsn, end_lsn and send_time. Because + * we have updated these statistics in apply worker, we could ignore these + * fields in apply background worker (see function LogicalRepApplyLoop). + */ +#define SIZE_STATS_MESSAGE (2 * sizeof(XLogRecPtr) + sizeof(TimestampTz)) + +/* + * Entry for a hash table we use to map from xid to the apply background worker + * state. + */ +typedef struct ApplyBgworkerEntry +{ + TransactionId xid; /* Hash key -- must be first */ + ApplyBgworkerInfo *winfo; +} ApplyBgworkerEntry; + +/* Apply background workers hash table (initialized on first use). */ +static HTAB *ApplyBgworkersHash = NULL; +static List *ApplyBgworkersFreeList = NIL; +static List *ApplyBgworkersList = NIL; + +/* + * Information shared between main apply worker and apply background worker. + */ +volatile ApplyBgworkerShared *MyParallelShared = NULL; + +/* + * Is there a message pending in apply background worker which we need to + * receive? + */ +volatile bool ApplyBgworkerMessagePending = false; + +/* + * Cache a pointer to the apply background worker which is responsible for + * applying the current streaming transactions. It is used to save the + * cost of searhing the hash table when applying the changes between + * STREAM_START and STREAM_STOP. + */ +ApplyBgworkerInfo *stream_apply_worker = NULL; + +List *subxactlist = NIL; + +static bool apply_bgworker_can_start(TransactionId xid); +static ApplyBgworkerInfo *apply_bgworker_setup(void); +static bool apply_bgworker_setup_dsm(ApplyBgworkerInfo *winfo); + +/* + * Check if starting a new apply background worker is allowed. + */ +static bool +apply_bgworker_can_start(TransactionId xid) +{ + if (!TransactionIdIsValid(xid)) + return false; + + /* + * Don't start a new background worker if not in streaming parallel mode. + */ + if (MySubscription->stream != SUBSTREAM_PARALLEL) + return false; + + /* + * Don't start a new background worker if user has set skiplsn as it's + * possible that user want to skip the streaming transaction. For + * streaming transaction, we need to spill the transaction to disk so that + * we can get the last LSN of the transaction to judge whether to skip + * before starting to apply the change. + */ + if (!XLogRecPtrIsInvalid(MySubscription->skiplsn)) + return false; + + /* + * For streaming transactions that are being applied using apply background + * worker, we cannot decide whether to apply the change for a relation that + * is not in the READY state (see should_apply_changes_for_rel) as we won't + * know remote_final_lsn by that time. So, we don't start the new apply + * background worker in this case. + */ + if (!AllTablesyncsReady()) + return false; + + return true; +} + +/* + * Return the apply background worker that will be used for the specified xid. + * + * If an apply background worker is found in the free list then re-use it, + * otherwise start a fresh one. Cache the worker in ApplyBgworkersHash keyed by + * the specified xid. + */ +ApplyBgworkerInfo * +apply_bgworker_start(TransactionId xid) +{ + bool found; + int server_version; + ApplyBgworkerInfo *winfo = NULL; + ApplyBgworkerEntry *entry = NULL; + + if (!apply_bgworker_can_start(xid)) + return NULL; + + /* First time through, initialize apply workers hashtable. */ + if (ApplyBgworkersHash == NULL) + { + HASHCTL ctl; + + MemSet(&ctl, 0, sizeof(ctl)); + ctl.keysize = sizeof(TransactionId); + ctl.entrysize = sizeof(ApplyBgworkerEntry); + ctl.hcxt = ApplyContext; + + ApplyBgworkersHash = hash_create("logical apply workers hash", 16, &ctl, + HASH_ELEM | HASH_BLOBS | HASH_CONTEXT); + } + + /* Try to get a free apply background worker. */ + while (ApplyBgworkersFreeList != NIL) + { + ApplyBgworkerInfo *tmp_winfo; + + tmp_winfo = (ApplyBgworkerInfo *) llast(ApplyBgworkersFreeList); + ApplyBgworkersFreeList = list_delete_last(ApplyBgworkersFreeList); + + if (tmp_winfo->error_mq_handle != NULL) + { + winfo = tmp_winfo; + winfo->shared->state = APPLY_BGWORKER_BUSY; + break; + } + + /* + * Release the worker information and try next one if the apply + * background worker exited cleanly. + */ + ApplyBgworkersList = list_delete(ApplyBgworkersList, tmp_winfo); + shm_mq_detach(tmp_winfo->mq_handle); + dsm_detach(tmp_winfo->dsm_seg); + pfree(tmp_winfo); + } + + /* Try to start a new apply background worker. */ + if (winfo == NULL) + winfo = apply_bgworker_setup(); + + /* Failed to start a new apply background worker. */ + if (winfo == NULL) + return NULL; + + /* Create entry for requested transaction. */ + entry = hash_search(ApplyBgworkersHash, &xid, HASH_ENTER, &found); + if (found) + elog(ERROR, "hash table corrupted"); + + server_version = walrcv_server_version(LogRepWorkerWalRcvConn); + winfo->shared->proto_version = + server_version >= 160000 ? LOGICALREP_PROTO_STREAM_PARALLEL_VERSION_NUM : + server_version >= 150000 ? LOGICALREP_PROTO_TWOPHASE_VERSION_NUM : + server_version >= 140000 ? LOGICALREP_PROTO_STREAM_VERSION_NUM : + LOGICALREP_PROTO_VERSION_NUM; + + winfo->shared->stream_xid = xid; + entry->winfo = winfo; + entry->xid = xid; + + return winfo; +} + +/* + * Find the previously assigned worker for the given transaction, if any. + */ +ApplyBgworkerInfo * +apply_bgworker_find(TransactionId xid) +{ + bool found; + ApplyBgworkerEntry *entry = NULL; + + if (!TransactionIdIsValid(xid)) + return NULL; + + if (ApplyBgworkersHash == NULL) + return NULL; + + /* Return the cached apply background worker if valid. */ + if (stream_apply_worker != NULL) + return stream_apply_worker; + + /* + * Find entry for requested transaction. + */ + entry = hash_search(ApplyBgworkersHash, &xid, HASH_FIND, &found); + if (found) + { + /* If any workers (or the postmaster) have died, we have failed. */ + if (entry->winfo->error_mq_handle == NULL) + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("background worker %u failed to apply transaction %u", + entry->winfo->shared->worker_id, + entry->winfo->shared->stream_xid))); + + Assert(entry->winfo->shared->state == APPLY_BGWORKER_BUSY); + + return entry->winfo; + } + + return NULL; +} + +/* + * Remove the apply background worker entry from the hash table. And stop the + * worker if there are enough workers in the pool, otherwise add it to the free + * list. + */ +void +apply_bgworker_free(ApplyBgworkerInfo *winfo) +{ + TransactionId xid = winfo->shared->stream_xid; + int napplyworkers; + + Assert(winfo->shared->state == APPLY_BGWORKER_FINISHED); + + hash_search(ApplyBgworkersHash, &xid, HASH_REMOVE, NULL); + + elog(DEBUG1, "adding finished apply worker %u for xid %u to the free list", + winfo->shared->worker_id, winfo->shared->stream_xid); + + /* Check if there are free worker slot(s). */ + LWLockAcquire(LogicalRepWorkerLock, LW_SHARED); + napplyworkers = logicalrep_apply_bgworker_count(MyLogicalRepWorker->subid); + LWLockRelease(LogicalRepWorkerLock); + + if (napplyworkers > (max_apply_bgworkers_per_subscription / 2)) + { + logicalrep_worker_stop_by_slot(winfo->shared->logicalrep_worker_slot_no, + winfo->shared->logicalrep_worker_generation); + + ApplyBgworkersList = list_delete_ptr(ApplyBgworkersList, winfo); + + shm_mq_detach(winfo->mq_handle); + shm_mq_detach(winfo->error_mq_handle); + dsm_detach(winfo->dsm_seg); + pfree(winfo); + } + else + { + MemoryContext oldctx = MemoryContextSwitchTo(ApplyContext); + ApplyBgworkersFreeList = lappend(ApplyBgworkersFreeList, winfo); + MemoryContextSwitchTo(oldctx); + } +} + +/* Apply Background Worker main loop. */ +static void +LogicalApplyBgwLoop(shm_mq_handle *mqh, volatile ApplyBgworkerShared *shared) +{ + shm_mq_result shmq_res; + PGPROC *registrant; + ErrorContextCallback errcallback; + + registrant = BackendPidGetProc(MyBgworkerEntry->bgw_notify_pid); + SetLatch(®istrant->procLatch); + + /* + * Init the ApplyMessageContext which we clean up after each replication + * protocol message. + */ + ApplyMessageContext = AllocSetContextCreate(ApplyContext, + "ApplyMessageContext", + ALLOCSET_DEFAULT_SIZES); + + /* + * Push apply error context callback. Fields will be filled while applying + * a change. + */ + errcallback.callback = apply_error_callback; + errcallback.previous = error_context_stack; + error_context_stack = &errcallback; + + for (;;) + { + void *data; + Size len; + int c; + StringInfoData s; + MemoryContext oldctx; + + CHECK_FOR_INTERRUPTS(); + + /* Ensure we are reading the data into our memory context. */ + oldctx = MemoryContextSwitchTo(ApplyMessageContext); + + shmq_res = shm_mq_receive(mqh, &len, &data, false); + + if (shmq_res != SHM_MQ_SUCCESS) + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("lost connection to the main apply worker"))); + + if (len == 0) + break; + + s.cursor = 0; + s.maxlen = -1; + s.data = (char *) data; + s.len = len; + + /* + * The first byte of message for additional communication between main + * Logical replication worker and apply background workers can only be + * 'w'. + */ + c = pq_getmsgbyte(&s); + if (c != 'w') + elog(ERROR, "[Apply BGW #%u] unexpected message \"%c\"", + shared->worker_id, c); + + /* + * Ignore statistics fields that have been updated by the main apply + * worker. + */ + s.cursor += SIZE_STATS_MESSAGE; + + apply_dispatch(&s); + + MemoryContextSwitchTo(oldctx); + MemoryContextReset(ApplyMessageContext); + + if (ConfigReloadPending) + { + ConfigReloadPending = false; + ProcessConfigFile(PGC_SIGHUP); + } + } + + /* Pop the error context stack. */ + error_context_stack = errcallback.previous; + + elog(DEBUG1, "[Apply BGW #%u] exiting", shared->worker_id); + + /* Signal main process that we are done. */ + SetLatch(®istrant->procLatch); +} + +/* + * Make sure the main apply worker tries to read from our error queue one more + * time. This guards against the case where we exit uncleanly without sending + * an ErrorResponse, for example because some code calls proc_exit directly. + */ +static void +apply_bgworker_shutdown(int code, Datum arg) +{ + SendProcSignal(MyLogicalRepWorker->apply_leader_pid, + PROCSIG_APPLY_BGWORKER_MESSAGE, + InvalidBackendId); + + dsm_detach((dsm_segment *) DatumGetPointer(arg)); +} + +/* + * Apply Background Worker entry point. + */ +void +ApplyBgworkerMain(Datum main_arg) +{ + volatile ApplyBgworkerShared *shared; + + dsm_handle handle; + dsm_segment *seg; + shm_toc *toc; + shm_mq *mq; + shm_mq_handle *mqh; + shm_mq_handle *error_mqh; + RepOriginId originid; + int worker_slot = DatumGetInt32(main_arg); + char originname[NAMEDATALEN]; + + /* Setup signal handling. */ + pqsignal(SIGHUP, SignalHandlerForConfigReload); + pqsignal(SIGTERM, die); + BackgroundWorkerUnblockSignals(); + + /* + * Attach to the dynamic shared memory segment for the parallel query, and + * find its table of contents. + * + * Note: at this point, we have not created any ResourceOwner in this + * process. This will result in our DSM mapping surviving until process + * exit, which is fine. If there were a ResourceOwner, it would acquire + * ownership of the mapping, but we have no need for that. + */ + memcpy(&handle, MyBgworkerEntry->bgw_extra, sizeof(dsm_handle)); + seg = dsm_attach(handle); + if (seg == NULL) + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("unable to map dynamic shared memory segment"))); + + toc = shm_toc_attach(PG_LOGICAL_APPLY_SHM_MAGIC, dsm_segment_address(seg)); + if (toc == NULL) + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("bad magic number in dynamic shared memory segment"))); + + before_shmem_exit(apply_bgworker_shutdown, PointerGetDatum(seg)); + + /* Look up the shared information. */ + shared = shm_toc_lookup(toc, APPLY_BGWORKER_KEY_SHARED, false); + MyParallelShared = shared; + + /* + * Attach to the message queue. + */ + mq = shm_toc_lookup(toc, APPLY_BGWORKER_KEY_MQ, false); + shm_mq_set_receiver(mq, MyProc); + mqh = shm_mq_attach(mq, seg, NULL); + + /* + * Attach to the message queue. + */ + mq = shm_toc_lookup(toc, APPLY_BGWORKER_KEY_ERROR_QUEUE, false); + shm_mq_set_sender(mq, MyProc); + error_mqh = shm_mq_attach(mq, seg, NULL); + pq_redirect_to_shm_mq(seg, error_mqh); + + /* + * Now, we have initialized DSM. Attach to slot. + */ + logicalrep_worker_attach(worker_slot); + MyParallelShared->logicalrep_worker_generation = MyLogicalRepWorker->generation; + MyParallelShared->logicalrep_worker_slot_no = worker_slot; + + pq_set_parallel_leader(MyLogicalRepWorker->apply_leader_pid, + InvalidBackendId); + + MyLogicalRepWorker->last_send_time = MyLogicalRepWorker->last_recv_time = + MyLogicalRepWorker->reply_time = 0; + + InitializeApplyWorker(); + + /* Setup replication origin tracking. */ + StartTransactionCommand(); + snprintf(originname, sizeof(originname), "pg_%u", MySubscription->oid); + originid = replorigin_by_name(originname, true); + if (!OidIsValid(originid)) + originid = replorigin_create(originname); + + /* + * The apply background worker doesn't need to monopolize this replication + * origin which was already acquired by its leader process. + */ + replorigin_session_setup(originid, MyLogicalRepWorker->apply_leader_pid); + replorigin_session_origin = originid; + CommitTransactionCommand(); + + /* + * Setup callback for syscache so that we know when something changes in + * the subscription relation state. + */ + CacheRegisterSyscacheCallback(SUBSCRIPTIONRELMAP, + invalidate_syncing_table_states, + (Datum) 0); + + /* + * Allocate the origin name in long-lived context for error context + * message. + */ + apply_error_callback_arg.origin_name = MemoryContextStrdup(ApplyContext, + originname); + + elog(DEBUG1, "[Apply BGW #%u] started", shared->worker_id); + + LogicalApplyBgwLoop(mqh, shared); + + proc_exit(0); +} + +/* + * Handle receipt of an interrupt indicating a apply background worker message. + * + * Note: this is called within a signal handler! All we can do is set a flag + * that will cause the next CHECK_FOR_INTERRUPTS() to invoke + * HandleApplyBgworkerMessages(). + */ +void +HandleApplyBgworkerMessageInterrupt(void) +{ + InterruptPending = true; + ApplyBgworkerMessagePending = true; + SetLatch(MyLatch); +} + +/* + * Handle a single protocol message received from a single apply background + * worker. + */ +static void +HandleApplyBgworkerMessage(ApplyBgworkerInfo *winfo, StringInfo msg) +{ + char msgtype; + + msgtype = pq_getmsgbyte(msg); + + switch (msgtype) + { + case 'E': /* ErrorResponse */ + { + ErrorData edata; + ErrorContextCallback *save_error_context_stack; + + /* Parse ErrorResponse. */ + pq_parse_errornotice(msg, &edata); + + /* Death of a worker isn't enough justification for suicide. */ + edata.elevel = Min(edata.elevel, ERROR); + + /* + * If desired, add a context line to show that this is a + * message propagated from a apply background worker. + * Otherwise, it can sometimes be confusing to understand what + * actually happened. + */ + if (edata.context) + edata.context = psprintf("%s\n%s", edata.context, + _("apply background worker")); + else + edata.context = pstrdup(_("apply background worker")); + + /* + * Context beyond that should use the error context callbacks + * that were in effect in LogicalRepApplyLoop(). + */ + save_error_context_stack = error_context_stack; + error_context_stack = apply_error_context_stack; + + ThrowErrorData(&edata); + + /* Should not reach here after rethrowing an error. */ + error_context_stack = save_error_context_stack; + + break; + } + + case 'X': /* Terminate, indicating clean exit */ + { + shm_mq_detach(winfo->error_mq_handle); + winfo->error_mq_handle = NULL; + break; + } + + /* + * Don't need to do anything about NoticeResponse and + * NotifyResponse as the logical replication worker doesn't need to + * send messages to the client. + */ + case 'N': + case 'A': + break; + default: + { + elog(ERROR, "unrecognized message type received from apply background worker: %c (message length %d bytes)", + msgtype, msg->len); + } + } +} + +/* + * Handle any queued protocol messages received from apply background workers. + */ +void +HandleApplyBgworkerMessages(void) +{ + ListCell *lc; + MemoryContext oldcontext; + + static MemoryContext hpm_context = NULL; + + /* + * This is invoked from ProcessInterrupts(), and since some of the + * functions it calls contain CHECK_FOR_INTERRUPTS(), there is a potential + * for recursive calls if more signals are received while this runs. It's + * unclear that recursive entry would be safe, and it doesn't seem useful + * even if it is safe, so let's block interrupts until done. + */ + HOLD_INTERRUPTS(); + + /* + * Moreover, CurrentMemoryContext might be pointing almost anywhere. We + * don't want to risk leaking data into long-lived contexts, so let's do + * our work here in a private context that we can reset on each use. + */ + if (hpm_context == NULL) /* first time through? */ + hpm_context = AllocSetContextCreate(TopMemoryContext, + "HandleApplyBgworkerMessages", + ALLOCSET_DEFAULT_SIZES); + else + MemoryContextReset(hpm_context); + + oldcontext = MemoryContextSwitchTo(hpm_context); + + /* OK to process messages. Reset the flag saying there are more to do. */ + ApplyBgworkerMessagePending = false; + + foreach(lc, ApplyBgworkersList) + { + shm_mq_result res; + Size nbytes; + void *data; + ApplyBgworkerInfo *winfo = (ApplyBgworkerInfo *) lfirst(lc); + + if (winfo->error_mq_handle == NULL) + continue; + + res = shm_mq_receive(winfo->error_mq_handle, &nbytes, + &data, true); + + if (res == SHM_MQ_WOULD_BLOCK) + break; + else if (res == SHM_MQ_SUCCESS) + { + StringInfoData msg; + + initStringInfo(&msg); + appendBinaryStringInfo(&msg, data, nbytes); + HandleApplyBgworkerMessage(winfo, &msg); + pfree(msg.data); + } + else + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("lost connection to the main apply worker"))); + } + + MemoryContextSwitchTo(oldcontext); + + /* Might as well clear the context on our way out */ + MemoryContextReset(hpm_context); + + RESUME_INTERRUPTS(); +} + +/* + * Set up a dynamic shared memory segment. + * + * We set up a control region that contains a ApplyBgworkerShared, + * plus one region per message queue. There are as many message queues as + * the number of workers. + * + * Returns true on success, false on failure. + */ +static bool +apply_bgworker_setup_dsm(ApplyBgworkerInfo *winfo) +{ + shm_toc_estimator e; + Size segsize; + dsm_segment *seg; + shm_toc *toc; + ApplyBgworkerShared *shared; + shm_mq *mq; + Size queue_size = DSM_QUEUE_SIZE; + Size error_queue_size = DSM_ERROR_QUEUE_SIZE; + int server_version; + + /* + * Estimate how much shared memory we need. + * + * Because the TOC machinery may choose to insert padding of oddly-sized + * requests, we must estimate each chunk separately. + * + * We need one key to register the location of the header, and we need + * another key to track the location of the message queue. + */ + shm_toc_initialize_estimator(&e); + shm_toc_estimate_chunk(&e, sizeof(ApplyBgworkerShared)); + shm_toc_estimate_chunk(&e, queue_size); + shm_toc_estimate_chunk(&e, error_queue_size); + + shm_toc_estimate_keys(&e, 2); + segsize = shm_toc_estimate(&e); + + /* Create the shared memory segment and establish a table of contents. */ + seg = dsm_create(shm_toc_estimate(&e), 0); + if (seg == NULL) + return false; + + toc = shm_toc_create(PG_LOGICAL_APPLY_SHM_MAGIC, dsm_segment_address(seg), + segsize); + + /* Set up the header region. */ + shared = shm_toc_allocate(toc, sizeof(ApplyBgworkerShared)); + SpinLockInit(&shared->mutex); + shared->state = APPLY_BGWORKER_BUSY; + + server_version = walrcv_server_version(LogRepWorkerWalRcvConn); + shared->proto_version = + server_version >= 160000 ? LOGICALREP_PROTO_STREAM_PARALLEL_VERSION_NUM : + server_version >= 150000 ? LOGICALREP_PROTO_TWOPHASE_VERSION_NUM : + server_version >= 140000 ? LOGICALREP_PROTO_STREAM_VERSION_NUM : + LOGICALREP_PROTO_VERSION_NUM; + + shared->stream_xid = stream_xid; + shared->worker_id = list_length(ApplyBgworkersList) + 1; + + shm_toc_insert(toc, APPLY_BGWORKER_KEY_SHARED, shared); + + /* Set up message queue for the worker. */ + mq = shm_mq_create(shm_toc_allocate(toc, queue_size), queue_size); + shm_toc_insert(toc, APPLY_BGWORKER_KEY_MQ, mq); + shm_mq_set_sender(mq, MyProc); + + /* Attach the queue. */ + winfo->mq_handle = shm_mq_attach(mq, seg, NULL); + + /* Set up error queue for the worker. */ + mq = shm_mq_create(shm_toc_allocate(toc, error_queue_size), + error_queue_size); + shm_toc_insert(toc, APPLY_BGWORKER_KEY_ERROR_QUEUE, mq); + shm_mq_set_receiver(mq, MyProc); + + /* Attach the queue. */ + winfo->error_mq_handle = shm_mq_attach(mq, seg, NULL); + + /* Return results to caller. */ + winfo->dsm_seg = seg; + winfo->shared = shared; + + return true; +} + +/* + * Start apply background worker process and allocate shared memory for it. + */ +static ApplyBgworkerInfo * +apply_bgworker_setup(void) +{ + MemoryContext oldcontext; + bool launched; + ApplyBgworkerInfo *winfo; + int napplyworkers; + + elog(DEBUG1, "setting up apply background worker %u", + list_length(ApplyBgworkersList) + 1); + + /* Check if there are free worker slot(s). */ + LWLockAcquire(LogicalRepWorkerLock, LW_SHARED); + napplyworkers = logicalrep_apply_bgworker_count(MyLogicalRepWorker->subid); + LWLockRelease(LogicalRepWorkerLock); + + if (napplyworkers >= max_apply_bgworkers_per_subscription) + return NULL; + + oldcontext = MemoryContextSwitchTo(ApplyContext); + + winfo = (ApplyBgworkerInfo *) palloc0(sizeof(ApplyBgworkerInfo)); + + /* Setup shared memory. */ + if (!apply_bgworker_setup_dsm(winfo)) + { + MemoryContextSwitchTo(oldcontext); + pfree(winfo); + + return NULL; + } + + launched = logicalrep_worker_launch(MyLogicalRepWorker->dbid, + MySubscription->oid, + MySubscription->name, + MyLogicalRepWorker->userid, + InvalidOid, + dsm_segment_handle(winfo->dsm_seg)); + + if (launched) + ApplyBgworkersList = lappend(ApplyBgworkersList, winfo); + else + { + shm_mq_detach(winfo->mq_handle); + shm_mq_detach(winfo->error_mq_handle); + dsm_detach(winfo->dsm_seg); + pfree(winfo); + + winfo = NULL; + } + + MemoryContextSwitchTo(oldcontext); + + return winfo; +} + +/* + * Send the data to the specified apply background worker via shared-memory queue. + */ +void +apply_bgworker_send_data(ApplyBgworkerInfo *winfo, Size nbytes, const void *data) +{ + shm_mq_result result; + + result = shm_mq_send(winfo->mq_handle, nbytes, data, false, true); + + if (result != SHM_MQ_SUCCESS) + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("could not send data to shared-memory queue"))); +} + +/* + * Wait until the state of apply background worker reaches the + * 'wait_for_state'. + */ +void +apply_bgworker_wait_for(ApplyBgworkerInfo *winfo, + ApplyBgworkerState wait_for_state) +{ + for (;;) + { + char state; + + SpinLockAcquire(&winfo->shared->mutex); + state = winfo->shared->state; + SpinLockRelease(&winfo->shared->mutex); + + /* Done if already in correct state. */ + if (state == wait_for_state) + break; + + /* If any workers have died, we have failed. */ + if (winfo->error_mq_handle == NULL) + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("apply background worker %u failed to apply transaction %u", + winfo->shared->worker_id, winfo->shared->stream_xid))); + + /* Wait to be signalled. */ + (void) WaitLatch(MyLatch, + WL_LATCH_SET | WL_TIMEOUT | WL_EXIT_ON_PM_DEATH, + 1000L, + WAIT_EVENT_LOGICAL_APPLY_BGWORKER_STATE_CHANGE); + + /* Reset the latch so we don't spin. */ + ResetLatch(MyLatch); + + /* An interrupt may have occurred while we were waiting. */ + CHECK_FOR_INTERRUPTS(); + } +} + +/* Set the apply background worker state. */ +void +apply_bgworker_set_state(ApplyBgworkerState state) +{ + elog(DEBUG1, "[Apply BGW #%u] set state to %d", MyParallelShared->worker_id, state); + + SpinLockAcquire(&MyParallelShared->mutex); + MyParallelShared->state = state; + SpinLockRelease(&MyParallelShared->mutex); +} + +/* + * Define a savepoint for a subxact in apply background worker if needed. + * + * The apply background worker can figure out if a new subtransaction was + * started by checking if the new change arrived with different xid. In that + * case define a named savepoint, so that we are able to commit/rollback it + * separately later. + */ +void +apply_bgworker_subxact_info_add(TransactionId current_xid) +{ + if (current_xid != stream_xid && + !list_member_int(subxactlist, (int) current_xid)) + { + MemoryContext oldctx; + char spname[MAXPGPATH]; + + apply_bgworker_savepoint_name(MySubscription->oid, current_xid, + spname, sizeof(spname)); + + elog(DEBUG1, "[Apply BGW #%u] defining savepoint %s", + MyParallelShared->worker_id, spname); + + /* We must be in transaction block to define the SAVEPOINT. */ + if (!IsTransactionBlock()) + { + BeginTransactionBlock(); + CommitTransactionCommand(); + } + + DefineSavepoint(spname); + + /* + * CommitTransactionCommand is needed to start a subtransaction after + * issuing a SAVEPOINT inside a transaction block (see + * StartSubTransaction()). + */ + CommitTransactionCommand(); + + oldctx = MemoryContextSwitchTo(ApplyContext); + subxactlist = lappend_int(subxactlist, (int) current_xid); + MemoryContextSwitchTo(oldctx); + } +} + +/* + * Form the savepoint name for the streaming transaction. + * + * Return the name in the supplied buffer. + */ +void +apply_bgworker_savepoint_name(Oid suboid, TransactionId xid, + char *spname, int szsp) +{ + snprintf(spname, szsp, "pg_sp_%u_%u", suboid, xid); +} diff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c index 1667d72..a437683 100644 --- a/src/backend/replication/logical/decode.c +++ b/src/backend/replication/logical/decode.c @@ -652,9 +652,10 @@ DecodeCommit(LogicalDecodingContext *ctx, XLogRecordBuffer *buf, { for (i = 0; i < parsed->nsubxacts; i++) { - ReorderBufferForget(ctx->reorder, parsed->subxacts[i], buf->origptr); + ReorderBufferForget(ctx->reorder, parsed->subxacts[i], buf->origptr, + commit_time); } - ReorderBufferForget(ctx->reorder, xid, buf->origptr); + ReorderBufferForget(ctx->reorder, xid, buf->origptr, commit_time); return; } @@ -822,10 +823,11 @@ DecodeAbort(LogicalDecodingContext *ctx, XLogRecordBuffer *buf, for (i = 0; i < parsed->nsubxacts; i++) { ReorderBufferAbort(ctx->reorder, parsed->subxacts[i], - buf->record->EndRecPtr); + buf->record->EndRecPtr, abort_time); } - ReorderBufferAbort(ctx->reorder, xid, buf->record->EndRecPtr); + ReorderBufferAbort(ctx->reorder, xid, buf->record->EndRecPtr, + abort_time); } /* update the decoding stats */ diff --git a/src/backend/replication/logical/launcher.c b/src/backend/replication/logical/launcher.c index 3bbd522..c7ffcc3 100644 --- a/src/backend/replication/logical/launcher.c +++ b/src/backend/replication/logical/launcher.c @@ -54,6 +54,7 @@ int max_logical_replication_workers = 4; int max_sync_workers_per_subscription = 2; +int max_apply_bgworkers_per_subscription = 2; LogicalRepWorker *MyLogicalRepWorker = NULL; @@ -73,6 +74,7 @@ static void logicalrep_launcher_onexit(int code, Datum arg); static void logicalrep_worker_onexit(int code, Datum arg); static void logicalrep_worker_detach(void); static void logicalrep_worker_cleanup(LogicalRepWorker *worker); +static void logicalrep_worker_stop_internal(LogicalRepWorker *worker); static bool on_commit_launcher_wakeup = false; @@ -151,8 +153,10 @@ get_subscription_list(void) * * This is only needed for cleaning up the shared memory in case the worker * fails to attach. + * + * Return whether the attach was successful. */ -static void +static bool WaitForReplicationWorkerAttach(LogicalRepWorker *worker, uint16 generation, BackgroundWorkerHandle *handle) @@ -168,11 +172,11 @@ WaitForReplicationWorkerAttach(LogicalRepWorker *worker, LWLockAcquire(LogicalRepWorkerLock, LW_SHARED); - /* Worker either died or has started; no need to do anything. */ + /* Worker either died or has started. Return false if died. */ if (!worker->in_use || worker->proc) { LWLockRelease(LogicalRepWorkerLock); - return; + return worker->in_use; } LWLockRelease(LogicalRepWorkerLock); @@ -187,7 +191,7 @@ WaitForReplicationWorkerAttach(LogicalRepWorker *worker, if (generation == worker->generation) logicalrep_worker_cleanup(worker); LWLockRelease(LogicalRepWorkerLock); - return; + return false; } /* @@ -209,6 +213,8 @@ WaitForReplicationWorkerAttach(LogicalRepWorker *worker, /* * Walks the workers array and searches for one that matches given * subscription id and relid. + * + * We are only interested in the main apply worker or table sync worker. */ LogicalRepWorker * logicalrep_worker_find(Oid subid, Oid relid, bool only_running) @@ -223,6 +229,10 @@ logicalrep_worker_find(Oid subid, Oid relid, bool only_running) { LogicalRepWorker *w = &LogicalRepCtx->workers[i]; + /* Skip apply background workers. */ + if (isApplyBgWorker(w)) + continue; + if (w->in_use && w->subid == subid && w->relid == relid && (!only_running || w->proc)) { @@ -259,11 +269,13 @@ logicalrep_workers_find(Oid subid, bool only_running) } /* - * Start new apply background worker, if possible. + * Start new background worker, if possible. + * + * Returns true on success, false on failure. */ -void +bool logicalrep_worker_launch(Oid dbid, Oid subid, const char *subname, Oid userid, - Oid relid) + Oid relid, dsm_handle subworker_dsm) { BackgroundWorker bgw; BackgroundWorkerHandle *bgw_handle; @@ -273,6 +285,10 @@ logicalrep_worker_launch(Oid dbid, Oid subid, const char *subname, Oid userid, LogicalRepWorker *worker = NULL; int nsyncworkers; TimestampTz now; + bool is_subworker = (subworker_dsm != DSM_HANDLE_INVALID); + + /* Sanity check: we don't support table sync in subworker. */ + Assert(!(is_subworker && OidIsValid(relid))); ereport(DEBUG1, (errmsg_internal("starting logical replication worker for subscription \"%s\"", @@ -350,7 +366,7 @@ retry: if (OidIsValid(relid) && nsyncworkers >= max_sync_workers_per_subscription) { LWLockRelease(LogicalRepWorkerLock); - return; + return false; } /* @@ -364,7 +380,7 @@ retry: (errcode(ERRCODE_CONFIGURATION_LIMIT_EXCEEDED), errmsg("out of logical replication worker slots"), errhint("You might need to increase max_logical_replication_workers."))); - return; + return false; } /* Prepare the worker slot. */ @@ -379,6 +395,7 @@ retry: worker->relstate = SUBREL_STATE_UNKNOWN; worker->relstate_lsn = InvalidXLogRecPtr; worker->stream_fileset = NULL; + worker->apply_leader_pid = is_subworker ? MyProcPid : InvalidPid; worker->last_lsn = InvalidXLogRecPtr; TIMESTAMP_NOBEGIN(worker->last_send_time); TIMESTAMP_NOBEGIN(worker->last_recv_time); @@ -396,10 +413,18 @@ retry: BGWORKER_BACKEND_DATABASE_CONNECTION; bgw.bgw_start_time = BgWorkerStart_RecoveryFinished; snprintf(bgw.bgw_library_name, BGW_MAXLEN, "postgres"); - snprintf(bgw.bgw_function_name, BGW_MAXLEN, "ApplyWorkerMain"); + + if (is_subworker) + snprintf(bgw.bgw_function_name, BGW_MAXLEN, "ApplyBgworkerMain"); + else + snprintf(bgw.bgw_function_name, BGW_MAXLEN, "ApplyWorkerMain"); + if (OidIsValid(relid)) snprintf(bgw.bgw_name, BGW_MAXLEN, "logical replication worker for subscription %u sync %u", subid, relid); + else if (is_subworker) + snprintf(bgw.bgw_name, BGW_MAXLEN, + "logical replication apply background worker for subscription %u", subid); else snprintf(bgw.bgw_name, BGW_MAXLEN, "logical replication worker for subscription %u", subid); @@ -409,6 +434,9 @@ retry: bgw.bgw_notify_pid = MyProcPid; bgw.bgw_main_arg = Int32GetDatum(slot); + if (is_subworker) + memcpy(bgw.bgw_extra, &subworker_dsm, sizeof(dsm_handle)); + if (!RegisterDynamicBackgroundWorker(&bgw, &bgw_handle)) { /* Failed to start worker, so clean up the worker slot. */ @@ -421,11 +449,11 @@ retry: (errcode(ERRCODE_CONFIGURATION_LIMIT_EXCEEDED), errmsg("out of background worker slots"), errhint("You might need to increase max_worker_processes."))); - return; + return false; } /* Now wait until it attaches. */ - WaitForReplicationWorkerAttach(worker, generation, bgw_handle); + return WaitForReplicationWorkerAttach(worker, generation, bgw_handle); } /* @@ -436,19 +464,52 @@ void logicalrep_worker_stop(Oid subid, Oid relid) { LogicalRepWorker *worker; - uint16 generation; LWLockAcquire(LogicalRepWorkerLock, LW_SHARED); worker = logicalrep_worker_find(subid, relid, false); - /* No worker, nothing to do. */ - if (!worker) + if (worker) { - LWLockRelease(LogicalRepWorkerLock); - return; + Assert(!isApplyBgWorker(worker)); + logicalrep_worker_stop_internal(worker); } + LWLockRelease(LogicalRepWorkerLock); +} + +/* + * Stop the logical replication worker corresponding to the input slot number, + * and wait until it detaches from the slot. + */ +void +logicalrep_worker_stop_by_slot(int slot_no, uint16 generation) +{ + LogicalRepWorker *worker = &LogicalRepCtx->workers[slot_no]; + + LWLockAcquire(LogicalRepWorkerLock, LW_SHARED); + + /* Return if the generation doesn't match or the worker is not alive. */ + if (worker->generation != generation || + worker->proc == NULL) + return; + + logicalrep_worker_stop_internal(worker); + + LWLockRelease(LogicalRepWorkerLock); +} + +/* + * Workhorse for logicalrep_worker_stop() and logicalrep_worker_detach(). Stop + * the worker and wait for it to die. + */ +static void +logicalrep_worker_stop_internal(LogicalRepWorker *worker) +{ + uint16 generation; + + Assert(LWLockHeldByMe(LogicalRepWorkerLock)); + /* * Remember which generation was our worker so we can check if what we see * is still the same one. @@ -485,10 +546,7 @@ logicalrep_worker_stop(Oid subid, Oid relid) * different, meaning that a different worker has taken the slot. */ if (!worker->in_use || worker->generation != generation) - { - LWLockRelease(LogicalRepWorkerLock); return; - } /* Worker has assigned proc, so it has started. */ if (worker->proc) @@ -522,8 +580,6 @@ logicalrep_worker_stop(Oid subid, Oid relid) LWLockAcquire(LogicalRepWorkerLock, LW_SHARED); } - - LWLockRelease(LogicalRepWorkerLock); } /* @@ -599,6 +655,29 @@ logicalrep_worker_attach(int slot) static void logicalrep_worker_detach(void) { + /* + * This is the main apply worker; stop all the apply background workers + * previously started from here. + */ + if (!isApplyBgWorker(MyLogicalRepWorker)) + { + List *workers; + ListCell *lc; + + LWLockAcquire(LogicalRepWorkerLock, LW_SHARED); + + workers = logicalrep_workers_find(MyLogicalRepWorker->subid, true); + foreach(lc, workers) + { + LogicalRepWorker *w = (LogicalRepWorker *) lfirst(lc); + + if (isApplyBgWorker(w)) + logicalrep_worker_stop_internal(w); + } + + LWLockRelease(LogicalRepWorkerLock); + } + /* Block concurrent access. */ LWLockAcquire(LogicalRepWorkerLock, LW_EXCLUSIVE); @@ -621,6 +700,7 @@ logicalrep_worker_cleanup(LogicalRepWorker *worker) worker->userid = InvalidOid; worker->subid = InvalidOid; worker->relid = InvalidOid; + worker->apply_leader_pid = InvalidPid; } /* @@ -680,6 +760,33 @@ logicalrep_sync_worker_count(Oid subid) } /* + * Count the number of registered (but not necessarily running) apply + * background workers for a subscription. + */ +int +logicalrep_apply_bgworker_count(Oid subid) +{ + int i; + int res = 0; + + Assert(LWLockHeldByMe(LogicalRepWorkerLock)); + + /* + * Scan all attached apply background workers, only counting those which + * have the given subscription id. + */ + for (i = 0; i < max_logical_replication_workers; i++) + { + LogicalRepWorker *w = &LogicalRepCtx->workers[i]; + + if (w->subid == subid && isApplyBgWorker(w)) + res++; + } + + return res; +} + +/* * ApplyLauncherShmemSize * Compute space needed for replication launcher shared memory */ @@ -868,7 +975,7 @@ ApplyLauncherMain(Datum main_arg) wait_time = wal_retrieve_retry_interval; logicalrep_worker_launch(sub->dbid, sub->oid, sub->name, - sub->owner, InvalidOid); + sub->owner, InvalidOid, DSM_HANDLE_INVALID); } } diff --git a/src/backend/replication/logical/origin.c b/src/backend/replication/logical/origin.c index 9eb97fa..a5f62a4 100644 --- a/src/backend/replication/logical/origin.c +++ b/src/backend/replication/logical/origin.c @@ -1075,12 +1075,21 @@ ReplicationOriginExitCleanup(int code, Datum arg) * array doesn't have to be searched when calling * replorigin_session_advance(). * - * Obviously only one such cached origin can exist per process and the current + * Normally only one such cached origin can exist per process and the current * cached value can only be set again after the previous value is torn down * with replorigin_session_reset(). + * + * However, if the function parameter 'apply_leader_pid' is not 0, we allow the + * process to use the same slot already acquired by another process. It's safe + * because 1) The only caller (apply background workers) will maintain the + * commit order by allowing only one process to commit at a time, so no two + * workers will be operating on the same origin at the same time (see comments + * in logical/worker.c). 2) Even though we try to advance the session's origin + * concurrently, it's safe to do so as we change/advance the session_origin + * LSNs under replicate_state LWLock. */ void -replorigin_session_setup(RepOriginId node) +replorigin_session_setup(RepOriginId node, int apply_leader_pid) { static bool registered_cleanup; int i; @@ -1122,7 +1131,7 @@ replorigin_session_setup(RepOriginId node) if (curstate->roident != node) continue; - else if (curstate->acquired_by != 0) + else if (curstate->acquired_by != 0 && apply_leader_pid == 0) { ereport(ERROR, (errcode(ERRCODE_OBJECT_IN_USE), @@ -1153,7 +1162,11 @@ replorigin_session_setup(RepOriginId node) Assert(session_replication_state->roident != InvalidRepOriginId); - session_replication_state->acquired_by = MyProcPid; + if (apply_leader_pid == 0) + session_replication_state->acquired_by = MyProcPid; + else if (session_replication_state->acquired_by != apply_leader_pid) + elog(ERROR, "could not find replication state slot for replication" + "origin with OID %u which was acquired by %d", node, apply_leader_pid); LWLockRelease(ReplicationOriginLock); @@ -1337,7 +1350,7 @@ pg_replication_origin_session_setup(PG_FUNCTION_ARGS) name = text_to_cstring((text *) DatumGetPointer(PG_GETARG_DATUM(0))); origin = replorigin_by_name(name, false); - replorigin_session_setup(origin); + replorigin_session_setup(origin, 0); replorigin_session_origin = origin; diff --git a/src/backend/replication/logical/proto.c b/src/backend/replication/logical/proto.c index ff8513e..47bd811 100644 --- a/src/backend/replication/logical/proto.c +++ b/src/backend/replication/logical/proto.c @@ -1163,31 +1163,56 @@ logicalrep_read_stream_commit(StringInfo in, LogicalRepCommitData *commit_data) /* * Write STREAM ABORT to the output stream. Note that xid and subxid will be * same for the top-level transaction abort. + * + * If write_abort_lsn is true, send the abort_lsn and abort_time fields, + * otherwise don't. */ void logicalrep_write_stream_abort(StringInfo out, TransactionId xid, - TransactionId subxid) + ReorderBufferTXN *txn, XLogRecPtr abort_lsn, + bool write_abort_lsn) { pq_sendbyte(out, LOGICAL_REP_MSG_STREAM_ABORT); - Assert(TransactionIdIsValid(xid) && TransactionIdIsValid(subxid)); + Assert(TransactionIdIsValid(xid) && TransactionIdIsValid(txn->xid)); /* transaction ID */ pq_sendint32(out, xid); - pq_sendint32(out, subxid); + pq_sendint32(out, txn->xid); + + if (write_abort_lsn) + { + pq_sendint64(out, abort_lsn); + pq_sendint64(out, txn->xact_time.abort_time); + } } /* * Read STREAM ABORT from the output stream. + * + * If read_abort_lsn is true, try to read the abort_lsn and abort_time fields, + * otherwise don't. */ void -logicalrep_read_stream_abort(StringInfo in, TransactionId *xid, - TransactionId *subxid) +logicalrep_read_stream_abort(StringInfo in, + LogicalRepStreamAbortData *abort_data, + bool read_abort_lsn) { - Assert(xid && subxid); + Assert(abort_data); - *xid = pq_getmsgint(in, 4); - *subxid = pq_getmsgint(in, 4); + abort_data->xid = pq_getmsgint(in, 4); + abort_data->subxid = pq_getmsgint(in, 4); + + if (read_abort_lsn) + { + abort_data->abort_lsn = pq_getmsgint64(in); + abort_data->abort_time = pq_getmsgint64(in); + } + else + { + abort_data->abort_lsn = InvalidXLogRecPtr; + abort_data->abort_time = 0; + } } /* diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index 1c21a1d..bca7da0 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -2837,7 +2837,8 @@ ReorderBufferFinishPrepared(ReorderBuffer *rb, TransactionId xid, * disk. */ void -ReorderBufferAbort(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn) +ReorderBufferAbort(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn, + TimestampTz abort_time) { ReorderBufferTXN *txn; @@ -2848,6 +2849,8 @@ ReorderBufferAbort(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn) if (txn == NULL) return; + txn->xact_time.abort_time = abort_time; + /* For streamed transactions notify the remote node about the abort. */ if (rbtxn_is_streamed(txn)) { @@ -2922,7 +2925,8 @@ ReorderBufferAbortOld(ReorderBuffer *rb, TransactionId oldestRunningXid) * to this xid might re-create the transaction incompletely. */ void -ReorderBufferForget(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn) +ReorderBufferForget(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn, + TimestampTz abort_time) { ReorderBufferTXN *txn; @@ -2933,6 +2937,8 @@ ReorderBufferForget(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn) if (txn == NULL) return; + txn->xact_time.abort_time = abort_time; + /* For streamed transactions notify the remote node about the abort. */ if (rbtxn_is_streamed(txn)) rb->stream_abort(rb, txn, lsn); diff --git a/src/backend/replication/logical/tablesync.c b/src/backend/replication/logical/tablesync.c index d37d8a0..6888eee 100644 --- a/src/backend/replication/logical/tablesync.c +++ b/src/backend/replication/logical/tablesync.c @@ -568,7 +568,8 @@ process_syncing_tables_for_apply(XLogRecPtr current_lsn) MySubscription->oid, MySubscription->name, MyLogicalRepWorker->userid, - rstate->relid); + rstate->relid, + DSM_HANDLE_INVALID); hentry->last_start_time = now; } } @@ -589,6 +590,9 @@ process_syncing_tables_for_apply(XLogRecPtr current_lsn) void process_syncing_tables(XLogRecPtr current_lsn) { + if (am_apply_bgworker()) + return; + if (am_tablesync_worker()) process_syncing_tables_for_sync(current_lsn); else @@ -1266,7 +1270,7 @@ LogicalRepSyncTableStart(XLogRecPtr *origin_startpos) * time this tablesync was launched. */ originid = replorigin_by_name(originname, false); - replorigin_session_setup(originid); + replorigin_session_setup(originid, 0); replorigin_session_origin = originid; *origin_startpos = replorigin_session_get_progress(false); @@ -1377,7 +1381,7 @@ LogicalRepSyncTableStart(XLogRecPtr *origin_startpos) true /* go backward */ , true /* WAL log */ ); UnlockRelationOid(ReplicationOriginRelationId, RowExclusiveLock); - replorigin_session_setup(originid); + replorigin_session_setup(originid, 0); replorigin_session_origin = originid; } else diff --git a/src/backend/replication/logical/worker.c b/src/backend/replication/logical/worker.c index 5f8c541..a1a60b0 100644 --- a/src/backend/replication/logical/worker.c +++ b/src/backend/replication/logical/worker.c @@ -22,8 +22,28 @@ * STREAMED TRANSACTIONS * --------------------- * Streamed transactions (large transactions exceeding a memory limit on the - * upstream) are not applied immediately, but instead, the data is written - * to temporary files and then applied at once when the final commit arrives. + * upstream) are applied using one of two approaches: + * + * 1) Separate background workers + * + * If streaming = parallel, we assign a new apply background worker (if + * available) as soon as the xact's first stream is received. The main apply + * worker will send changes to this new worker via shared memory. We keep this + * worker assigned till the transaction commit is received and also wait for + * the worker to finish at commit. This preserves commit ordering and avoids + * file I/O in most cases. We still need to spill to a file if there is no + * worker available. It is important to maintain commit order to avoid failures + * due to (a) transaction dependencies, say if we insert a row in the first + * transaction and update it in the second transaction then allowing to apply + * both in parallel can lead to failure in the update. (b) deadlocks, allowing + * transactions that update the same set of rows/tables in opposite order to be + * applied in parallel can lead to deadlocks. + * + * 2) Write to temporary files and apply when the final commit arrives + * + * If no worker is available to handle the streamed transaction, the data is + * written to temporary files and then applied at once when the final commit + * arrives. * * Unlike the regular (non-streamed) case, handling streamed transactions has * to handle aborts of both the toplevel transaction and subtransactions. This @@ -219,20 +239,8 @@ typedef struct ApplyExecutionData PartitionTupleRouting *proute; /* partition routing info */ } ApplyExecutionData; -/* Struct for saving and restoring apply errcontext information */ -typedef struct ApplyErrorCallbackArg -{ - LogicalRepMsgType command; /* 0 if invalid */ - LogicalRepRelMapEntry *rel; - - /* Remote node information */ - int remote_attnum; /* -1 if invalid */ - TransactionId remote_xid; - XLogRecPtr finish_lsn; - char *origin_name; -} ApplyErrorCallbackArg; - -static ApplyErrorCallbackArg apply_error_callback_arg = +/* errcontext tracker */ +ApplyErrorCallbackArg apply_error_callback_arg = { .command = 0, .rel = NULL, @@ -242,7 +250,9 @@ static ApplyErrorCallbackArg apply_error_callback_arg = .origin_name = NULL, }; -static MemoryContext ApplyMessageContext = NULL; +ErrorContextCallback *apply_error_context_stack = NULL; + +MemoryContext ApplyMessageContext = NULL; MemoryContext ApplyContext = NULL; /* per stream context for streaming transactions */ @@ -251,27 +261,35 @@ static MemoryContext LogicalStreamingContext = NULL; WalReceiverConn *LogRepWorkerWalRcvConn = NULL; Subscription *MySubscription = NULL; -static bool MySubscriptionValid = false; +bool MySubscriptionValid = false; bool in_remote_transaction = false; static XLogRecPtr remote_final_lsn = InvalidXLogRecPtr; /* fields valid only when processing streamed transaction */ -static bool in_streamed_transaction = false; +bool in_streamed_transaction = false; -static TransactionId stream_xid = InvalidTransactionId; +TransactionId stream_xid = InvalidTransactionId; + +/* + * The number of changes sent to apply background workers during one streaming + * block. + */ +static uint32 nchanges = 0; /* * We enable skipping all data modification changes (INSERT, UPDATE, etc.) for * the subscription if the remote transaction's finish LSN matches the subskiplsn. * Once we start skipping changes, we don't stop it until we skip all changes of * the transaction even if pg_subscription is updated and MySubscription->skiplsn - * gets changed or reset during that. Also, in streaming transaction cases, we - * don't skip receiving and spooling the changes since we decide whether or not + * gets changed or reset during that. Also, in streaming transaction cases (streaming = on), + * we don't skip receiving and spooling the changes since we decide whether or not * to skip applying the changes when starting to apply changes. The subskiplsn is * cleared after successfully skipping the transaction or applying non-empty * transaction. The latter prevents the mistakenly specified subskiplsn from - * being left. + * being left. Note that we cannot skip the streaming transactions when using + * apply background workers because we cannot get the finish LSN before + * applying the changes. */ static XLogRecPtr skip_xact_finish_lsn = InvalidXLogRecPtr; #define is_skipping_changes() (unlikely(!XLogRecPtrIsInvalid(skip_xact_finish_lsn))) @@ -324,9 +342,6 @@ static void maybe_reread_subscription(void); static void DisableSubscriptionAndExit(void); -/* prototype needed because of stream_commit */ -static void apply_dispatch(StringInfo s); - static void apply_handle_commit_internal(LogicalRepCommitData *commit_data); static void apply_handle_insert_internal(ApplyExecutionData *edata, ResultRelInfo *relinfo, @@ -359,7 +374,6 @@ static void stop_skipping_changes(void); static void clear_subscription_skip_lsn(XLogRecPtr finish_lsn); /* Functions for apply error callback */ -static void apply_error_callback(void *arg); static inline void set_apply_error_context_xact(TransactionId xid, XLogRecPtr lsn); static inline void reset_apply_error_context_info(void); @@ -375,12 +389,34 @@ static inline void reset_apply_error_context_info(void); * record + 1 (ie start of next record) and next record can be COMMIT of * transaction we are now processing (which is what we set remote_final_lsn * to in apply_handle_begin). + * + * Note that for streaming transactions that are being applied in apply + * background worker, we disallow applying changes on a table that is not in + * the READY state, because we cannot decide whether to apply the change as we + * won't know remote_final_lsn by that time. + * + * We already checked this in apply_bgworker_can_start() before assigning the + * streaming transaction to the background worker, but it also needs to be + * checked here because if the user executes ALTER SUBSCRIPTION ... REFRESH + * PUBLICATION in parallel, the new table can be added to pg_subscription_rel + * in parallel while applying this transaction. */ static bool should_apply_changes_for_rel(LogicalRepRelMapEntry *rel) { if (am_tablesync_worker()) return MyLogicalRepWorker->relid == rel->localreloid; + else if (am_apply_bgworker()) + { + if (rel->state != SUBREL_STATE_READY) + ereport(ERROR, + (errmsg("logical replication apply workers for subscription \"%s\" will restart", + MySubscription->name), + errdetail("Cannot handle streamed replication transaction by apply " + "background workers until all tables are synchronized"))); + + return true; + } else return (rel->state == SUBREL_STATE_READY || (rel->state == SUBREL_STATE_SYNCDONE && @@ -426,43 +462,93 @@ end_replication_step(void) } /* - * Handle streamed transactions. + * Handle streamed transactions for both the main apply worker and the apply + * background workers. + * + * In streaming case (receiving a block of streamed transaction), for + * SUBSTREAM_ON mode, simply redirect it to a file for the proper toplevel + * transaction, and for SUBSTREAM_PARALLEL mode, send the changes to apply + * background workers (LOGICAL_REP_MSG_RELATION or LOGICAL_REP_MSG_TYPE changes + * will be applied by both main and apply background workers). * - * If in streaming mode (receiving a block of streamed transaction), we - * simply redirect it to a file for the proper toplevel transaction. + * For non-streamed transactions, returns false; + * For streamed transactions, returns true if in main apply worker, false + * otherwise. * - * Returns true for streamed transactions, false otherwise (regular mode). + * Exception: When the main apply worker is applying streaming transactions in + * parallel mode (e.g. when addressing LOGICAL_REP_MSG_RELATION or + * LOGICAL_REP_MSG_TYPE changes), then return false. */ static bool handle_streamed_transaction(LogicalRepMsgType action, StringInfo s) { - TransactionId xid; + TransactionId current_xid = InvalidTransactionId; + ApplyBgworkerInfo *winfo; /* not in streaming mode */ - if (!in_streamed_transaction) + if (!in_streamed_transaction && + stream_apply_worker == NULL && !am_apply_bgworker()) return false; - Assert(stream_fd != NULL); Assert(TransactionIdIsValid(stream_xid)); /* * We should have received XID of the subxact as the first part of the * message, so extract it. */ - xid = pq_getmsgint(s, 4); + current_xid = pq_getmsgint(s, 4); - if (!TransactionIdIsValid(xid)) + if (!TransactionIdIsValid(current_xid)) ereport(ERROR, (errcode(ERRCODE_PROTOCOL_VIOLATION), errmsg_internal("invalid transaction ID in streamed replication transaction"))); - /* Add the new subxact to the array (unless already there). */ - subxact_info_add(xid); + if (am_apply_bgworker()) + { + /* Define a savepoint for a subxact if needed. */ + apply_bgworker_subxact_info_add(current_xid); + + return false; + } + + /* + * Check if we are processing this transaction using an apply + * background worker and if so, send the changes to that worker. + */ + else if ((winfo = apply_bgworker_find(stream_xid))) + { + apply_bgworker_send_data(winfo, s->len, s->data); + nchanges += 1; + + /* + * XXX The publisher side doesn't always send relation/type update + * messages after the streaming transaction, so also update the + * relation/type in main apply worker here. See function + * cleanup_rel_sync_cache. + */ + if (action == LOGICAL_REP_MSG_RELATION || + action == LOGICAL_REP_MSG_TYPE) + return false; - /* write the change to the current file */ - stream_write_change(action, s); + return true; + } + else + { + Assert(stream_fd != NULL); - return true; + /* + * This is the main apply worker, but there is no apply background worker, + * so write to temporary files and apply when the final commit arrives. + * + * Add the new subxact to the array (unless already there). + */ + subxact_info_add(current_xid); + + /* write the change to the current file */ + stream_write_change(action, s); + + return true; + } } /* @@ -898,8 +984,11 @@ apply_handle_prepare_internal(LogicalRepPreparedTxnData *prepare_data) * BeginTransactionBlock is necessary to balance the EndTransactionBlock * called within the PrepareTransactionBlock below. */ - BeginTransactionBlock(); - CommitTransactionCommand(); /* Completes the preceding Begin command. */ + if (!IsTransactionBlock()) + { + BeginTransactionBlock(); + CommitTransactionCommand(); /* Completes the preceding Begin command. */ + } /* * Update origin state so we can restart streaming from correct position @@ -1064,15 +1153,12 @@ apply_handle_rollback_prepared(StringInfo s) /* * Handle STREAM PREPARE. - * - * Logic is in two parts: - * 1. Replay all the spooled operations - * 2. Mark the transaction as prepared */ static void apply_handle_stream_prepare(StringInfo s) { LogicalRepPreparedTxnData prepare_data; + ApplyBgworkerInfo *winfo; if (in_streamed_transaction) ereport(ERROR, @@ -1088,24 +1174,64 @@ apply_handle_stream_prepare(StringInfo s) logicalrep_read_stream_prepare(s, &prepare_data); set_apply_error_context_xact(prepare_data.xid, prepare_data.prepare_lsn); - elog(DEBUG1, "received prepare for streamed transaction %u", prepare_data.xid); + if (am_apply_bgworker()) + { + /* Mark the transaction as prepared. */ + apply_handle_prepare_internal(&prepare_data); - /* Replay all the spooled operations. */ - apply_spooled_messages(prepare_data.xid, prepare_data.prepare_lsn); + CommitTransactionCommand(); - /* Mark the transaction as prepared. */ - apply_handle_prepare_internal(&prepare_data); + list_free(subxactlist); + subxactlist = NIL; - CommitTransactionCommand(); + apply_bgworker_set_state(APPLY_BGWORKER_FINISHED); + } - pgstat_report_stat(false); + /* + * Check if we are processing this transaction using an apply + * background worker and if so, send the changes to that worker. + */ + else if ((winfo = apply_bgworker_find(prepare_data.xid))) + { + elog(DEBUG1, "received prepare for streamed transaction %u", + prepare_data.xid); - store_flush_position(prepare_data.end_lsn); + /* Send STREAM PREPARE message to the apply background worker. */ + apply_bgworker_send_data(winfo, s->len, s->data); - in_remote_transaction = false; + /* + * After sending the data to the apply background worker, wait for + * that worker to finish. This is necessary to maintain commit + * order which avoids failures due to transaction dependencies and + * deadlocks. + */ + apply_bgworker_wait_for(winfo, APPLY_BGWORKER_FINISHED); + apply_bgworker_free(winfo); + + store_flush_position(prepare_data.end_lsn); + } + else + { + /* + * The transaction has been serialized to file, so replay all the + * spooled operations. + */ + apply_spooled_messages(prepare_data.xid, prepare_data.prepare_lsn); - /* unlink the files with serialized changes and subxact info. */ - stream_cleanup_files(MyLogicalRepWorker->subid, prepare_data.xid); + /* Mark the transaction as prepared. */ + apply_handle_prepare_internal(&prepare_data); + + CommitTransactionCommand(); + + store_flush_position(prepare_data.end_lsn); + + /* Unlink the files with serialized changes and subxact info. */ + stream_cleanup_files(MyLogicalRepWorker->subid, prepare_data.xid); + } + + pgstat_report_stat(false); + + in_remote_transaction = false; /* Process any tables that are being synchronized in parallel. */ process_syncing_tables(prepare_data.end_lsn); @@ -1134,7 +1260,7 @@ apply_handle_origin(StringInfo s) * ORIGIN message can only come inside streaming transaction or inside * remote transaction and before any actual writes. */ - if (!in_streamed_transaction && + if (!in_streamed_transaction && stream_apply_worker == NULL && (!in_remote_transaction || (IsTransactionState() && !am_tablesync_worker()))) ereport(ERROR, @@ -1155,18 +1281,6 @@ apply_handle_stream_start(StringInfo s) (errcode(ERRCODE_PROTOCOL_VIOLATION), errmsg_internal("duplicate STREAM START message"))); - /* - * Start a transaction on stream start, this transaction will be committed - * on the stream stop unless it is a tablesync worker in which case it - * will be committed after processing all the messages. We need the - * transaction for handling the buffile, used for serializing the - * streaming data and subxact info. - */ - begin_replication_step(); - - /* notify handle methods we're processing a remote transaction */ - in_streamed_transaction = true; - /* extract XID of the top-level transaction */ stream_xid = logicalrep_read_stream_start(s, &first_segment); @@ -1177,36 +1291,94 @@ apply_handle_stream_start(StringInfo s) set_apply_error_context_xact(stream_xid, InvalidXLogRecPtr); - /* - * Initialize the worker's stream_fileset if we haven't yet. This will be - * used for the entire duration of the worker so create it in a permanent - * context. We create this on the very first streaming message from any - * transaction and then use it for this and other streaming transactions. - * Now, we could create a fileset at the start of the worker as well but - * then we won't be sure that it will ever be used. - */ - if (MyLogicalRepWorker->stream_fileset == NULL) + if (am_apply_bgworker()) { - MemoryContext oldctx; + /* + * Make sure the handle apply_dispatch methods are aware we're in a + * remote transaction. + */ + in_remote_transaction = true; + } + else + { + ApplyBgworkerInfo *winfo; - oldctx = MemoryContextSwitchTo(ApplyContext); + /* + * This is the main apply worker. Check if there is any free apply + * background worker we can use to process this transaction. + */ + if (first_segment) + winfo = apply_bgworker_start(stream_xid); + else + winfo = apply_bgworker_find(stream_xid); - MyLogicalRepWorker->stream_fileset = palloc(sizeof(FileSet)); - FileSetInit(MyLogicalRepWorker->stream_fileset); + if (winfo) + { + /* + * If we have found a free worker or if we are already applying + * this transaction using an apply background worker, then we pass + * the data to that worker. + */ + if (first_segment) + apply_bgworker_send_data(winfo, s->len, s->data); - MemoryContextSwitchTo(oldctx); - } + nchanges = 0; + elog(DEBUG1, "starting streaming of xid %u", stream_xid); + + /* Cache the apply background worker for this transaction. */ + stream_apply_worker = winfo; + } + else + { - /* open the spool file for this transaction */ - stream_open_file(MyLogicalRepWorker->subid, stream_xid, first_segment); + /* notify handle methods we're processing a remote transaction */ + in_streamed_transaction = true; - /* if this is not the first segment, open existing subxact file */ - if (!first_segment) - subxact_info_read(MyLogicalRepWorker->subid, stream_xid); + /* + * Since no apply background worker is available for the first + * stream start, serialize all the changes of the transaction. + * + * Start a transaction on stream start, this transaction will be + * committed on the stream stop unless it is a tablesync worker in + * which case it will be committed after processing all the + * messages. We need the transaction for handling the buffile, + * used for serializing the streaming data and subxact info. + */ + begin_replication_step(); - pgstat_report_activity(STATE_RUNNING, NULL); + /* + * Initialize the worker's stream_fileset if we haven't yet. This will + * be used for the entire duration of the worker so create it in a + * permanent context. We create this on the very first streaming + * message from any transaction and then use it for this and other + * streaming transactions. Now, we could create a fileset at the start + * of the worker as well but then we won't be sure that it will ever + * be used. + */ + if (MyLogicalRepWorker->stream_fileset == NULL) + { + MemoryContext oldctx; - end_replication_step(); + oldctx = MemoryContextSwitchTo(ApplyContext); + + MyLogicalRepWorker->stream_fileset = palloc(sizeof(FileSet)); + FileSetInit(MyLogicalRepWorker->stream_fileset); + + MemoryContextSwitchTo(oldctx); + } + + /* Open the spool file for this transaction. */ + stream_open_file(MyLogicalRepWorker->subid, stream_xid, first_segment); + + /* If this is not the first segment, open existing subxact file. */ + if (!first_segment) + subxact_info_read(MyLogicalRepWorker->subid, stream_xid); + + end_replication_step(); + } + } + + pgstat_report_activity(STATE_RUNNING, NULL); } /* @@ -1215,58 +1387,73 @@ apply_handle_stream_start(StringInfo s) static void apply_handle_stream_stop(StringInfo s) { - if (!in_streamed_transaction) - ereport(ERROR, - (errcode(ERRCODE_PROTOCOL_VIOLATION), - errmsg_internal("STREAM STOP message without STREAM START"))); + ApplyBgworkerInfo *winfo; + + if (am_apply_bgworker()) + { + elog(DEBUG1, "[Apply BGW #%u] ended processing streaming chunk, " + "waiting on shm_mq_receive", MyParallelShared->worker_id); + + pgstat_report_activity(STATE_IDLEINTRANSACTION, NULL); + } /* - * Close the file with serialized changes, and serialize information about - * subxacts for the toplevel transaction. + * Check if we are processing this transaction using an apply + * background worker and if so, send the changes to that worker. */ - subxact_info_write(MyLogicalRepWorker->subid, stream_xid); - stream_close_file(); + else if ((winfo = apply_bgworker_find(stream_xid))) + { + apply_bgworker_send_data(winfo, s->len, s->data); - /* We must be in a valid transaction state */ - Assert(IsTransactionState()); + elog(DEBUG1, "stopped streaming of xid %u, %u changes streamed", stream_xid, nchanges); - /* Commit the per-stream transaction */ - CommitTransactionCommand(); + stream_apply_worker = NULL; - in_streamed_transaction = false; + pgstat_report_activity(STATE_IDLE, NULL); + } + else + { + if (!in_streamed_transaction) + ereport(ERROR, + (errcode(ERRCODE_PROTOCOL_VIOLATION), + errmsg_internal("STREAM STOP message without STREAM START"))); + + /* + * Close the file with serialized changes, and serialize information + * about subxacts for the toplevel transaction. + */ + subxact_info_write(MyLogicalRepWorker->subid, stream_xid); + stream_close_file(); - /* Reset per-stream context */ - MemoryContextReset(LogicalStreamingContext); + /* We must be in a valid transaction state */ + Assert(IsTransactionState()); + + /* Commit the per-stream transaction */ + CommitTransactionCommand(); + + /* Reset per-stream context */ + MemoryContextReset(LogicalStreamingContext); + + pgstat_report_activity(STATE_IDLE, NULL); + } + + in_streamed_transaction = false; - pgstat_report_activity(STATE_IDLE, NULL); reset_apply_error_context_info(); } /* - * Handle STREAM abort message. + * Handle STREAM ABORT message when the transaction was spilled to disk. */ static void -apply_handle_stream_abort(StringInfo s) +serialize_stream_abort(TransactionId xid, TransactionId subxid) { - TransactionId xid; - TransactionId subxid; - - if (in_streamed_transaction) - ereport(ERROR, - (errcode(ERRCODE_PROTOCOL_VIOLATION), - errmsg_internal("STREAM ABORT message without STREAM STOP"))); - - logicalrep_read_stream_abort(s, &xid, &subxid); - /* * If the two XIDs are the same, it's in fact abort of toplevel xact, so * just delete the files with serialized info. */ if (xid == subxid) - { - set_apply_error_context_xact(xid, InvalidXLogRecPtr); stream_cleanup_files(MyLogicalRepWorker->subid, xid); - } else { /* @@ -1290,8 +1477,6 @@ apply_handle_stream_abort(StringInfo s) bool found = false; char path[MAXPGPATH]; - set_apply_error_context_xact(subxid, InvalidXLogRecPtr); - subidx = -1; begin_replication_step(); subxact_info_read(MyLogicalRepWorker->subid, xid); @@ -1316,7 +1501,6 @@ apply_handle_stream_abort(StringInfo s) cleanup_subxact_info(); end_replication_step(); CommitTransactionCommand(); - reset_apply_error_context_info(); return; } @@ -1339,6 +1523,153 @@ apply_handle_stream_abort(StringInfo s) end_replication_step(); CommitTransactionCommand(); } +} + +/* + * Handle STREAM ABORT message when the transaction was applied in a apply + * background worker. + */ +static void +apply_stream_abort_in_bgworker(LogicalRepStreamAbortData *abort_data, + bool read_abort_lsn) +{ + TransactionId xid = abort_data->xid; + TransactionId subxid = abort_data->subxid; + + elog(DEBUG1, "[Apply BGW #%u] aborting current transaction xid=%u, subxid=%u", + MyParallelShared->worker_id , GetCurrentTransactionIdIfAny(), + GetCurrentSubTransactionId()); + + /* + * Update origin state so we can restart streaming from correct + * position in case of crash. + */ + if (read_abort_lsn) + { + replorigin_session_origin_lsn = abort_data->abort_lsn; + replorigin_session_origin_timestamp = abort_data->abort_time; + } + + /* + * If the two XIDs are the same, it's in fact abort of toplevel xact, + * so just free the subxactlist. + */ + if (subxid == xid) + { + AbortCurrentTransaction(); + + if (IsTransactionBlock()) + { + EndTransactionBlock(false); + CommitTransactionCommand(); + } + + in_remote_transaction = false; + pgstat_report_activity(STATE_IDLE, NULL); + + list_free(subxactlist); + subxactlist = NIL; + + apply_bgworker_set_state(APPLY_BGWORKER_FINISHED); + } + else + { + /* + * OK, so it's a subxact. Rollback to the savepoint. + * + * We also need to read the subxactlist, determine the offset + * tracked for the subxact, and truncate the list. + */ + int i; + bool found = false; + char spname[MAXPGPATH]; + + apply_bgworker_savepoint_name(MySubscription->oid, subxid, spname, + sizeof(spname)); + + elog(DEBUG1, "[Apply BGW #%u] rolling back to savepoint %s", + MyParallelShared->worker_id, spname); + + for (i = list_length(subxactlist) - 1; i >= 0; i--) + { + xid = (TransactionId) list_nth_int(subxactlist, i); + if (xid == subxid) + { + found = true; + break; + } + } + + if (found) + { + RollbackToSavepoint(spname); + CommitTransactionCommand(); + subxactlist = list_truncate(subxactlist, i + 1); + } + + pgstat_report_activity(STATE_IDLEINTRANSACTION, NULL); + } +} + +/* + * Handle STREAM ABORT message. + */ +static void +apply_handle_stream_abort(StringInfo s) +{ + TransactionId xid; + TransactionId subxid; + LogicalRepStreamAbortData abort_data; + bool read_abort_lsn = false; + ApplyBgworkerInfo *winfo; + + if (in_streamed_transaction) + ereport(ERROR, + (errcode(ERRCODE_PROTOCOL_VIOLATION), + errmsg_internal("STREAM ABORT message without STREAM STOP"))); + + /* Check whether the publisher sends abort_lsn and abort_time. */ + if (am_apply_bgworker()) + read_abort_lsn = MyParallelShared->proto_version >= + LOGICALREP_PROTO_STREAM_PARALLEL_VERSION_NUM; + + logicalrep_read_stream_abort(s, &abort_data, read_abort_lsn); + + xid = abort_data.xid; + subxid = abort_data.subxid; + + set_apply_error_context_xact(subxid, abort_data.abort_lsn); + + if (am_apply_bgworker()) + apply_stream_abort_in_bgworker(&abort_data, read_abort_lsn); + + /* + * Check if we are processing this transaction using an apply + * background worker and if so, send the changes to that worker. + */ + else if ((winfo = apply_bgworker_find(xid))) + { + /* Send STREAM ABORT message to the apply background worker. */ + apply_bgworker_send_data(winfo, s->len, s->data); + + /* + * After sending the data to the apply background worker, wait for + * that worker to finish. This is necessary to maintain commit + * order which avoids failures due to transaction dependencies and + * deadlocks. + */ + if (subxid == xid) + { + apply_bgworker_wait_for(winfo, APPLY_BGWORKER_FINISHED); + apply_bgworker_free(winfo); + } + } + else + /* + * We are in main apply worker and the transaction has been + * serialized to file. + */ + serialize_stream_abort(xid, subxid); reset_apply_error_context_info(); } @@ -1470,6 +1801,7 @@ apply_handle_stream_commit(StringInfo s) { TransactionId xid; LogicalRepCommitData commit_data; + ApplyBgworkerInfo *winfo; if (in_streamed_transaction) ereport(ERROR, @@ -1479,14 +1811,60 @@ apply_handle_stream_commit(StringInfo s) xid = logicalrep_read_stream_commit(s, &commit_data); set_apply_error_context_xact(xid, commit_data.commit_lsn); - elog(DEBUG1, "received commit for streamed transaction %u", xid); + if (am_apply_bgworker()) + { + apply_handle_commit_internal(&commit_data); - apply_spooled_messages(xid, commit_data.commit_lsn); + list_free(subxactlist); + subxactlist = NIL; - apply_handle_commit_internal(&commit_data); + apply_bgworker_set_state(APPLY_BGWORKER_FINISHED); + } + + /* + * Check if we are processing this transaction using an apply + * background worker and if so, send the changes to that worker. + */ + else if ((winfo = apply_bgworker_find(xid))) + { + elog(DEBUG1, "received commit for streamed transaction %u", xid); - /* unlink the files with serialized changes and subxact info */ - stream_cleanup_files(MyLogicalRepWorker->subid, xid); + /* Send STREAM COMMIT message to the apply background worker. */ + apply_bgworker_send_data(winfo, s->len, s->data); + + /* + * After sending the data to the apply background worker, wait for + * that worker to finish. This is necessary to maintain commit + * order which avoids failures due to transaction dependencies and + * deadlocks. + */ + apply_bgworker_wait_for(winfo, APPLY_BGWORKER_FINISHED); + + pgstat_report_stat(false); + store_flush_position(commit_data.end_lsn); + stop_skipping_changes(); + + apply_bgworker_free(winfo); + + /* + * The transaction is either non-empty or skipped, so we clear the + * subskiplsn. + */ + clear_subscription_skip_lsn(commit_data.commit_lsn); + } + else + { + /* + * The transaction has been serialized to file, so replay all the + * spooled operations. + */ + apply_spooled_messages(xid, commit_data.commit_lsn); + + apply_handle_commit_internal(&commit_data); + + /* Unlink the files with serialized changes and subxact info. */ + stream_cleanup_files(MyLogicalRepWorker->subid, xid); + } /* Process any tables that are being synchronized in parallel. */ process_syncing_tables(commit_data.end_lsn); @@ -1530,6 +1908,13 @@ apply_handle_commit_internal(LogicalRepCommitData *commit_data) replorigin_session_origin_timestamp = commit_data->committime; CommitTransactionCommand(); + + if (IsTransactionBlock()) + { + EndTransactionBlock(false); + CommitTransactionCommand(); + } + pgstat_report_stat(false); store_flush_position(commit_data->end_lsn); @@ -2467,7 +2852,7 @@ apply_handle_truncate(StringInfo s) /* * Logical replication protocol message dispatcher. */ -static void +void apply_dispatch(StringInfo s) { LogicalRepMsgType action = pq_getmsgbyte(s); @@ -2636,6 +3021,10 @@ store_flush_position(XLogRecPtr remote_lsn) { FlushPosition *flushpos; + /* Skip if not the main apply worker */ + if (am_apply_bgworker()) + return; + /* Need to do this in permanent context */ MemoryContextSwitchTo(ApplyContext); @@ -2650,7 +3039,7 @@ store_flush_position(XLogRecPtr remote_lsn) /* Update statistics of the worker. */ -static void +void UpdateWorkerStats(XLogRecPtr last_lsn, TimestampTz send_time, bool reply) { MyLogicalRepWorker->last_lsn = last_lsn; @@ -2700,6 +3089,7 @@ LogicalRepApplyLoop(XLogRecPtr last_received) errcallback.callback = apply_error_callback; errcallback.previous = error_context_stack; error_context_stack = &errcallback; + apply_error_context_stack = error_context_stack; /* This outer loop iterates once per wait. */ for (;;) @@ -2914,6 +3304,7 @@ LogicalRepApplyLoop(XLogRecPtr last_received) /* Pop the error context stack */ error_context_stack = errcallback.previous; + apply_error_context_stack = error_context_stack; /* All done */ walrcv_endstreaming(LogRepWorkerWalRcvConn, &tli); @@ -3114,7 +3505,7 @@ maybe_reread_subscription(void) /* * Callback from subscription syscache invalidation. */ -static void +void subscription_change_cb(Datum arg, int cacheid, uint32 hashvalue) { MySubscriptionValid = false; @@ -3569,37 +3960,14 @@ start_apply(XLogRecPtr origin_startpos) PG_END_TRY(); } -/* Logical Replication Apply worker entry point */ +/* + * Initialize the database connection, in-memory subscription and necessary + * config options. + */ void -ApplyWorkerMain(Datum main_arg) +InitializeApplyWorker(void) { - int worker_slot = DatumGetInt32(main_arg); MemoryContext oldctx; - char originname[NAMEDATALEN]; - XLogRecPtr origin_startpos = InvalidXLogRecPtr; - char *myslotname = NULL; - WalRcvStreamOptions options; - int server_version; - - /* Attach to slot */ - logicalrep_worker_attach(worker_slot); - - /* Setup signal handling */ - pqsignal(SIGHUP, SignalHandlerForConfigReload); - pqsignal(SIGTERM, die); - BackgroundWorkerUnblockSignals(); - - /* - * We don't currently need any ResourceOwner in a walreceiver process, but - * if we did, we could call CreateAuxProcessResourceOwner here. - */ - - /* Initialise stats to a sanish value */ - MyLogicalRepWorker->last_send_time = MyLogicalRepWorker->last_recv_time = - MyLogicalRepWorker->reply_time = GetCurrentTimestamp(); - - /* Load the libpq-specific functions */ - load_file("libpqwalreceiver", false); /* Run as replica session replication role. */ SetConfigOption("session_replication_role", "replica", @@ -3659,12 +4027,50 @@ ApplyWorkerMain(Datum main_arg) ereport(LOG, (errmsg("logical replication table synchronization worker for subscription \"%s\", table \"%s\" has started", MySubscription->name, get_rel_name(MyLogicalRepWorker->relid)))); + else if (am_apply_bgworker()) + ereport(LOG, + (errmsg("logical replication apply background worker for subscription \"%s\" has started", + MySubscription->name))); else ereport(LOG, (errmsg("logical replication apply worker for subscription \"%s\" has started", MySubscription->name))); CommitTransactionCommand(); +} + +/* Logical Replication Apply worker entry point */ +void +ApplyWorkerMain(Datum main_arg) +{ + int worker_slot = DatumGetInt32(main_arg); + char originname[NAMEDATALEN]; + XLogRecPtr origin_startpos = InvalidXLogRecPtr; + char *myslotname = NULL; + WalRcvStreamOptions options; + int server_version; + + /* Attach to slot */ + logicalrep_worker_attach(worker_slot); + + /* Setup signal handling */ + pqsignal(SIGHUP, SignalHandlerForConfigReload); + pqsignal(SIGTERM, die); + BackgroundWorkerUnblockSignals(); + + /* + * We don't currently need any ResourceOwner in a walreceiver process, but + * if we did, we could call CreateAuxProcessResourceOwner here. + */ + + /* Initialise stats to a sanish value */ + MyLogicalRepWorker->last_send_time = MyLogicalRepWorker->last_recv_time = + MyLogicalRepWorker->reply_time = GetCurrentTimestamp(); + + /* Load the libpq-specific functions */ + load_file("libpqwalreceiver", false); + + InitializeApplyWorker(); /* Connect to the origin and start the replication. */ elog(DEBUG1, "connecting to publisher using connection string \"%s\"", @@ -3710,7 +4116,7 @@ ApplyWorkerMain(Datum main_arg) originid = replorigin_by_name(originname, true); if (!OidIsValid(originid)) originid = replorigin_create(originname); - replorigin_session_setup(originid); + replorigin_session_setup(originid, 0); replorigin_session_origin = originid; origin_startpos = replorigin_session_get_progress(false); CommitTransactionCommand(); @@ -3751,13 +4157,14 @@ ApplyWorkerMain(Datum main_arg) server_version = walrcv_server_version(LogRepWorkerWalRcvConn); options.proto.logical.proto_version = + server_version >= 160000 ? LOGICALREP_PROTO_STREAM_PARALLEL_VERSION_NUM : server_version >= 150000 ? LOGICALREP_PROTO_TWOPHASE_VERSION_NUM : server_version >= 140000 ? LOGICALREP_PROTO_STREAM_VERSION_NUM : LOGICALREP_PROTO_VERSION_NUM; options.proto.logical.publication_names = MySubscription->publications; options.proto.logical.binary = MySubscription->binary; - options.proto.logical.streaming = MySubscription->stream; + options.proto.logical.streaming = (MySubscription->stream != SUBSTREAM_OFF); options.proto.logical.twophase = false; options.proto.logical.origin = pstrdup(MySubscription->origin); @@ -3916,7 +4323,8 @@ clear_subscription_skip_lsn(XLogRecPtr finish_lsn) XLogRecPtr myskiplsn = MySubscription->skiplsn; bool started_tx = false; - if (likely(XLogRecPtrIsInvalid(myskiplsn))) + if (likely(XLogRecPtrIsInvalid(myskiplsn)) || + am_apply_bgworker()) return; if (!IsTransactionState()) @@ -3988,7 +4396,7 @@ clear_subscription_skip_lsn(XLogRecPtr finish_lsn) } /* Error callback to give more context info about the change being applied */ -static void +void apply_error_callback(void *arg) { ApplyErrorCallbackArg *errarg = &apply_error_callback_arg; @@ -4016,23 +4424,47 @@ apply_error_callback(void *arg) errarg->remote_xid, LSN_FORMAT_ARGS(errarg->finish_lsn)); } - else if (errarg->remote_attnum < 0) - errcontext("processing remote data for replication origin \"%s\" during \"%s\" for replication target relation \"%s.%s\" in transaction %u finished at %X/%X", - errarg->origin_name, - logicalrep_message_type(errarg->command), - errarg->rel->remoterel.nspname, - errarg->rel->remoterel.relname, - errarg->remote_xid, - LSN_FORMAT_ARGS(errarg->finish_lsn)); else - errcontext("processing remote data for replication origin \"%s\" during \"%s\" for replication target relation \"%s.%s\" column \"%s\" in transaction %u finished at %X/%X", - errarg->origin_name, - logicalrep_message_type(errarg->command), - errarg->rel->remoterel.nspname, - errarg->rel->remoterel.relname, - errarg->rel->remoterel.attnames[errarg->remote_attnum], - errarg->remote_xid, - LSN_FORMAT_ARGS(errarg->finish_lsn)); + { + if (errarg->remote_attnum < 0) + { + if (XLogRecPtrIsInvalid(errarg->finish_lsn)) + errcontext("processing remote data for replication origin \"%s\" during \"%s\" for replication target relation \"%s.%s\" in transaction %u", + errarg->origin_name, + logicalrep_message_type(errarg->command), + errarg->rel->remoterel.nspname, + errarg->rel->remoterel.relname, + errarg->remote_xid); + else + errcontext("processing remote data for replication origin \"%s\" during \"%s\" for replication target relation \"%s.%s\" in transaction %u finished at %X/%X", + errarg->origin_name, + logicalrep_message_type(errarg->command), + errarg->rel->remoterel.nspname, + errarg->rel->remoterel.relname, + errarg->remote_xid, + LSN_FORMAT_ARGS(errarg->finish_lsn)); + } + else + { + if (XLogRecPtrIsInvalid(errarg->finish_lsn)) + errcontext("processing remote data for replication origin \"%s\" during \"%s\" for replication target relation \"%s.%s\" column \"%s\" in transaction %u", + errarg->origin_name, + logicalrep_message_type(errarg->command), + errarg->rel->remoterel.nspname, + errarg->rel->remoterel.relname, + errarg->rel->remoterel.attnames[errarg->remote_attnum], + errarg->remote_xid); + else + errcontext("processing remote data for replication origin \"%s\" during \"%s\" for replication target relation \"%s.%s\" column \"%s\" in transaction %u finished at %X/%X", + errarg->origin_name, + logicalrep_message_type(errarg->command), + errarg->rel->remoterel.nspname, + errarg->rel->remoterel.relname, + errarg->rel->remoterel.attnames[errarg->remote_attnum], + errarg->remote_xid, + LSN_FORMAT_ARGS(errarg->finish_lsn)); + } + } } /* Set transaction information of apply error callback */ diff --git a/src/backend/replication/pgoutput/pgoutput.c b/src/backend/replication/pgoutput/pgoutput.c index 62e0ffe..d3f19b8 100644 --- a/src/backend/replication/pgoutput/pgoutput.c +++ b/src/backend/replication/pgoutput/pgoutput.c @@ -1843,6 +1843,9 @@ pgoutput_stream_abort(struct LogicalDecodingContext *ctx, XLogRecPtr abort_lsn) { ReorderBufferTXN *toptxn; + PGOutputData *data = (PGOutputData *) ctx->output_plugin_private; + bool write_abort_lsn = (data->protocol_version >= + LOGICALREP_PROTO_STREAM_PARALLEL_VERSION_NUM); /* * The abort should happen outside streaming block, even for streamed @@ -1856,7 +1859,8 @@ pgoutput_stream_abort(struct LogicalDecodingContext *ctx, Assert(rbtxn_is_streamed(toptxn)); OutputPluginPrepareWrite(ctx, true); - logicalrep_write_stream_abort(ctx->out, toptxn->xid, txn->xid); + logicalrep_write_stream_abort(ctx->out, toptxn->xid, txn, abort_lsn, + write_abort_lsn); OutputPluginWrite(ctx, true); cleanup_rel_sync_cache(toptxn->xid, false); diff --git a/src/backend/storage/ipc/procsignal.c b/src/backend/storage/ipc/procsignal.c index 21a9fc0..98a9163 100644 --- a/src/backend/storage/ipc/procsignal.c +++ b/src/backend/storage/ipc/procsignal.c @@ -22,6 +22,7 @@ #include "commands/async.h" #include "miscadmin.h" #include "pgstat.h" +#include "replication/logicalworker.h" #include "replication/walsender.h" #include "storage/condition_variable.h" #include "storage/ipc.h" @@ -657,6 +658,9 @@ procsignal_sigusr1_handler(SIGNAL_ARGS) if (CheckProcSignal(PROCSIG_LOG_MEMORY_CONTEXT)) HandleLogMemoryContextInterrupt(); + if (CheckProcSignal(PROCSIG_APPLY_BGWORKER_MESSAGE)) + HandleApplyBgworkerMessageInterrupt(); + if (CheckProcSignal(PROCSIG_RECOVERY_CONFLICT_DATABASE)) RecoveryConflictInterrupt(PROCSIG_RECOVERY_CONFLICT_DATABASE); diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index 7bec4e4..7edb3d1 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -3377,6 +3377,9 @@ ProcessInterrupts(void) if (LogMemoryContextPending) ProcessLogMemoryContextInterrupt(); + + if (ApplyBgworkerMessagePending) + HandleApplyBgworkerMessages(); } /* diff --git a/src/backend/utils/activity/wait_event.c b/src/backend/utils/activity/wait_event.c index 92f24a6..7b66766 100644 --- a/src/backend/utils/activity/wait_event.c +++ b/src/backend/utils/activity/wait_event.c @@ -388,6 +388,9 @@ pgstat_get_wait_ipc(WaitEventIPC w) case WAIT_EVENT_HASH_GROW_BUCKETS_REINSERT: event_name = "HashGrowBucketsReinsert"; break; + case WAIT_EVENT_LOGICAL_APPLY_BGWORKER_STATE_CHANGE: + event_name = "LogicalApplyBgworkerStateChange"; + break; case WAIT_EVENT_LOGICAL_SYNC_DATA: event_name = "LogicalSyncData"; break; diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 9fbbfb1..816b102 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -3223,6 +3223,18 @@ static struct config_int ConfigureNamesInt[] = }, { + {"max_apply_bgworkers_per_subscription", + PGC_SIGHUP, + REPLICATION_SUBSCRIBERS, + gettext_noop("Maximum number of apply background workers per subscription."), + NULL, + }, + &max_apply_bgworkers_per_subscription, + 2, 0, MAX_BACKENDS, + NULL, NULL, NULL + }, + + { {"log_rotation_age", PGC_SIGHUP, LOGGING_WHERE, gettext_noop("Sets the amount of time to wait before forcing " "log file rotation."), diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample index 90bec05..734d07b 100644 --- a/src/backend/utils/misc/postgresql.conf.sample +++ b/src/backend/utils/misc/postgresql.conf.sample @@ -360,6 +360,7 @@ #max_logical_replication_workers = 4 # taken from max_worker_processes # (change requires restart) #max_sync_workers_per_subscription = 2 # taken from max_logical_replication_workers +#max_apply_bgworkers_per_subscription = 2 # taken from max_logical_replication_workers #------------------------------------------------------------------------------ diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index 2c68915..46a3d01 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -4480,7 +4480,7 @@ getSubscriptions(Archive *fout) if (fout->remoteVersion >= 140000) appendPQExpBufferStr(query, " s.substream,\n"); else - appendPQExpBufferStr(query, " false AS substream,\n"); + appendPQExpBufferStr(query, " 'f' AS substream,\n"); if (fout->remoteVersion >= 150000) appendPQExpBufferStr(query, @@ -4617,8 +4617,10 @@ dumpSubscription(Archive *fout, const SubscriptionInfo *subinfo) if (strcmp(subinfo->subbinary, "t") == 0) appendPQExpBufferStr(query, ", binary = true"); - if (strcmp(subinfo->substream, "f") != 0) + if (strcmp(subinfo->substream, "t") == 0) appendPQExpBufferStr(query, ", streaming = on"); + else if (strcmp(subinfo->substream, "p") == 0) + appendPQExpBufferStr(query, ", streaming = parallel"); if (strcmp(subinfo->subtwophasestate, two_phase_disabled) != 0) appendPQExpBufferStr(query, ", two_phase = on"); diff --git a/src/include/catalog/pg_subscription.h b/src/include/catalog/pg_subscription.h index 7b98714..f4e1e94 100644 --- a/src/include/catalog/pg_subscription.h +++ b/src/include/catalog/pg_subscription.h @@ -80,7 +80,8 @@ CATALOG(pg_subscription,6100,SubscriptionRelationId) BKI_SHARED_RELATION BKI_ROW bool subbinary; /* True if the subscription wants the * publisher to send data in binary */ - bool substream; /* Stream in-progress transactions. */ + char substream; /* Stream in-progress transactions. + * See SUBSTREAM_xxx constants. */ char subtwophasestate; /* Stream two-phase transactions */ @@ -124,7 +125,8 @@ typedef struct Subscription bool enabled; /* Indicates if the subscription is enabled */ bool binary; /* Indicates if the subscription wants data in * binary format */ - bool stream; /* Allow streaming in-progress transactions. */ + char stream; /* Allow streaming in-progress transactions. + * See SUBSTREAM_xxx constants. */ char twophasestate; /* Allow streaming two-phase transactions */ bool disableonerr; /* Indicates if the subscription should be * automatically disabled if a worker error @@ -137,6 +139,21 @@ typedef struct Subscription * specified origin */ } Subscription; +/* Disallow streaming in-progress transactions. */ +#define SUBSTREAM_OFF 'f' + +/* + * Streaming in-progress transactions are written to a temporary file and + * applied only after the transaction is committed on upstream. + */ +#define SUBSTREAM_ON 't' + +/* + * Streaming in-progress transactions are applied immediately via a background + * worker. + */ +#define SUBSTREAM_PARALLEL 'p' + extern Subscription *GetSubscription(Oid subid, bool missing_ok); extern void FreeSubscription(Subscription *sub); extern void DisableSubscription(Oid subid); diff --git a/src/include/replication/logicallauncher.h b/src/include/replication/logicallauncher.h index f1e2821..ac8ef94 100644 --- a/src/include/replication/logicallauncher.h +++ b/src/include/replication/logicallauncher.h @@ -14,6 +14,7 @@ extern PGDLLIMPORT int max_logical_replication_workers; extern PGDLLIMPORT int max_sync_workers_per_subscription; +extern PGDLLIMPORT int max_apply_bgworkers_per_subscription; extern void ApplyLauncherRegister(void); extern void ApplyLauncherMain(Datum main_arg); diff --git a/src/include/replication/logicalproto.h b/src/include/replication/logicalproto.h index a771ab8..eb0fd24 100644 --- a/src/include/replication/logicalproto.h +++ b/src/include/replication/logicalproto.h @@ -32,12 +32,17 @@ * * LOGICALREP_PROTO_TWOPHASE_VERSION_NUM is the minimum protocol version with * support for two-phase commit decoding (at prepare time). Introduced in PG15. + * + * LOGICALREP_PROTO_STREAM_PARALLEL_VERSION_NUM is the minimum protocol version + * with support for streaming large transactions using apply background + * workers. Introduced in PG16. */ #define LOGICALREP_PROTO_MIN_VERSION_NUM 1 #define LOGICALREP_PROTO_VERSION_NUM 1 #define LOGICALREP_PROTO_STREAM_VERSION_NUM 2 #define LOGICALREP_PROTO_TWOPHASE_VERSION_NUM 3 -#define LOGICALREP_PROTO_MAX_VERSION_NUM LOGICALREP_PROTO_TWOPHASE_VERSION_NUM +#define LOGICALREP_PROTO_STREAM_PARALLEL_VERSION_NUM 4 +#define LOGICALREP_PROTO_MAX_VERSION_NUM LOGICALREP_PROTO_STREAM_PARALLEL_VERSION_NUM /* * Logical message types @@ -175,6 +180,17 @@ typedef struct LogicalRepRollbackPreparedTxnData char gid[GIDSIZE]; } LogicalRepRollbackPreparedTxnData; +/* + * Transaction protocol information for stream abort. + */ +typedef struct LogicalRepStreamAbortData +{ + TransactionId xid; + TransactionId subxid; + XLogRecPtr abort_lsn; + TimestampTz abort_time; +} LogicalRepStreamAbortData; + extern void logicalrep_write_begin(StringInfo out, ReorderBufferTXN *txn); extern void logicalrep_read_begin(StringInfo in, LogicalRepBeginData *begin_data); @@ -246,9 +262,12 @@ extern void logicalrep_write_stream_commit(StringInfo out, ReorderBufferTXN *txn extern TransactionId logicalrep_read_stream_commit(StringInfo out, LogicalRepCommitData *commit_data); extern void logicalrep_write_stream_abort(StringInfo out, TransactionId xid, - TransactionId subxid); -extern void logicalrep_read_stream_abort(StringInfo in, TransactionId *xid, - TransactionId *subxid); + ReorderBufferTXN *txn, + XLogRecPtr abort_lsn, + bool write_abort_lsn); +extern void logicalrep_read_stream_abort(StringInfo in, + LogicalRepStreamAbortData *abort_data, + bool read_abort_lsn); extern char *logicalrep_message_type(LogicalRepMsgType action); #endif /* LOGICAL_PROTO_H */ diff --git a/src/include/replication/logicalworker.h b/src/include/replication/logicalworker.h index cd1b6e8..000e23d 100644 --- a/src/include/replication/logicalworker.h +++ b/src/include/replication/logicalworker.h @@ -12,8 +12,13 @@ #ifndef LOGICALWORKER_H #define LOGICALWORKER_H +extern PGDLLIMPORT volatile bool ApplyBgworkerMessagePending; + extern void ApplyWorkerMain(Datum main_arg); +extern void ApplyBgworkerMain(Datum main_arg); extern bool IsLogicalWorker(void); +extern void HandleApplyBgworkerMessageInterrupt(void); +extern void HandleApplyBgworkerMessages(void); #endif /* LOGICALWORKER_H */ diff --git a/src/include/replication/origin.h b/src/include/replication/origin.h index 2d1b5e5..e8ed455 100644 --- a/src/include/replication/origin.h +++ b/src/include/replication/origin.h @@ -53,7 +53,7 @@ extern XLogRecPtr replorigin_get_progress(RepOriginId node, bool flush); extern void replorigin_session_advance(XLogRecPtr remote_commit, XLogRecPtr local_commit); -extern void replorigin_session_setup(RepOriginId node); +extern void replorigin_session_setup(RepOriginId node, int apply_leader_pid); extern void replorigin_session_reset(void); extern XLogRecPtr replorigin_session_get_progress(bool flush); diff --git a/src/include/replication/reorderbuffer.h b/src/include/replication/reorderbuffer.h index 8695901..a74b616 100644 --- a/src/include/replication/reorderbuffer.h +++ b/src/include/replication/reorderbuffer.h @@ -301,6 +301,7 @@ typedef struct ReorderBufferTXN { TimestampTz commit_time; TimestampTz prepare_time; + TimestampTz abort_time; } xact_time; /* @@ -658,9 +659,11 @@ extern void ReorderBufferFinishPrepared(ReorderBuffer *rb, TransactionId xid, extern void ReorderBufferAssignChild(ReorderBuffer *, TransactionId, TransactionId, XLogRecPtr commit_lsn); extern void ReorderBufferCommitChild(ReorderBuffer *, TransactionId, TransactionId, XLogRecPtr commit_lsn, XLogRecPtr end_lsn); -extern void ReorderBufferAbort(ReorderBuffer *, TransactionId, XLogRecPtr lsn); +extern void ReorderBufferAbort(ReorderBuffer *, TransactionId, XLogRecPtr lsn, + TimestampTz abort_time); extern void ReorderBufferAbortOld(ReorderBuffer *, TransactionId xid); -extern void ReorderBufferForget(ReorderBuffer *, TransactionId, XLogRecPtr lsn); +extern void ReorderBufferForget(ReorderBuffer *, TransactionId, XLogRecPtr lsn, + TimestampTz abort_time); extern void ReorderBufferInvalidate(ReorderBuffer *, TransactionId, XLogRecPtr lsn); extern void ReorderBufferSetBaseSnapshot(ReorderBuffer *, TransactionId, XLogRecPtr lsn, struct SnapshotData *snap); diff --git a/src/include/replication/worker_internal.h b/src/include/replication/worker_internal.h index 901845a..4308006 100644 --- a/src/include/replication/worker_internal.h +++ b/src/include/replication/worker_internal.h @@ -17,8 +17,12 @@ #include "access/xlogdefs.h" #include "catalog/pg_subscription.h" #include "datatype/timestamp.h" +#include "miscadmin.h" +#include "replication/logicalrelation.h" #include "storage/fileset.h" #include "storage/lock.h" +#include "storage/shm_mq.h" +#include "storage/shm_toc.h" #include "storage/spin.h" @@ -60,6 +64,12 @@ typedef struct LogicalRepWorker */ FileSet *stream_fileset; + /* + * PID of main apply worker if this slot is used for an apply background + * worker, InvalidPid otherwise. + */ + pid_t apply_leader_pid; + /* Stats. */ XLogRecPtr last_lsn; TimestampTz last_send_time; @@ -68,8 +78,84 @@ typedef struct LogicalRepWorker TimestampTz reply_time; } LogicalRepWorker; +/* Struct for saving and restoring apply errcontext information */ +typedef struct ApplyErrorCallbackArg +{ + LogicalRepMsgType command; /* 0 if invalid */ + LogicalRepRelMapEntry *rel; + + /* Remote node information */ + int remote_attnum; /* -1 if invalid */ + TransactionId remote_xid; + XLogRecPtr finish_lsn; + char *origin_name; +} ApplyErrorCallbackArg; + +/* + * Apply background worker states. + */ +typedef enum ApplyBgworkerState +{ + APPLY_BGWORKER_BUSY, /* assigned to a transaction */ + APPLY_BGWORKER_FINISHED /* transaction is completed */ +} ApplyBgworkerState; + +/* + * Struct for sharing information between apply main and apply background + * workers. + */ +typedef struct ApplyBgworkerShared +{ + slock_t mutex; + + /* State of apply background worker. */ + ApplyBgworkerState state; + + /* Logical protocol version. */ + uint32 proto_version; + + TransactionId stream_xid; + + /* ID of apply background worker */ + uint32 worker_id; + + /* Information from the corresponding LogicalRepWorker slot */ + uint16 logicalrep_worker_generation; + + int logicalrep_worker_slot_no; +} ApplyBgworkerShared; + +/* + * Information which is used to manage the apply background worker. + */ +typedef struct ApplyBgworkerInfo +{ + shm_mq_handle *mq_handle; + + /* + * The queue used to transfer messages from the apply background worker to + * the main apply worker. NULL if the apply background worker exited + * cleanly. + */ + shm_mq_handle *error_mq_handle; + + dsm_segment *dsm_seg; + + ApplyBgworkerShared volatile *shared; +} ApplyBgworkerInfo; + /* Main memory context for apply worker. Permanent during worker lifetime. */ extern PGDLLIMPORT MemoryContext ApplyContext; +extern PGDLLIMPORT MemoryContext ApplyMessageContext; + +extern PGDLLIMPORT ErrorContextCallback *apply_error_context_stack; +extern PGDLLIMPORT ApplyErrorCallbackArg apply_error_callback_arg; + +extern PGDLLIMPORT bool MySubscriptionValid; + +extern PGDLLIMPORT volatile ApplyBgworkerShared *MyParallelShared; + +extern PGDLLIMPORT List *subxactlist; /* libpqreceiver connection */ extern PGDLLIMPORT struct WalReceiverConn *LogRepWorkerWalRcvConn; @@ -79,18 +165,24 @@ extern PGDLLIMPORT Subscription *MySubscription; extern PGDLLIMPORT LogicalRepWorker *MyLogicalRepWorker; extern PGDLLIMPORT bool in_remote_transaction; +extern PGDLLIMPORT bool in_streamed_transaction; +extern PGDLLIMPORT TransactionId stream_xid; +extern PGDLLIMPORT ApplyBgworkerInfo *stream_apply_worker; extern void logicalrep_worker_attach(int slot); extern LogicalRepWorker *logicalrep_worker_find(Oid subid, Oid relid, bool only_running); extern List *logicalrep_workers_find(Oid subid, bool only_running); -extern void logicalrep_worker_launch(Oid dbid, Oid subid, const char *subname, - Oid userid, Oid relid); +extern bool logicalrep_worker_launch(Oid dbid, Oid subid, const char *subname, + Oid userid, Oid relid, + dsm_handle subworker_dsm); extern void logicalrep_worker_stop(Oid subid, Oid relid); +extern void logicalrep_worker_stop_by_slot(int slot_no, uint16 generation); extern void logicalrep_worker_wakeup(Oid subid, Oid relid); extern void logicalrep_worker_wakeup_ptr(LogicalRepWorker *worker); extern int logicalrep_sync_worker_count(Oid subid); +extern int logicalrep_apply_bgworker_count(Oid subid); extern void ReplicationOriginNameForTablesync(Oid suboid, Oid relid, char *originname, int szorgname); @@ -103,10 +195,44 @@ extern void process_syncing_tables(XLogRecPtr current_lsn); extern void invalidate_syncing_table_states(Datum arg, int cacheid, uint32 hashvalue); +extern void UpdateWorkerStats(XLogRecPtr last_lsn, TimestampTz send_time, + bool reply); + +extern void apply_dispatch(StringInfo s); + +extern void InitializeApplyWorker(void); + +/* Function for apply error callback */ +extern void apply_error_callback(void *arg); + +extern void subscription_change_cb(Datum arg, int cacheid, uint32 hashvalue); + +/* Apply background worker setup and interactions */ +extern ApplyBgworkerInfo *apply_bgworker_start(TransactionId xid); +extern ApplyBgworkerInfo *apply_bgworker_find(TransactionId xid); +extern void apply_bgworker_free(ApplyBgworkerInfo *winfo); +extern void apply_bgworker_set_state(ApplyBgworkerState state); +extern void apply_bgworker_wait_for(ApplyBgworkerInfo *winfo, + ApplyBgworkerState wait_for_state); +extern void apply_bgworker_send_data(ApplyBgworkerInfo *winfo, Size nbytes, + const void *data); + +extern void apply_bgworker_subxact_info_add(TransactionId current_xid); +extern void apply_bgworker_savepoint_name(Oid suboid, Oid relid, + char *spname, int szsp); + +#define isApplyBgWorker(worker) (worker->apply_leader_pid != InvalidPid) + static inline bool am_tablesync_worker(void) { return OidIsValid(MyLogicalRepWorker->relid); } +static inline bool +am_apply_bgworker(void) +{ + return isApplyBgWorker(MyLogicalRepWorker); +} + #endif /* WORKER_INTERNAL_H */ diff --git a/src/include/storage/procsignal.h b/src/include/storage/procsignal.h index ee63690..33af33e 100644 --- a/src/include/storage/procsignal.h +++ b/src/include/storage/procsignal.h @@ -35,6 +35,7 @@ typedef enum PROCSIG_WALSND_INIT_STOPPING, /* ask walsenders to prepare for shutdown */ PROCSIG_BARRIER, /* global barrier interrupt */ PROCSIG_LOG_MEMORY_CONTEXT, /* ask backend to log the memory contexts */ + PROCSIG_APPLY_BGWORKER_MESSAGE, /* Message from apply background workers */ /* Recovery conflict reasons */ PROCSIG_RECOVERY_CONFLICT_DATABASE, diff --git a/src/include/utils/wait_event.h b/src/include/utils/wait_event.h index 6f2d561..8acee63 100644 --- a/src/include/utils/wait_event.h +++ b/src/include/utils/wait_event.h @@ -105,6 +105,7 @@ typedef enum WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATE, WAIT_EVENT_HASH_GROW_BUCKETS_ELECT, WAIT_EVENT_HASH_GROW_BUCKETS_REINSERT, + WAIT_EVENT_LOGICAL_APPLY_BGWORKER_STATE_CHANGE, WAIT_EVENT_LOGICAL_SYNC_DATA, WAIT_EVENT_LOGICAL_SYNC_STATE_CHANGE, WAIT_EVENT_MQ_INTERNAL, diff --git a/src/test/regress/expected/subscription.out b/src/test/regress/expected/subscription.out index ef0ebf9..99b9e86 100644 --- a/src/test/regress/expected/subscription.out +++ b/src/test/regress/expected/subscription.out @@ -217,9 +217,9 @@ ALTER SUBSCRIPTION regress_testsub SET (slot_name = NONE); (1 row) DROP SUBSCRIPTION regress_testsub; --- fail - streaming must be boolean +-- fail - streaming must be boolean or 'parallel' CREATE SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist' PUBLICATION testpub WITH (connect = false, streaming = foo); -ERROR: streaming requires a Boolean value +ERROR: streaming requires a Boolean value or "parallel" -- now it works CREATE SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist' PUBLICATION testpub WITH (connect = false, streaming = true); WARNING: tables were not subscribed, you will have to run ALTER SUBSCRIPTION ... REFRESH PUBLICATION to subscribe the tables @@ -230,6 +230,14 @@ WARNING: tables were not subscribed, you will have to run ALTER SUBSCRIPTION .. regress_testsub | regress_subscription_user | f | {testpub} | f | t | d | f | any | off | dbname=regress_doesnotexist | 0/0 (1 row) +ALTER SUBSCRIPTION regress_testsub SET (streaming = parallel); +\dRs+ + List of subscriptions + Name | Owner | Enabled | Publication | Binary | Streaming | Two-phase commit | Disable on error | Origin | Synchronous commit | Conninfo | Skip LSN +-----------------+---------------------------+---------+-------------+--------+-----------+------------------+------------------+--------+--------------------+-----------------------------+---------- + regress_testsub | regress_subscription_user | f | {testpub} | f | p | d | f | any | off | dbname=regress_doesnotexist | 0/0 +(1 row) + ALTER SUBSCRIPTION regress_testsub SET (streaming = false); ALTER SUBSCRIPTION regress_testsub SET (slot_name = NONE); \dRs+ diff --git a/src/test/regress/sql/subscription.sql b/src/test/regress/sql/subscription.sql index 4425faf..ed148e4 100644 --- a/src/test/regress/sql/subscription.sql +++ b/src/test/regress/sql/subscription.sql @@ -156,7 +156,7 @@ ALTER SUBSCRIPTION regress_testsub SET (slot_name = NONE); DROP SUBSCRIPTION regress_testsub; --- fail - streaming must be boolean +-- fail - streaming must be boolean or 'parallel' CREATE SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist' PUBLICATION testpub WITH (connect = false, streaming = foo); -- now it works @@ -164,6 +164,10 @@ CREATE SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist' PUB \dRs+ +ALTER SUBSCRIPTION regress_testsub SET (streaming = parallel); + +\dRs+ + ALTER SUBSCRIPTION regress_testsub SET (streaming = false); ALTER SUBSCRIPTION regress_testsub SET (slot_name = NONE); diff --git a/src/tools/pgindent/typedefs.list b/src/tools/pgindent/typedefs.list index 35c9f1e..4782ca1 100644 --- a/src/tools/pgindent/typedefs.list +++ b/src/tools/pgindent/typedefs.list @@ -116,6 +116,10 @@ Append AppendPath AppendRelInfo AppendState +ApplyBgworkerEntry +ApplyBgworkerInfo +ApplyBgworkerShared +ApplyBgworkerState ApplyErrorCallbackArg ApplyExecutionData ApplySubXactData @@ -1485,6 +1489,7 @@ LogicalRepRelId LogicalRepRelMapEntry LogicalRepRelation LogicalRepRollbackPreparedTxnData +LogicalRepStreamAbortData LogicalRepTupleData LogicalRepTyp LogicalRepWorker -- 2.7.2.windows.1