0002-Have-pg_dump-use-TRUNCATE-to-fix-up-pg_largeobject-r.patch
application/octet-stream
Filename: 0002-Have-pg_dump-use-TRUNCATE-to-fix-up-pg_largeobject-r.patch
Type: application/octet-stream
Part: 0
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch 0002
Subject: Have pg_dump use TRUNCATE to fix up pg_largeobject relfilenode.
| File | + | − |
|---|---|---|
| src/bin/pg_dump/pg_dump.c | 27 | 4 |
From c52c83268eb853f40df3c023e4f36da1553f06d2 Mon Sep 17 00:00:00 2001
From: Robert Haas <rhaas@postgresql.org>
Date: Thu, 14 Jul 2022 15:31:45 -0400
Subject: [PATCH 2/2] Have pg_dump use TRUNCATE to fix up pg_largeobject
relfilenode.
---
src/bin/pg_dump/pg_dump.c | 31 +++++++++++++++++++++++++++----
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index e4fdb6b75b..b399b2de1a 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -3141,6 +3141,7 @@ dumpDatabase(Archive *fout)
PGresult *lo_res;
PQExpBuffer loFrozenQry = createPQExpBuffer();
PQExpBuffer loOutQry = createPQExpBuffer();
+ PQExpBuffer loVacQry = createPQExpBuffer();
int i_relfrozenxid,
i_relfilenode,
i_oid,
@@ -3167,15 +3168,36 @@ dumpDatabase(Archive *fout)
i_relfilenode = PQfnumber(lo_res, "relfilenode");
i_oid = PQfnumber(lo_res, "oid");
- appendPQExpBufferStr(loOutQry, "\n-- For binary upgrade, preserve values for pg_largeobject and its index\n");
+ appendPQExpBufferStr(loOutQry, "\n-- For binary upgrade, set pg_largeobject relfrozenxid and relminmxid\n");
+ appendPQExpBufferStr(loVacQry, "\n-- For binary upgrade, preserve pg_largeobject and index relfilenodes\n");
for (int i = 0; i < PQntuples(lo_res); ++i)
+ {
+ Oid oid;
+ RelFileNumber relfilenumber;
+
appendPQExpBuffer(loOutQry, "UPDATE pg_catalog.pg_class\n"
- "SET relfrozenxid = '%u', relminmxid = '%u', relfilenode = '%u'\n"
+ "SET relfrozenxid = '%u', relminmxid = '%u'\n"
"WHERE oid = %u;\n",
atooid(PQgetvalue(lo_res, i, i_relfrozenxid)),
atooid(PQgetvalue(lo_res, i, i_relminmxid)),
- atooid(PQgetvalue(lo_res, i, i_relfilenode)),
- atooid(PQgetvalue(lo_res, i, i_oid)));
+ atooid(PQgetvalue(lo_res, i, i_relfilenode)));
+
+ oid = atooid(PQgetvalue(lo_res, i, i_oid));
+ relfilenumber = atooid(PQgetvalue(lo_res, i, i_relfilenode));
+
+ if (oid == LargeObjectRelationId)
+ appendPQExpBuffer(loVacQry,
+ "SELECT pg_catalog.binary_upgrade_set_next_heap_relfilenode('%u'::pg_catalog.oid);\n",
+ relfilenumber);
+ else if (oid == LargeObjectLOidPNIndexId)
+ appendPQExpBuffer(loVacQry,
+ "SELECT pg_catalog.binary_upgrade_set_next_index_relfilenode('%u'::pg_catalog.oid);\n",
+ relfilenumber);
+ }
+
+ appendPQExpBufferStr(loVacQry,
+ "TRUNCATE pg_catalog.pg_largeobject;\n");
+ appendPQExpBufferStr(loOutQry, loVacQry->data);
ArchiveEntry(fout, nilCatalogId, createDumpId(),
ARCHIVE_OPTS(.tag = "pg_largeobject",
@@ -3187,6 +3209,7 @@ dumpDatabase(Archive *fout)
destroyPQExpBuffer(loFrozenQry);
destroyPQExpBuffer(loOutQry);
+ destroyPQExpBuffer(loVacQry);
}
PQclear(res);
--
2.24.3 (Apple Git-128)