From 23c94d59b410930c1a0187c1c8eb131995ba3ccc Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Tue, 29 Mar 2022 02:26:13 +0200 Subject: [PATCH 5/7] fixup: minor simplification --- src/backend/optimizer/path/costsize.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/backend/optimizer/path/costsize.c b/src/backend/optimizer/path/costsize.c index bb0fe0c22ee..3e1daf8b893 100644 --- a/src/backend/optimizer/path/costsize.c +++ b/src/backend/optimizer/path/costsize.c @@ -2004,17 +2004,8 @@ compute_cpu_sort_cost(PlannerInfo *root, List *pathkeys, int nPresortedKeys, { if (heapSort) { - double heap_tuples; - /* have to keep at least one group, and a multiple of group size */ - /* FIXME Do we actually need the Max, here? Surely the ceil() returns - * at least 1.0 here, no? */ - heap_tuples = Max(ceil(output_tuples / tuplesPerPrevGroup) * tuplesPerPrevGroup, - tuplesPerPrevGroup); - - /* so how many (whole) groups is that? */ - /* FIXME so why not just ceil(putput_tuples / tuplesPerPrevGroup)? */ - correctedNGroups = ceil(heap_tuples / tuplesPerPrevGroup); + correctedNGroups = ceil(output_tuples / tuplesPerPrevGroup); } else /* all groups in the input */ -- 2.34.1