From b0d60791f06908d2dc118ff7f5dc669c91062913 Mon Sep 17 00:00:00 2001 From: Euler Taveira Date: Sun, 31 Jan 2021 20:48:43 -0300 Subject: [PATCH v18 2/2] Measure row filter overhead --- src/backend/replication/pgoutput/pgoutput.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/backend/replication/pgoutput/pgoutput.c b/src/backend/replication/pgoutput/pgoutput.c index 08c018a300..5700a3306b 100644 --- a/src/backend/replication/pgoutput/pgoutput.c +++ b/src/backend/replication/pgoutput/pgoutput.c @@ -638,6 +638,8 @@ pgoutput_row_filter(Relation relation, HeapTuple oldtuple, HeapTuple newtuple, R ExprContext *ecxt; ListCell *lc; bool result = true; + instr_time start_time; + instr_time end_time; /* Bail out if there is no row filter */ if (entry->qual == NIL) @@ -647,13 +649,12 @@ pgoutput_row_filter(Relation relation, HeapTuple oldtuple, HeapTuple newtuple, R get_namespace_name(get_rel_namespace(RelationGetRelid(relation))), get_rel_name(relation->rd_id)); + INSTR_TIME_SET_CURRENT(start_time); + PushActiveSnapshot(GetTransactionSnapshot()); estate = create_estate_for_relation(relation); - if (entry->scantuple == NULL) - elog(DEBUG1, "entry->scantuple is null"); - /* Prepare context per tuple */ ecxt = GetPerTupleExprContext(estate); ecxt->ecxt_scantuple = entry->scantuple; @@ -684,6 +685,11 @@ pgoutput_row_filter(Relation relation, HeapTuple oldtuple, HeapTuple newtuple, R FreeExecutorState(estate); PopActiveSnapshot(); + INSTR_TIME_SET_CURRENT(end_time); + INSTR_TIME_SUBTRACT(end_time, start_time); + + elog(DEBUG2, "row filter time: %0.3f us", INSTR_TIME_GET_DOUBLE(end_time) * 1e6); + return result; } @@ -1251,8 +1257,6 @@ get_rel_sync_entry(PGOutputData *data, Relation relation) { ExecDropSingleTupleTableSlot(entry->scantuple); entry->scantuple = NULL; - - elog(DEBUG1, "get_rel_sync_entry: free entry->scantuple"); } /* create a tuple table slot for row filter */ @@ -1261,8 +1265,6 @@ get_rel_sync_entry(PGOutputData *data, Relation relation) entry->scantuple = MakeSingleTupleTableSlot(tupdesc, &TTSOpsHeapTuple); MemoryContextSwitchTo(oldctx); - elog(DEBUG1, "get_rel_sync_entry: allocate entry->scantuple"); - /* * Build publication cache. We can't use one provided by relcache as * relcache considers all publications given relation is in, but here -- 2.20.1