v1-0001-Remove-unnecessary-assignment-of-pd_flags-to-0-in.patch

application/octet-stream

Filename: v1-0001-Remove-unnecessary-assignment-of-pd_flags-to-0-in.patch
Type: application/octet-stream
Part: 0
Message: Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit?

Patch

Format: format-patch
Series: patch v1-0001
Subject: Remove unnecessary assignment of pd_flags to 0 in PageInit
File+
src/backend/storage/page/bufpage.c 1 1
From c26f68811196dea261337164011ab379e9d583f7 Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy <bharath.rupireddy@enterprisedb.com>
Date: Thu, 8 Apr 2021 07:42:36 +0530
Subject: [PATCH v1] Remove unnecessary assignment of pd_flags to 0 in PageInit

---
 src/backend/storage/page/bufpage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/storage/page/bufpage.c b/src/backend/storage/page/bufpage.c
index b231c438f9..d00fad0f81 100644
--- a/src/backend/storage/page/bufpage.c
+++ b/src/backend/storage/page/bufpage.c
@@ -51,7 +51,7 @@ PageInit(Page page, Size pageSize, Size specialSize)
 	/* Make sure all fields of page are zero, as well as unused space */
 	MemSet(p, 0, pageSize);
 
-	p->pd_flags = 0;
+	/* p->pd_flags = 0;		done by above MemSet */
 	p->pd_lower = SizeOfPageHeaderData;
 	p->pd_upper = pageSize - specialSize;
 	p->pd_special = pageSize - specialSize;
-- 
2.25.1