without_extension_explicit_schema-v0.patch

text/plain

Filename: without_extension_explicit_schema-v0.patch
Type: text/plain
Part: 0
Message: Re: Extensions not dumped when --schema is used

Patch

Format: unified
Series: patch v0
File+
src/test/modules/test_pg_dump/t/001_base.pl 16 0
commit d210c01 (demo-dumpext-public)
Author:     Noah Misch <noah@leadboat.com>
AuthorDate: Thu Apr 1 17:36:13 2021 -0700
Commit:     Noah Misch <noah@leadboat.com>
CommitDate: Thu Apr 1 17:36:13 2021 -0700

    demo
---
 src/test/modules/test_pg_dump/t/001_base.pl | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/src/test/modules/test_pg_dump/t/001_base.pl b/src/test/modules/test_pg_dump/t/001_base.pl
index 7c053c4..600015e 100644
--- a/src/test/modules/test_pg_dump/t/001_base.pl
+++ b/src/test/modules/test_pg_dump/t/001_base.pl
@@ -203,11 +203,23 @@ my %pgdump_runs = (
 	},
 
 	# plgsql in the list blocks the dump of extension test_pg_dump
+	# TODO --no-sync needn't appear twice
 	without_extension => {
 		dump_cmd => [
 			'pg_dump', '--no-sync', "--file=$tempdir/without_extension.sql",
 			'--extension=plpgsql', '--no-sync', 'postgres',
 		],
+	},
+
+	without_extension_explicit_schema => {
+		dump_cmd => [
+			'pg_dump',
+			'--no-sync',
+			"--file=$tempdir/without_extension_explicit_schema.sql",
+			'--extension=plpgsql',
+			'--schema=public',
+			'postgres',
+		],
 	},);
 
 ###############################################################
@@ -632,6 +644,8 @@ my %tests = (
 			pg_dumpall_globals => 1,
 			section_data       => 1,
 			section_pre_data   => 1,
+			# excludes this schema
+			without_extension_explicit_schema => 1,
 		},
 	},
 
@@ -646,6 +660,8 @@ my %tests = (
 			pg_dumpall_globals => 1,
 			section_data       => 1,
 			section_pre_data   => 1,
+			# excludes this schema
+			without_extension_explicit_schema => 1,
 		},
 	},