v1-0001-Remove-bogus-lwlock__acquire-tracepoint-from-LWLo.patch

application/x-patch

Download

Filename: v1-0001-Remove-bogus-lwlock__acquire-tracepoint-from-LWLo.patch

Type: application/x-patch

Part: 1

Message: [PATCH] Identify LWLocks in tracepoints

Patch

Format: format-patch

Series: patch v1-0001

Subject: Remove bogus lwlock__acquire tracepoint from LWLockWaitForVar

File	+	−
src/backend/storage/lmgr/lwlock.c	0	2

From e5f7ba0ba4c72db7f59c3d22818f532f6b0be90a Mon Sep 17 00:00:00 2001
From: Craig Ringer <craig.ringer@2ndquadrant.com>
Date: Thu, 19 Nov 2020 18:15:34 +0800
Subject: [PATCH v1 1/4] Remove bogus lwlock__acquire tracepoint from
 LWLockWaitForVar

Calls to LWLockWaitForVar fired the TRACE_POSTGRESQL_LWLOCK_ACQUIRE
tracepoint, but LWLockWaitForVar() never actually acquires the
LWLock. Remove it.
---
 src/backend/storage/lmgr/lwlock.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/backend/storage/lmgr/lwlock.c b/src/backend/storage/lmgr/lwlock.c
index 108e652179..29e29707d7 100644
--- a/src/backend/storage/lmgr/lwlock.c
+++ b/src/backend/storage/lmgr/lwlock.c
@@ -1726,8 +1726,6 @@ LWLockWaitForVar(LWLock *lock, uint64 *valptr, uint64 oldval, uint64 *newval)
 		/* Now loop back and check the status of the lock again. */
 	}
 
-	TRACE_POSTGRESQL_LWLOCK_ACQUIRE(T_NAME(lock), LW_EXCLUSIVE);
-
 	/*
 	 * Fix the process wait semaphore's count for any absorbed wakeups.
 	 */
-- 
2.29.2