v5-0002-Export-split_table_columns_spec-for-use-in-vacuum.patch

application/octet-stream

Filename: v5-0002-Export-split_table_columns_spec-for-use-in-vacuum.patch
Type: application/octet-stream
Part: 1
Message: Re: A few new options for vacuumdb

Patch

Format: format-patch
Series: patch v5-0002
Subject: Export split_table_columns_spec() for use in vacuumdb.
File+
src/bin/scripts/common.c 4 4
src/bin/scripts/common.h 3 0
From 0686bfafda890148428fbcff215db932c54c0ade Mon Sep 17 00:00:00 2001
From: Nathan Bossart <bossartn@amazon.com>
Date: Wed, 23 Jan 2019 22:18:56 +0000
Subject: [PATCH v5 2/4] Export split_table_columns_spec() for use in vacuumdb.

---
 src/bin/scripts/common.c | 8 ++++----
 src/bin/scripts/common.h | 3 +++
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/bin/scripts/common.c b/src/bin/scripts/common.c
index 4215bc3d6e..7139b7c667 100644
--- a/src/bin/scripts/common.c
+++ b/src/bin/scripts/common.c
@@ -265,9 +265,9 @@ executeMaintenanceCommand(PGconn *conn, const char *query, bool echo)
  * finish using them, pg_free(*table).  *columns is a pointer into "spec",
  * possibly to its NUL terminator.
  */
-static void
-split_table_columns_spec(const char *spec, int encoding,
-						 char **table, const char **columns)
+void
+splitTableColumnsSpec(const char *spec, int encoding,
+					  char **table, const char **columns)
 {
 	bool		inquotes = false;
 	const char *cp = spec;
@@ -318,7 +318,7 @@ appendQualifiedRelation(PQExpBuffer buf, const char *spec,
 		return;
 	}
 
-	split_table_columns_spec(spec, PQclientEncoding(conn), &table, &columns);
+	splitTableColumnsSpec(spec, PQclientEncoding(conn), &table, &columns);
 
 	/*
 	 * Query must remain ABSOLUTELY devoid of unqualified names.  This would
diff --git a/src/bin/scripts/common.h b/src/bin/scripts/common.h
index 7c3888cefd..b59ade0c39 100644
--- a/src/bin/scripts/common.h
+++ b/src/bin/scripts/common.h
@@ -48,6 +48,9 @@ extern void executeCommand(PGconn *conn, const char *query,
 extern bool executeMaintenanceCommand(PGconn *conn, const char *query,
 						  bool echo);
 
+extern void splitTableColumnsSpec(const char *spec, int encoding,
+					  char **table, const char **columns);
+
 extern void appendQualifiedRelation(PQExpBuffer buf, const char *name,
 						PGconn *conn, const char *progname, bool echo);
 
-- 
2.16.5