From 77896a7385d1ef5c793e06c5085a8b37ab5857c9 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Tue, 20 Mar 2012 16:33:13 +0100 Subject: [PATCH] Check that the specified tablespace in a CREATE TABLE AS command is not pg_global That check was not added to the CTAS code when it was added to the ordinary CREATE TABLE AS. It might be nicer to add that check heap_create_with_catalog as well, but thats not easily possible because e.g. cluster creates a temporary new heap which cannot be marked shared because there is a fixed list of shared relations (see IsSharedRelation). --- src/backend/executor/execMain.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index 621ad8a..8a43db7 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -43,6 +43,7 @@ #include "access/xact.h" #include "catalog/heap.h" #include "catalog/namespace.h" +#include "catalog/pg_tablespace.h" #include "catalog/toasting.h" #include "commands/tablespace.h" #include "commands/trigger.h" @@ -2452,6 +2453,12 @@ OpenIntoRel(QueryDesc *queryDesc) get_tablespace_name(tablespaceId)); } + /* In all cases disallow placing user relations in pg_global */ + if (tablespaceId == GLOBALTABLESPACE_OID) + ereport(ERROR, + (errcode(ERRCODE_INVALID_PARAMETER_VALUE), + errmsg("only shared relations can be placed in pg_global tablespace"))); + /* Parse and validate any reloptions */ reloptions = transformRelOptions((Datum) 0, into->options, -- 1.7.6.409.ge7a85.dirty