init-proc-global-cleanup.patch

*** a/src/backend/storage/lmgr/proc.c
--- b/src/backend/storage/lmgr/proc.c
***************
*** 160,165 **** InitProcGlobal(void)
--- 160,166 ----
  	PGPROC	   *procs;
  	int			i;
  	bool		found;
+ 	uint32		TotalProcs = MaxBackends + NUM_AUXILIARY_PROCS;
  
  	/* Create the ProcGlobal shared structure */
  	ProcGlobal = (PROC_HDR *)
***************
*** 167,234 **** InitProcGlobal(void)
  	Assert(!found);
  
  	/*
- 	 * Create the PGPROC structures for auxiliary (bgwriter) processes, too.
- 	 * These do not get linked into the freeProcs list.
- 	 */
- 	AuxiliaryProcs = (PGPROC *)
- 		ShmemInitStruct("AuxiliaryProcs", NUM_AUXILIARY_PROCS * sizeof(PGPROC),
- 						&found);
- 	Assert(!found);
- 
- 	/*
  	 * Initialize the data structures.
  	 */
  	ProcGlobal->freeProcs = NULL;
  	ProcGlobal->autovacFreeProcs = NULL;
  
- 	ProcGlobal->spins_per_delay = DEFAULT_SPINS_PER_DELAY;
- 
  	/*
  	 * Pre-create the PGPROC structures and create a semaphore for each.
  	 */
! 	procs = (PGPROC *) ShmemAlloc((MaxConnections) * sizeof(PGPROC));
  	if (!procs)
  		ereport(FATAL,
  				(errcode(ERRCODE_OUT_OF_MEMORY),
  				 errmsg("out of shared memory")));
! 	MemSet(procs, 0, MaxConnections * sizeof(PGPROC));
! 	for (i = 0; i < MaxConnections; i++)
  	{
  		PGSemaphoreCreate(&(procs[i].sem));
! 		procs[i].links.next = (SHM_QUEUE *) ProcGlobal->freeProcs;
! 		ProcGlobal->freeProcs = &procs[i];
! 		InitSharedLatch(&procs[i].waitLatch);
! 	}
! 
! 	/*
! 	 * Likewise for the PGPROCs reserved for autovacuum.
! 	 *
! 	 * Note: the "+1" here accounts for the autovac launcher
! 	 */
! 	procs = (PGPROC *) ShmemAlloc((autovacuum_max_workers + 1) * sizeof(PGPROC));
! 	if (!procs)
! 		ereport(FATAL,
! 				(errcode(ERRCODE_OUT_OF_MEMORY),
! 				 errmsg("out of shared memory")));
! 	MemSet(procs, 0, (autovacuum_max_workers + 1) * sizeof(PGPROC));
! 	for (i = 0; i < autovacuum_max_workers + 1; i++)
! 	{
! 		PGSemaphoreCreate(&(procs[i].sem));
! 		procs[i].links.next = (SHM_QUEUE *) ProcGlobal->autovacFreeProcs;
! 		ProcGlobal->autovacFreeProcs = &procs[i];
! 		InitSharedLatch(&procs[i].waitLatch);
! 	}
! 
! 	/*
! 	 * And auxiliary procs.
! 	 */
! 	MemSet(AuxiliaryProcs, 0, NUM_AUXILIARY_PROCS * sizeof(PGPROC));
! 	for (i = 0; i < NUM_AUXILIARY_PROCS; i++)
! 	{
! 		AuxiliaryProcs[i].pid = 0;		/* marks auxiliary proc as not in use */
! 		PGSemaphoreCreate(&(AuxiliaryProcs[i].sem));
  		InitSharedLatch(&procs[i].waitLatch);
  	}
  
  	/* Create ProcStructLock spinlock, too */
  	ProcStructLock = (slock_t *) ShmemAlloc(sizeof(slock_t));
--- 168,204 ----
  	Assert(!found);
  
  	/*
  	 * Initialize the data structures.
  	 */
+ 	ProcGlobal->spins_per_delay = DEFAULT_SPINS_PER_DELAY;
  	ProcGlobal->freeProcs = NULL;
  	ProcGlobal->autovacFreeProcs = NULL;
  
  	/*
  	 * Pre-create the PGPROC structures and create a semaphore for each.
  	 */
! 	procs = (PGPROC *) ShmemAlloc(TotalProcs * sizeof(PGPROC));
  	if (!procs)
  		ereport(FATAL,
  				(errcode(ERRCODE_OUT_OF_MEMORY),
  				 errmsg("out of shared memory")));
! 	MemSet(procs, 0, TotalProcs * sizeof(PGPROC));
! 	for (i = 0; i < TotalProcs; i++)
  	{
  		PGSemaphoreCreate(&(procs[i].sem));
! 		if (i < MaxConnections)
! 		{
! 			procs[i].links.next = (SHM_QUEUE *) ProcGlobal->freeProcs;
! 			ProcGlobal->freeProcs = &procs[i];
! 		}
! 		else if (i < MaxBackends)
! 		{
! 			procs[i].links.next = (SHM_QUEUE *) ProcGlobal->autovacFreeProcs;
! 			ProcGlobal->autovacFreeProcs = &procs[i];
! 		}
  		InitSharedLatch(&procs[i].waitLatch);
  	}
+ 	AuxiliaryProcs = &procs[MaxBackends];
  
  	/* Create ProcStructLock spinlock, too */
  	ProcStructLock = (slock_t *) ShmemAlloc(sizeof(slock_t));