(unnamed)

text/plain

Download

On Dec 28, 2010, at 12:12 PM, Alvaro Herrera wrote:

> Excerpts from Karl Lehenbauer's message of mar dic 28 12:33:42 -0300 2010:
>> Project name: Add table function support to PL/Tcl (Todo item)
>> 
>> What the patch does:
>> 
>> This patch adds table function support (returning record and SETOF record)
>> to PL/Tcl.  This patch also updates PL/Tcl to use the Tcl object-style 
>> interface instead of the older string-style one, increasing performance.
> 
> While I don't use PL/Tcl myself, this seems a reasonable idea.  However,
> I think this patch does too many things in one step.  It also contains
> numerous superfluous whitespace changes that make it hard to assess its
> real size.
> 
> I'd recommend splitting it up and dropping the whitespace changes (which
> would be reverted by pgindent anyway).
> 
> -- 
> Álvaro Herrera <alvherre@commandprompt.com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support