v2-0001-Improve-the-wording-of-logical-slot-prerequisites.patch

application/octet-stream

Filename: v2-0001-Improve-the-wording-of-logical-slot-prerequisites.patch
Type: application/octet-stream
Part: 0
Message: Re: Logical Replication upgrade

Patch

Format: format-patch
Series: patch v2-0001
Subject: Improve the wording of logical slot prerequisites to make the conditions easier to understand.
File+
doc/src/sgml/logical-replication.sgml 5 6
From d891802fd8fae9daa544c5229bf1674f131e5421 Mon Sep 17 00:00:00 2001
From: Vignesh C <vignesh21@gmail.com>
Date: Thu, 16 Apr 2026 12:36:34 +0530
Subject: [PATCH v2] Improve the wording of logical slot prerequisites to make
 the conditions easier to understand.

Replace the previous negative phrasing such as "there are no slots
whose ... is not true" with a direct expression that all slots must
have conflicting = false.

Similarly, reword the requirement on the new cluster to state that it
must not have any permanent logical slots, clarifying that any existing
logical slots must have temporary set to true.

These changes improve readability without altering the meaning.

Author: Vignesh C <vignesh21@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: David G. Johnston <david.g.johnston@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/177609278737.403059.14174275013090471947%40wrigleys.postgresql.org
---
 doc/src/sgml/logical-replication.sgml | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index 23b268273b9..598e23ad4f5 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -2785,18 +2785,17 @@ CONTEXT:  processing remote data for replication origin "pg_16395" during "INSER
     </listitem>
     <listitem>
      <para>
-      All slots on the old cluster must be usable, i.e., there are no slots
-      whose
+      All slots on the old cluster must be usable, i.e., their
       <link linkend="view-pg-replication-slots">pg_replication_slots</link>.<structfield>conflicting</structfield>
-      is not <literal>true</literal>.
+      is <literal>false</literal>.
      </para>
     </listitem>
     <listitem>
      <para>
-      The new cluster must not have permanent logical slots, i.e.,
-      there must be no slots where
+      The new cluster must not have any permanent logical slots; i.e., any
+      existing logical slots must have
       <link linkend="view-pg-replication-slots">pg_replication_slots</link>.<structfield>temporary</structfield>
-      is <literal>false</literal>.
+      set to <literal>true</literal>.
      </para>
     </listitem>
    </itemizedlist>
-- 
2.43.0