v2-0005-Typo-and-spelling-fixups-for-online-checksums.patch

application/octet-stream

Filename: v2-0005-Typo-and-spelling-fixups-for-online-checksums.patch
Type: application/octet-stream
Part: 4
Message: Re: Changing the state of data checksums in a running cluster

Patch

Same data as JSON: GET /api/v1/attachments/:id/patch the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes. API reference →
Format: format-patch
Series: patch v2-0005
Subject: Typo and spelling fixups for online checksums
File+
src/backend/access/transam/xlog.c 2 3
src/backend/postmaster/datachecksum_state.c 6 6
From 4ceb94bb3dec9e7255c83878367c187eba76ac1a Mon Sep 17 00:00:00 2001
From: Daniel Gustafsson <dgustafsson@postgresql.org>
Date: Tue, 28 Apr 2026 23:49:28 +0200
Subject: [PATCH v2 5/8] Typo and spelling fixups for online checksums

A collection of spelling, wording and punctuation fixups for the code
documentation from postcommit review.

Author: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/xxx
---
 src/backend/access/transam/xlog.c           |  5 ++---
 src/backend/postmaster/datachecksum_state.c | 12 ++++++------
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 9b1a10dbd1c..7eb61158f26 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -4893,9 +4893,8 @@ SetDataChecksumsOff(void)
 	else
 	{
 		/*
-		 * Ending up here implies that the checksums state is "inprogress-on"
-		 * or "inprogress-off" and we can transition directly to "off" from
-		 * there.
+		 * Ending up here implies that the checksums state is "inprogress-off"
+		 * and we can transition directly to "off" from there.
 		 */
 		SpinLockRelease(&XLogCtl->info_lck);
 	}
diff --git a/src/backend/postmaster/datachecksum_state.c b/src/backend/postmaster/datachecksum_state.c
index 0499cc005b3..27cdbb3ed1e 100644
--- a/src/backend/postmaster/datachecksum_state.c
+++ b/src/backend/postmaster/datachecksum_state.c
@@ -86,7 +86,7 @@
  * failing to validate the data checksum on the page when reading it.
  *
  * When processing starts all backends belong to one of the below sets, with
- * one if Bd and Bi being empty:
+ * one of Bd and Bi being empty:
  *
  * Bg: Backend updating the global state and emitting the procsignalbarrier
  * Bd: Backends in "off" state
@@ -286,7 +286,7 @@ typedef struct DataChecksumsStateStruct
 	int			launch_cost_limit;
 
 	/*
-	 * Is a launcher process is currently running?  This is set by the main
+	 * Is a launcher process currently running?  This is set by the main
 	 * launcher process, after it has read the above launch_* parameters.
 	 */
 	bool		launcher_running;
@@ -325,7 +325,7 @@ typedef struct DataChecksumsStateStruct
 	DataChecksumsWorkerResult success;
 
 	/*
-	 * tells the worker process whether it should also process the shared
+	 * Tells the worker process whether it should also process the shared
 	 * catalogs
 	 */
 	bool		process_shared_catalogs;
@@ -820,7 +820,7 @@ ProcessDatabase(DataChecksumsWorkerDatabase *db)
 	{
 		/*
 		 * If the worker managed to start, and stop, before we got to waiting
-		 * for it we can se a STOPPED status here without it being a failure.
+		 * for it we can see a STOPPED status here without it being a failure.
 		 */
 		if (DataChecksumState->success == DATACHECKSUMSWORKER_SUCCESSFUL)
 		{
@@ -1323,7 +1323,7 @@ DataChecksumsShmemInit(void *arg)
  * DatabaseExists
  *
  * Scans the system catalog to check if a database with the given Oid exists
- * and returns true if it is found  else false.
+ * and returns true if it is found, else false.
  */
 static bool
 DatabaseExists(Oid dboid)
@@ -1486,7 +1486,7 @@ BuildRelationList(bool temp_relations, bool include_shared)
 /*
  * DataChecksumsWorkerMain
  *
- * Main function for enabling checksums in a single database, This is the
+ * Main function for enabling checksums in a single database. This is the
  * function set as the bgw_function_name in the dynamic background worker
  * process initiated for each database by the worker launcher. After enabling
  * data checksums in each applicable relation in the database, it will wait for
-- 
2.39.3 (Apple Git-146)