v1-0001-GetPublicationsStr-i18n-support.patch

application/octet-stream

Filename: v1-0001-GetPublicationsStr-i18n-support.patch
Type: application/octet-stream
Part: 0
Message: Re: Redundant/mis-use of _(x) gettext macro?

Patch

Same data as JSON: GET /api/v1/attachments/:id/patch the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes. API reference →
Format: format-patch
Series: patch v1-0001
Subject: GetPublicationsStr i18n support
File+
src/backend/catalog/pg_subscription.c 11 8
From cd09ae7e4c18bfcb1b6522ec1aa16cfa3b5f502e Mon Sep 17 00:00:00 2001
From: Peter Smith <peter.b.smith@fujitsu.com>
Date: Tue, 7 Apr 2026 14:45:11 +1000
Subject: [PATCH v1] GetPublicationsStr i18n support

---
 src/backend/catalog/pg_subscription.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/backend/catalog/pg_subscription.c b/src/backend/catalog/pg_subscription.c
index 5a733585490..8b31c487dba 100644
--- a/src/backend/catalog/pg_subscription.c
+++ b/src/backend/catalog/pg_subscription.c
@@ -54,19 +54,22 @@ GetPublicationsStr(List *publications, StringInfo dest, bool quote_literal)
 	{
 		char	   *pubname = strVal(lfirst(lc));
 
-		if (first)
-			first = false;
-		else
-			appendStringInfoString(dest, ", ");
-
 		if (quote_literal)
+		{
+			if (!first)
+				appendStringInfoString(dest, ", ");
+
 			appendStringInfoString(dest, quote_literal_cstr(pubname));
+		}
 		else
 		{
-			appendStringInfoChar(dest, '"');
-			appendStringInfoString(dest, pubname);
-			appendStringInfoChar(dest, '"');
+			if (!first)
+				appendStringInfoString(dest, _(", "));
+
+			appendStringInfo(dest, _("\"%s\""), pubname);
 		}
+
+		first = false;
 	}
 }
 
-- 
2.47.3