(unnamed)

text/html

Download

<div>Hello,</div><div><div>I saw a big comment that I had missed.</div></div><div>Added fixes in two patches:</div><div><div>v11-0001-Migration-of-the-pg_commit_ts-directory.patch   - main changes</div></div><div>v11-0002-Migration-of-the-pg_commit_ts-directory-desc.patch - changes to documentation and comments</div><div> </div><div> </div><div>----------------</div><div>Кому: 'ls7777' (ls7777@yandex.ru);</div><div>Копия: pgsql-hackers@postgresql.org, orlovmg@gmail.com;</div><div>Тема: Patch for migration of the pg_commit_ts directory;</div><div>11.03.2026, 12:55, "Hayato Kuroda (Fujitsu)" &lt;kuroda.hayato@fujitsu.com&gt;:</div><blockquote><p>Dear Sergey,<br /> </p><blockquote> I don't understand what I need to do.<br />Subject: [PATCH v10] Migration of the pg_commit_ts directory<br /> I have specified a new version in the patch. Do I need to add anything else?</blockquote><p><br />When we see the commit message in postgres repo, you can see that each commit<br />contain the background, what we did in the commit, considerations, and etc.<br />Compared with them, the description you added seems insufficient.<br />Of course the committer will take care, but Amit suggested [1] to write a draft.<br />The basic style guide is determined in [2].<br /><br />Actually I wrote a draft for the patch set in v9-0002, but you missed. You may<br />able to refer it, and re-create new version or use the same one.<br /><br />[1]: <a href="https://www.postgresql.org/message-id/CAA4eK1KMuhaH%3DQgzJCwQgawuybosq-JMWWT9qSqyMZNV1MWjtg%40mail.gmail.com" rel="noopener noreferrer">https://www.postgresql.org/message-id/CAA4eK1KMuhaH%3DQgzJCwQgawuybosq-JMWWT9qSqyMZNV1MWjtg%40mail.gmail.com</a><br />[2]: <a href="https://wiki.postgresql.org/wiki/Commit_Message_Guidance" rel="noopener noreferrer">https://wiki.postgresql.org/wiki/Commit_Message_Guidance</a><br /><br />Best regards,<br />Hayato Kuroda<br />FUJITSU LIMITED<br /> </p></blockquote>