v1-0001-Rename-CRC-choose-files-for-future-general-purpos.patch

application/x-patch

Filename: v1-0001-Rename-CRC-choose-files-for-future-general-purpos.patch
Type: application/x-patch
Part: 0
Message: centralize CPU feature detection

Patch

Format: format-patch
Series: patch v1-0001
Subject: Rename CRC "choose" files for future general purpose
File+
configure 2 2
configure.ac 2 2
src/port/meson.build 2 2
src/port/pg_x86_feature.c 0 0
From 145bc4f00c8270b046c651e42686a2a18ad16ddb Mon Sep 17 00:00:00 2001
From: John Naylor <john.naylor@postgresql.org>
Date: Wed, 11 Feb 2026 14:34:18 +0700
Subject: [PATCH v1 1/4] Rename CRC "choose" files for future general purpose

WIP: x86 only
---
 configure                                               | 4 ++--
 configure.ac                                            | 4 ++--
 src/port/meson.build                                    | 4 ++--
 src/port/{pg_crc32c_sse42_choose.c => pg_x86_feature.c} | 0
 4 files changed, 6 insertions(+), 6 deletions(-)
 rename src/port/{pg_crc32c_sse42_choose.c => pg_x86_feature.c} (100%)

diff --git a/configure b/configure
index a10a2c85c6a..373194daa05 100755
--- a/configure
+++ b/configure
@@ -18196,7 +18196,7 @@ if test x"$USE_SSE42_CRC32C" = x"1"; then
 
 $as_echo "#define USE_SSE42_CRC32C 1" >>confdefs.h
 
-  PG_CRC32C_OBJS="pg_crc32c_sse42.o pg_crc32c_sse42_choose.o"
+  PG_CRC32C_OBJS="pg_crc32c_sse42.o pg_x86_feature.o"
   { $as_echo "$as_me:${as_lineno-$LINENO}: result: SSE 4.2" >&5
 $as_echo "SSE 4.2" >&6; }
 else
@@ -18204,7 +18204,7 @@ else
 
 $as_echo "#define USE_SSE42_CRC32C_WITH_RUNTIME_CHECK 1" >>confdefs.h
 
-    PG_CRC32C_OBJS="pg_crc32c_sse42.o pg_crc32c_sb8.o pg_crc32c_sse42_choose.o"
+    PG_CRC32C_OBJS="pg_crc32c_sse42.o pg_crc32c_sb8.o pg_x86_feature.o"
     { $as_echo "$as_me:${as_lineno-$LINENO}: result: SSE 4.2 with runtime check" >&5
 $as_echo "SSE 4.2 with runtime check" >&6; }
   else
diff --git a/configure.ac b/configure.ac
index 814e64a967e..62e47394544 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2245,12 +2245,12 @@ fi
 AC_MSG_CHECKING([which CRC-32C implementation to use])
 if test x"$USE_SSE42_CRC32C" = x"1"; then
   AC_DEFINE(USE_SSE42_CRC32C, 1, [Define to 1 use Intel SSE 4.2 CRC instructions.])
-  PG_CRC32C_OBJS="pg_crc32c_sse42.o pg_crc32c_sse42_choose.o"
+  PG_CRC32C_OBJS="pg_crc32c_sse42.o pg_x86_feature.o"
   AC_MSG_RESULT(SSE 4.2)
 else
   if test x"$USE_SSE42_CRC32C_WITH_RUNTIME_CHECK" = x"1"; then
     AC_DEFINE(USE_SSE42_CRC32C_WITH_RUNTIME_CHECK, 1, [Define to 1 to use Intel SSE 4.2 CRC instructions with a runtime check.])
-    PG_CRC32C_OBJS="pg_crc32c_sse42.o pg_crc32c_sb8.o pg_crc32c_sse42_choose.o"
+    PG_CRC32C_OBJS="pg_crc32c_sse42.o pg_crc32c_sb8.o pg_x86_feature.o"
     AC_MSG_RESULT(SSE 4.2 with runtime check)
   else
     if test x"$USE_ARMV8_CRC32C" = x"1"; then
diff --git a/src/port/meson.build b/src/port/meson.build
index d7d4e705b89..d96b4eed4c6 100644
--- a/src/port/meson.build
+++ b/src/port/meson.build
@@ -86,8 +86,8 @@ replace_funcs_pos = [
   # x86/x64
   ['pg_crc32c_sse42', 'USE_SSE42_CRC32C'],
   ['pg_crc32c_sse42', 'USE_SSE42_CRC32C_WITH_RUNTIME_CHECK'],
-  ['pg_crc32c_sse42_choose', 'USE_SSE42_CRC32C'],
-  ['pg_crc32c_sse42_choose', 'USE_SSE42_CRC32C_WITH_RUNTIME_CHECK'],
+  ['pg_x86_feature', 'USE_SSE42_CRC32C'],
+  ['pg_x86_feature', 'USE_SSE42_CRC32C_WITH_RUNTIME_CHECK'],
   ['pg_crc32c_sb8', 'USE_SSE42_CRC32C_WITH_RUNTIME_CHECK'],
 
   # arm / aarch64
diff --git a/src/port/pg_crc32c_sse42_choose.c b/src/port/pg_x86_feature.c
similarity index 100%
rename from src/port/pg_crc32c_sse42_choose.c
rename to src/port/pg_x86_feature.c
-- 
2.53.0