v9-0002-minor-fixes-for-some-errhints.patch

text/x-patch

Filename: v9-0002-minor-fixes-for-some-errhints.patch
Type: text/x-patch
Part: 1
Message: Re: Add expressions to pg_restore_extended_stats()

Patch

Format: format-patch
Series: patch v9-0002
Subject: minor fixes for some errhints
File+
src/backend/statistics/extended_stats_funcs.c 3 4
From 71d3fad977756dbfd8f430d79802fb7a71b3fb20 Mon Sep 17 00:00:00 2001
From: Corey Huinker <corey.huinker@gmail.com>
Date: Mon, 9 Feb 2026 09:11:02 -0500
Subject: [PATCH v9 2/5] minor fixes for some errhints

---
 src/backend/statistics/extended_stats_funcs.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/backend/statistics/extended_stats_funcs.c b/src/backend/statistics/extended_stats_funcs.c
index a34e8e31352..229092e852d 100644
--- a/src/backend/statistics/extended_stats_funcs.c
+++ b/src/backend/statistics/extended_stats_funcs.c
@@ -1153,8 +1153,7 @@ import_pg_statistic(Relation pgsd, JsonbContainer *cont,
 				ereport(WARNING,
 						errcode(ERRCODE_INVALID_PARAMETER_VALUE),
 						errmsg("could not parse \"%s\": invalid element in expression %d", argname, exprnum),
-						errhint("Value of element \"%s\" must be type a null or a string.",
-								s, exprnum));
+						errhint("Value of element \"%s\" must be type a null or a string.", s));
 				goto pg_statistic_error;
 		}
 	}
@@ -1177,7 +1176,7 @@ import_pg_statistic(Relation pgsd, JsonbContainer *cont,
 					   argname, exprnum),
 				errhint("\"%s\" and \"%s\" must be both either strings or nulls.",
 						extexprargname[MOST_COMMON_VALS_ELEM],
-						extexprargname[MOST_COMMON_FREQS_ELEM], exprnum));
+						extexprargname[MOST_COMMON_FREQS_ELEM]));
 		goto pg_statistic_error;
 	}
 	if (found[MOST_COMMON_ELEMS_ELEM] != found[MOST_COMMON_ELEM_FREQS_ELEM])
@@ -1188,7 +1187,7 @@ import_pg_statistic(Relation pgsd, JsonbContainer *cont,
 					   argname, exprnum),
 				errhint("\"%s\" and \"%s\" must be both either strings or nulls.",
 						extexprargname[MOST_COMMON_ELEMS_ELEM],
-						extexprargname[MOST_COMMON_ELEM_FREQS_ELEM], exprnum));
+						extexprargname[MOST_COMMON_ELEM_FREQS_ELEM]));
 		goto pg_statistic_error;
 	}
 
-- 
2.53.0