repack_reserve_plugin_name.diff
text/x-diff
Filename: repack_reserve_plugin_name.diff
Type: text/x-diff
Part: 0
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: unified
| File | + | − |
|---|---|---|
| src/backend/commands/repack_worker.c | 1 | 3 |
| src/backend/replication/logical/logical.c | 11 | 0 |
| src/include/commands/repack.h | 2 | 0 |
diff --git a/src/backend/commands/repack_worker.c b/src/backend/commands/repack_worker.c
index b6b7b604b4f..5213b1e050f 100644
--- a/src/backend/commands/repack_worker.c
+++ b/src/backend/commands/repack_worker.c
@@ -28,8 +28,6 @@
#include "tcop/tcopprot.h"
#include "utils/memutils.h"
-#define REPL_PLUGIN_NAME "pgrepack"
-
static void RepackWorkerShutdown(int code, Datum arg);
static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
static void repack_cleanup_logical_decoding(LogicalDecodingContext *ctx);
@@ -228,7 +226,7 @@ repack_setup_logical_decoding(Oid relid)
* Neither prepare_write nor do_write callback nor update_progress is
* useful for us.
*/
- ctx = CreateInitDecodingContext(REPL_PLUGIN_NAME,
+ ctx = CreateInitDecodingContext(REPACK_PLUGIN_NAME,
NIL,
true,
true,
diff --git a/src/backend/replication/logical/logical.c b/src/backend/replication/logical/logical.c
index 3541fc793e4..572bed7b4d1 100644
--- a/src/backend/replication/logical/logical.c
+++ b/src/backend/replication/logical/logical.c
@@ -31,6 +31,7 @@
#include "access/xact.h"
#include "access/xlog_internal.h"
#include "access/xlogutils.h"
+#include "commands/repack.h"
#include "fmgr.h"
#include "miscadmin.h"
#include "pgstat.h"
@@ -351,6 +352,16 @@ CreateInitDecodingContext(const char *plugin,
if (plugin == NULL)
elog(ERROR, "cannot initialize logical decoding without a specified plugin");
+ /*
+ * Plugin for REPACK (CONCURRENTLY) is not designed for other uses, such
+ * as the SQL interface. Use the fact that REPACK uses background worker
+ * for the decoding.
+ */
+ if (strcmp(plugin, REPACK_PLUGIN_NAME) == 0 && !AmRepackWorker())
+ ereport(ERROR,
+ errmsg("The \"%s\" decoder plugin may only be called by %s.",
+ REPACK_PLUGIN_NAME, "REPACK (CONCURRENTLY)"));
+
/* Make sure the passed slot is suitable. These are user facing errors. */
if (SlotIsPhysical(slot))
ereport(ERROR,
diff --git a/src/include/commands/repack.h b/src/include/commands/repack.h
index 45e5440a311..1d5e9dbbe01 100644
--- a/src/include/commands/repack.h
+++ b/src/include/commands/repack.h
@@ -35,6 +35,8 @@ typedef struct ClusterParams
uint32 options; /* bitmask of CLUOPT_* */
} ClusterParams;
+#define REPACK_PLUGIN_NAME "pgrepack"
+
extern PGDLLIMPORT volatile sig_atomic_t RepackMessagePending;