0001-Use-a-proper-type-for-RestoreTransactionSnapshot-s-P.patch
text/x-patch
Filename: 0001-Use-a-proper-type-for-RestoreTransactionSnapshot-s-P.patch
Type: text/x-patch
Part: 0
From f60f39ad07154cd37eeb12355349aa75fc8e6239 Mon Sep 17 00:00:00 2001
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Thu, 18 Dec 2025 22:25:59 +0200
Subject: [PATCH 1/9] Use a proper type for RestoreTransactionSnapshot's PGPROC
arg
---
src/backend/utils/time/snapmgr.c | 5 +----
src/include/utils/snapmgr.h | 3 ++-
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c
index 40a2e90e071..5af8326d5e8 100644
--- a/src/backend/utils/time/snapmgr.c
+++ b/src/backend/utils/time/snapmgr.c
@@ -1848,12 +1848,9 @@ RestoreSnapshot(char *start_address)
/*
* Install a restored snapshot as the transaction snapshot.
- *
- * The second argument is of type void * so that snapmgr.h need not include
- * the declaration for PGPROC.
*/
void
-RestoreTransactionSnapshot(Snapshot snapshot, void *source_pgproc)
+RestoreTransactionSnapshot(Snapshot snapshot, PGPROC *source_pgproc)
{
SetTransactionSnapshot(snapshot, NULL, InvalidPid, source_pgproc);
}
diff --git a/src/include/utils/snapmgr.h b/src/include/utils/snapmgr.h
index 604c1f90216..b663d3bbc8c 100644
--- a/src/include/utils/snapmgr.h
+++ b/src/include/utils/snapmgr.h
@@ -120,6 +120,7 @@ extern bool HistoricSnapshotActive(void);
extern Size EstimateSnapshotSpace(Snapshot snapshot);
extern void SerializeSnapshot(Snapshot snapshot, char *start_address);
extern Snapshot RestoreSnapshot(char *start_address);
-extern void RestoreTransactionSnapshot(Snapshot snapshot, void *source_pgproc);
+struct PGPROC;
+extern void RestoreTransactionSnapshot(Snapshot snapshot, struct PGPROC *source_pgproc);
#endif /* SNAPMGR_H */
--
2.47.3