0001-Remove-useless-casts-to-Pointer.patch
text/plain
Filename: 0001-Remove-useless-casts-to-Pointer.patch
Type: text/plain
Part: 0
Message:
get rid of Pointer type, mostly
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch 0001
Subject: Remove useless casts to Pointer
| File | + | − |
|---|---|---|
| contrib/bloom/blutils.c | 1 | 1 |
| contrib/bloom/blvacuum.c | 1 | 1 |
| src/backend/access/gin/ginxlog.c | 1 | 1 |
| src/backend/utils/adt/multirangetypes.c | 1 | 1 |
From d4c4d36810bbfb87d2e20d527c34025ea873de12 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <peter@eisentraut.org>
Date: Mon, 24 Nov 2025 11:02:35 +0100
Subject: [PATCH 1/6] Remove useless casts to Pointer
---
contrib/bloom/blutils.c | 2 +-
contrib/bloom/blvacuum.c | 2 +-
src/backend/access/gin/ginxlog.c | 2 +-
src/backend/utils/adt/multirangetypes.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/bloom/blutils.c b/contrib/bloom/blutils.c
index 2c0e71eedc6..bf50037a71a 100644
--- a/contrib/bloom/blutils.c
+++ b/contrib/bloom/blutils.c
@@ -336,7 +336,7 @@ BloomPageAddItem(BloomState *state, Page page, BloomTuple *tuple)
/* Copy new tuple to the end of page */
opaque = BloomPageGetOpaque(page);
itup = BloomPageGetTuple(state, page, opaque->maxoff + 1);
- memcpy((Pointer) itup, (Pointer) tuple, state->sizeOfBloomTuple);
+ memcpy(itup, tuple, state->sizeOfBloomTuple);
/* Adjust maxoff and pd_lower */
opaque->maxoff++;
diff --git a/contrib/bloom/blvacuum.c b/contrib/bloom/blvacuum.c
index 9e5f0574fad..044fd85a32a 100644
--- a/contrib/bloom/blvacuum.c
+++ b/contrib/bloom/blvacuum.c
@@ -94,7 +94,7 @@ blbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
{
/* No; copy it to itupPtr++, but skip copy if not needed */
if (itupPtr != itup)
- memmove((Pointer) itupPtr, (Pointer) itup,
+ memmove(itupPtr, itup,
state.sizeOfBloomTuple);
itupPtr = BloomPageGetNextTuple(&state, itupPtr);
}
diff --git a/src/backend/access/gin/ginxlog.c b/src/backend/access/gin/ginxlog.c
index 75df3d7a680..606741fa396 100644
--- a/src/backend/access/gin/ginxlog.c
+++ b/src/backend/access/gin/ginxlog.c
@@ -212,7 +212,7 @@ ginRedoRecompress(Page page, ginxlogRecompressDataLeaf *data)
if (tailCopy)
{
Assert(writePtr + segsize < PageGetSpecialPointer(page));
- memcpy(writePtr, (Pointer) oldseg, segsize);
+ memcpy(writePtr, oldseg, segsize);
}
writePtr += segsize;
oldseg = GinNextPostingListSegment(oldseg);
diff --git a/src/backend/utils/adt/multirangetypes.c b/src/backend/utils/adt/multirangetypes.c
index 5273b97f7fe..55e0b4fdc31 100644
--- a/src/backend/utils/adt/multirangetypes.c
+++ b/src/backend/utils/adt/multirangetypes.c
@@ -629,7 +629,7 @@ write_multirange_data(MultirangeType *multirange, TypeCacheEntry *rangetyp,
}
flags[i] = *((Pointer) ranges[i] + VARSIZE(ranges[i]) - sizeof(char));
len = VARSIZE(ranges[i]) - sizeof(RangeType) - sizeof(char);
- memcpy(ptr, (Pointer) (ranges[i] + 1), len);
+ memcpy(ptr, ranges[i] + 1, len);
ptr += att_align_nominal(len, elemalign);
}
}
--
2.52.0