v2-0001-Use-streaming-read-I-O-in-BRIN-vacuuming.patch
text/x-patch
Filename: v2-0001-Use-streaming-read-I-O-in-BRIN-vacuuming.patch
Type: text/x-patch
Part: 0
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch v2-0001
Subject: Use streaming read I/O in BRIN vacuuming
| File | + | − |
|---|---|---|
| src/backend/access/brin/brin.c | 23 | 9 |
From 9dd9176f98f57c77ecaff47c2ad1753657f807a6 Mon Sep 17 00:00:00 2001
From: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>
Date: Sun, 31 Aug 2025 15:44:17 +0300
Subject: [PATCH v2] Use streaming read I/O in BRIN vacuuming
BRIN vacuum processes all index pages in physical order. Now it
uses the read stream API instead of explicitly invoking ReadBuffer().
---
src/backend/access/brin/brin.c | 32 +++++++++++++++++++++++---------
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
index 2f7d1437919..cb3331921cb 100644
--- a/src/backend/access/brin/brin.c
+++ b/src/backend/access/brin/brin.c
@@ -2171,28 +2171,42 @@ union_tuples(BrinDesc *bdesc, BrinMemTuple *a, BrinTuple *b)
static void
brin_vacuum_scan(Relation idxrel, BufferAccessStrategy strategy)
{
- BlockNumber nblocks;
- BlockNumber blkno;
+ BlockRangeReadStreamPrivate p;
+ ReadStream *stream;
+ Buffer buf;
+
+ p.current_blocknum = 0;
+ p.last_exclusive = RelationGetNumberOfBlocks(idxrel);
+
+ /*
+ * It is safe to use batchmode as block_range_read_stream_cb takes no
+ * locks.
+ */
+ stream = read_stream_begin_relation(READ_STREAM_MAINTENANCE |
+ READ_STREAM_FULL |
+ READ_STREAM_USE_BATCHING,
+ strategy,
+ idxrel,
+ MAIN_FORKNUM,
+ block_range_read_stream_cb,
+ &p,
+ 0);
/*
* Scan the index in physical order, and clean up any possible mess in
* each page.
*/
- nblocks = RelationGetNumberOfBlocks(idxrel);
- for (blkno = 0; blkno < nblocks; blkno++)
+ while ((buf = read_stream_next_buffer(stream, NULL)) != InvalidBuffer)
{
- Buffer buf;
-
CHECK_FOR_INTERRUPTS();
- buf = ReadBufferExtended(idxrel, MAIN_FORKNUM, blkno,
- RBM_NORMAL, strategy);
-
brin_page_cleanup(idxrel, buf);
ReleaseBuffer(buf);
}
+ read_stream_end(stream);
+
/*
* Update all upper pages in the index's FSM, as well. This ensures not
* only that we propagate leaf-page FSM updates made by brin_page_cleanup,
--
2.43.0