(unnamed)

text/html

Download

<div>Hi.</div><div> </div><div><div>Added a fatal message about an incorrect track_commit_timestamp parameter for new cluster.  Update test.</div><div>Fail check:</div><div><blockquote><div>Checking for new cluster tablespace directories               ok</div><div>Checking for pg_commit_ts                                     </div><div>"track_commit_timestamp" must be "on" but is set to "off"</div><div> </div></blockquote></div></div><div>Successful:</div><div><blockquote><div>Checking for new cluster tablespace directories               ok</div><div>Checking for pg_commit_ts                                     ok</div><div>...</div></blockquote></div><div> </div><div> </div><div> </div><div>----------------</div><div>Кому: Amit Kapila (amit.kapila16@gmail.com);</div><div>Копия: Hayato Kuroda (Fujitsu) (kuroda.hayato@fujitsu.com), pgsql-hackers@postgresql.org;</div><div>Тема: Patch for migration of the pg_commit_ts directory;</div><div>06.10.2025, 12:59, "Maxim Orlov" &lt;orlovmg@gmail.com&gt;:</div><blockquote><div><div> </div> <div><div>On Thu, 2 Oct 2025 at 11:49, Amit Kapila &lt;<a href="mailto:amit.kapila16@gmail.com" rel="noopener noreferrer">amit.kapila16@gmail.com</a>&gt; wrote:</div><blockquote style="border-left-color:rgb( 204 , 204 , 204 );border-left-style:solid;border-left-width:1px;margin:0px 0px 0px 0.8ex;padding-left:1ex"> When we try to<br />copy slots and the wal_level on the new server is minimal, we error<br />out, so shouldn't we do the same here and error_out if<br />track_commit_timestamp is not enabled and we have some valid commit_ts<br />data to copy?</blockquote><div> </div><div>+1 Sounds reasonable to me. It's better to give an explicit error;<br />otherwise, we would remove data that the user clearly wants to migrate<br />to the new cluster. And deleting data just because the user forgot to<br />specify one parameter in a new cluster looks like a bad joke to me.   </div><div> </div></div>-- <div><div><div>Best regards,</div><div>Maxim Orlov.</div></div></div></div></blockquote>