more_asserting.patch
application/octet-stream
Filename: more_asserting.patch
Type: application/octet-stream
Part: 0
Message:
Re: Make tuple deformation faster
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: unified
| File | + | − |
|---|---|---|
| src/backend/access/common/tupdesc.c | 18 | 1 |
diff --git a/src/backend/access/common/tupdesc.c b/src/backend/access/common/tupdesc.c
index ffd0c78f905..f1498785423 100644
--- a/src/backend/access/common/tupdesc.c
+++ b/src/backend/access/common/tupdesc.c
@@ -160,7 +160,24 @@ verify_compact_attribute(TupleDesc tupdesc, int attnum)
tmp.attnullability = cattr->attnullability;
/* Check the freshly populated CompactAttribute matches the TupleDesc's */
- Assert(memcmp(&tmp, cattr, sizeof(CompactAttribute)) == 0);
+ for (int i = 0; i < 1000; i++)
+ {
+ if (tmp.attcacheoff != cattr->attcacheoff)
+ elog(NOTICE,
+ "tmp.attcacheoff = %d, cattr->attcacheoff = %d\n",
+ tmp.attcacheoff,
+ cattr->attcacheoff);
+ Assert(tmp.attcacheoff == cattr->attcacheoff);
+ Assert(tmp.attlen == cattr->attlen);
+ Assert(tmp.attbyval == cattr->attbyval);
+ Assert(tmp.attispackable == cattr->attispackable);
+ Assert(tmp.atthasmissing == cattr->atthasmissing);
+ Assert(tmp.attisdropped == cattr->attisdropped);
+ Assert(tmp.attgenerated == cattr->attgenerated);
+ Assert(tmp.attnullability == cattr->attnullability);
+ Assert(tmp.attalignby == cattr->attalignby);
+ //Assert(memcmp(&tmp, cattr, sizeof(CompactAttribute)) == 0);
+ }
#endif
}