nit-bertrand-0002.txt

text/plain

Filename: nit-bertrand-0002.txt
Type: text/plain
Part: 0
Message: Re: Draft for basic NUMA observability
commit 17942e95d99d288658b6530e49795c28a93886d2
Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Date:   Sat Apr 5 08:56:03 2025 +0000

    Nit

diff --git a/contrib/pg_buffercache/pg_buffercache_pages.c b/contrib/pg_buffercache/pg_buffercache_pages.c
index 65ade9d8135..0b96476c319 100644
--- a/contrib/pg_buffercache/pg_buffercache_pages.c
+++ b/contrib/pg_buffercache/pg_buffercache_pages.c
@@ -364,7 +364,7 @@ pg_buffercache_numa_pages(PG_FUNCTION_ARGS)
 			 buffers_per_page, pages_per_buffer);
 
 
-		/* initialize the multi-call context, load entries about buffers */
+		/* Initialize the multi-call context, load entries about buffers */
 
 		funcctx = SRF_FIRSTCALL_INIT();
 
@@ -412,7 +412,7 @@ pg_buffercache_numa_pages(PG_FUNCTION_ARGS)
 		MemoryContextSwitchTo(oldcontext);
 
 
-		/* used to determine the NUMA node for all OS pages at once */
+		/* Used to determine the NUMA node for all OS pages at once */
 		os_page_ptrs = palloc0(sizeof(void *) * os_page_count);
 		os_page_status = palloc(sizeof(uint64) * os_page_count);
 
@@ -484,10 +484,10 @@ pg_buffercache_numa_pages(PG_FUNCTION_ARGS)
 
 		}
 
-		/* we should get exactly the expected number of entrires */
+		/* We should get exactly the expected number of entrires */
 		Assert(idx == os_page_count);
 
-		/* query NUMA status for all the pointers */
+		/* Query NUMA status for all the pointers */
 		if (pg_numa_query_pages(0, os_page_count, os_page_ptrs, os_page_status) == -1)
 			elog(ERROR, "failed NUMA pages inquiry: %m");
 
@@ -500,7 +500,7 @@ pg_buffercache_numa_pages(PG_FUNCTION_ARGS)
 			fctx->record[i].numa_node = os_page_status[i];
 		}
 
-		/* remember this backend touched the pages */
+		/* Remember this backend touched the pages */
 		firstNumaTouch = false;
 	}