From c613d416f11cde0ae01b99d5f2b5f25d041eeb54 Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Tue, 1 Apr 2025 21:29:44 +0200 Subject: [PATCH v19 7/8] review --- contrib/pg_buffercache/pg_buffercache_pages.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/contrib/pg_buffercache/pg_buffercache_pages.c b/contrib/pg_buffercache/pg_buffercache_pages.c index 535123aef1c..2d8e1f6ee98 100644 --- a/contrib/pg_buffercache/pg_buffercache_pages.c +++ b/contrib/pg_buffercache/pg_buffercache_pages.c @@ -86,6 +86,10 @@ static bool firstNumaTouch = true; * In order to get reliable results we also need to touch memory pages, so that * inquiry about NUMA memory node doesn't return -2 (which indicates * unmapped/unallocated pages). + * + * review: It's not very obvious to me what this does, exactly. I mean, what's + * the result in os_page_ptrs? What if BLCKSZ < PAGESIZE or BLCKSZ > PAGESIZE? + * What's blk2page and blk2pageoff? */ static inline void pg_buffercache_numa_prepare_ptrs(int buffer_id, float pages_per_blk, -- 2.49.0