v19-0005-review.patch
text/x-patch
Filename: v19-0005-review.patch
Type: text/x-patch
Part: 4
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch v19-0005
Subject: review
| File | + | − |
|---|---|---|
| contrib/pg_buffercache/pg_buffercache_pages.c | 4 | 3 |
From cc3c49b8ca8e6f6a62d6c9e6e1caf3cfdc79fdc6 Mon Sep 17 00:00:00 2001
From: Tomas Vondra <tomas@vondra.me>
Date: Tue, 1 Apr 2025 20:40:01 +0200
Subject: [PATCH v19 5/8] review
---
contrib/pg_buffercache/pg_buffercache_pages.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/contrib/pg_buffercache/pg_buffercache_pages.c b/contrib/pg_buffercache/pg_buffercache_pages.c
index b0741e568d8..d65b3bdf8df 100644
--- a/contrib/pg_buffercache/pg_buffercache_pages.c
+++ b/contrib/pg_buffercache/pg_buffercache_pages.c
@@ -70,6 +70,9 @@ PG_FUNCTION_INFO_V1(pg_buffercache_evict);
/*
* Helper routine for pg_buffercache_pages().
+ *
+ * review: maybe describe what the helper does? Also, I guess we don't want to
+ * keep updating this whenever someone else uses the helper, right?
*/
static BufferCachePagesContext *
pg_buffercache_init_entries(FuncCallContext *funcctx, FunctionCallInfo fcinfo)
@@ -88,7 +91,7 @@ pg_buffercache_init_entries(FuncCallContext *funcctx, FunctionCallInfo fcinfo)
/*
* To smoothly support upgrades from version 1.0 of this extension
* transparently handle the (non-)existence of the pinning_backends
- * column. ee unfortunately have to get the result type for that... - we
+ * column. We unfortunately have to get the result type for that... - we
* can't use the result type determined by the function definition without
* potentially crashing when somebody uses the old (or even wrong)
* function definition though.
@@ -261,9 +264,7 @@ pg_buffercache_pages(PG_FUNCTION_ARGS)
SRF_RETURN_NEXT(funcctx, result);
}
else
- {
SRF_RETURN_DONE(funcctx);
- }
}
Datum
--
2.49.0