v20_refactor_restore_comments.nocfbot
application/octet-stream
Filename: v20_refactor_restore_comments.nocfbot
Type: application/octet-stream
Part: 0
Message:
Re: Non-text mode for pg_dumpall
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
index 0752c44896f..210aac1e040 100644
--- a/src/bin/pg_dump/pg_dumpall.c
+++ b/src/bin/pg_dump/pg_dumpall.c
@@ -595,7 +595,11 @@ main(int argc, char *argv[])
if (quote_all_identifiers)
executeCommand(conn, "SET quote_all_identifiers = true");
- fprintf(OPF, "--\n-- PostgreSQL database cluster dump\n--\n\n");
+ if (archDumpFormat == archNull)
+ fprintf(OPF, "--\n-- PostgreSQL database cluster dump\n--\n\n");
+ else
+ fprintf(OPF, "--\n-- PostgreSQL global objects dump\n--\n\n");
+
if (verbose)
dumpTimestamp("Started on");
@@ -666,7 +670,11 @@ main(int argc, char *argv[])
if (verbose)
dumpTimestamp("Completed on");
- fprintf(OPF, "--\n-- PostgreSQL database cluster dump complete\n--\n\n");
+
+ if (archDumpFormat == archNull)
+ fprintf(OPF, "--\n-- PostgreSQL database cluster dump complete\n--\n\n");
+ else
+ fprintf(OPF, "--\n-- PostgreSQL global objects dump complete\n--\n\n");
if (filename)
{
@@ -1619,7 +1627,7 @@ dumpDatabases(PGconn *conn, ArchiveFormat archDumpFormat)
"WHERE datallowconn AND datconnlimit != -2 "
"ORDER BY (datname <> 'template1'), datname");
- if (PQntuples(res) > 0)
+ if (PQntuples(res) > 0 && archDumpFormat == archNull)
fprintf(OPF, "--\n-- Databases\n--\n\n");
/*
@@ -1677,7 +1685,8 @@ dumpDatabases(PGconn *conn, ArchiveFormat archDumpFormat)
pg_log_info("dumping database \"%s\"", dbname);
- fprintf(OPF, "--\n-- Database \"%s\" dump\n--\n\n", dbname);
+ if (archDumpFormat == archNull)
+ fprintf(OPF, "--\n-- Database \"%s\" dump\n--\n\n", dbname);
/*
* We assume that "template1" and "postgres" already exist in the