v1_0001-Modify-an-incorrect-regression-test-case-in-the-grou.patch
application/octet-stream
Filename: v1_0001-Modify-an-incorrect-regression-test-case-in-the-grou.patch
Type: application/octet-stream
Part: 0
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch v1-0001
Subject: Modify an incorrect regression test case in the group by key value elimination function
| File | + | − |
|---|---|---|
| src/test/regress/expected/aggregates.out | 7 | 6 |
| src/test/regress/sql/aggregates.sql | 3 | 2 |
From 86963d05c59d6f24b9745efe6cbad6d2c4b15dc3 Mon Sep 17 00:00:00 2001
From: songjinzhou <tsinghualucky912@foxmail.com>
Date: Mon, 17 Feb 2025 23:07:06 -0800
Subject: [PATCH] Modify an incorrect regression test case in the group by key
value elimination function
---
src/test/regress/expected/aggregates.out | 13 +++++++------
src/test/regress/sql/aggregates.sql | 5 +++--
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/test/regress/expected/aggregates.out b/src/test/regress/expected/aggregates.out
index f2fb66388c..ce826af3cd 100644
--- a/src/test/regress/expected/aggregates.out
+++ b/src/test/regress/expected/aggregates.out
@@ -1472,22 +1472,23 @@ explain (costs off) select b,c from t3 group by b,c;
-- When there are multiple supporting unique indexes and the GROUP BY contains
-- columns to cover all of those, ensure we pick the index with the least
-- number of columns so that we can remove more columns from the GROUP BY.
-explain (costs off) select a,b,c from t3 group by a,b,c;
+alter table t2 alter column z set not null, add constraint t2_z_uidx unique (z);
+explain (costs off) select x,y,z from t2 group by x,y,z;
QUERY PLAN
----------------------
HashAggregate
- Group Key: c
- -> Seq Scan on t3
+ Group Key: z
+ -> Seq Scan on t2
(3 rows)
-- As above but try ordering the columns differently to ensure we get the
-- same result.
-explain (costs off) select a,b,c from t3 group by c,a,b;
+explain (costs off) select x,y,z from t2 group by z,x,y;
QUERY PLAN
----------------------
HashAggregate
- Group Key: c
- -> Seq Scan on t3
+ Group Key: z
+ -> Seq Scan on t2
(3 rows)
-- Ensure we don't use a partial index as proof of functional dependency
diff --git a/src/test/regress/sql/aggregates.sql b/src/test/regress/sql/aggregates.sql
index 77168bcc74..784b75728a 100644
--- a/src/test/regress/sql/aggregates.sql
+++ b/src/test/regress/sql/aggregates.sql
@@ -520,11 +520,12 @@ explain (costs off) select b,c from t3 group by b,c;
-- When there are multiple supporting unique indexes and the GROUP BY contains
-- columns to cover all of those, ensure we pick the index with the least
-- number of columns so that we can remove more columns from the GROUP BY.
-explain (costs off) select a,b,c from t3 group by a,b,c;
+alter table t2 alter column z set not null, add constraint t2_z_uidx unique (z);
+explain (costs off) select x,y,z from t2 group by x,y,z;
-- As above but try ordering the columns differently to ensure we get the
-- same result.
-explain (costs off) select a,b,c from t3 group by c,a,b;
+explain (costs off) select x,y,z from t2 group by z,x,y;
-- Ensure we don't use a partial index as proof of functional dependency
drop index t3_c_uidx;
--
2.43.0