v48-0005-fixup-Add-OAUTHBEARER-SASL-mechanism.patch
application/x-patch
Filename: v48-0005-fixup-Add-OAUTHBEARER-SASL-mechanism.patch
Type: application/x-patch
Part: 5
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch v48-0005
Subject: fixup! Add OAUTHBEARER SASL mechanism
| File | + | − |
|---|---|---|
| src/interfaces/libpq/fe-auth-oauth-curl.c | 13 | 1 |
From be882ef6eaeba0a9ea536e65a87147e40281e5a4 Mon Sep 17 00:00:00 2001 From: Jacob Champion <jacob.champion@enterprisedb.com> Date: Fri, 7 Feb 2025 16:20:25 -0800 Subject: [PATCH v48 5/8] fixup! Add OAUTHBEARER SASL mechanism --- src/interfaces/libpq/fe-auth-oauth-curl.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/interfaces/libpq/fe-auth-oauth-curl.c b/src/interfaces/libpq/fe-auth-oauth-curl.c index 2179bb89800..74323de309a 100644 --- a/src/interfaces/libpq/fe-auth-oauth-curl.c +++ b/src/interfaces/libpq/fe-auth-oauth-curl.c @@ -32,7 +32,19 @@ #include "libpq-int.h" #include "mb/pg_wchar.h" -#define MAX_OAUTH_RESPONSE_SIZE (1024 * 1024) +/* + * It's generally prudent to set a maximum response size to buffer in memory, + * but it's less clear what size to choose. The biggest of our expected + * responses is the server metadata JSON, which will only continue to grow in + * size; the number of IANA-registered parameters in that document is up to 78 + * as of February 2025. + * + * Even if every single parameter were to take up 2k on average (a previously + * common limit on the size of a URL), 256k gives us 128 parameter values before + * we give up. (That's almost certainly complete overkill in practice; 2-4k + * appears to be common among popular providers at the moment.) + */ +#define MAX_OAUTH_RESPONSE_SIZE (256 * 1024) /* * Parsed JSON Representations -- 2.34.1