v14-0012-Updates-index-insert-and-value-computation-logic.patch
application/octet-stream
Filename: v14-0012-Updates-index-insert-and-value-computation-logic.patch
Type: application/octet-stream
Part: 11
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch v14-0012
Subject: Updates index insert and value computation logic to optimize auxiliary index handling.
| File | + | − |
|---|---|---|
| src/backend/catalog/index.c | 11 | 0 |
| src/backend/executor/execIndexing.c | 7 | 4 |
From bea49e40e16a156e7c942f1fdc9afb0237ec2d1f Mon Sep 17 00:00:00 2001
From: nkey <nkey@toloka.ai>
Date: Mon, 30 Dec 2024 16:37:12 +0100
Subject: [PATCH v14 12/12] Updates index insert and value computation logic to
optimize auxiliary index handling.
* Skip index value computation for auxiliary indices since they are not needed
* Set indexUnchanged=false for auxiliary indices to avoid unnecessary checks
---
src/backend/catalog/index.c | 11 +++++++++++
src/backend/executor/execIndexing.c | 11 +++++++----
2 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
index b7d42c6965f..26ef4dfea27 100644
--- a/src/backend/catalog/index.c
+++ b/src/backend/catalog/index.c
@@ -2929,6 +2929,17 @@ FormIndexDatum(IndexInfo *indexInfo,
ListCell *indexpr_item;
int i;
+ /* Auxiliary index does not need any values to be computed */
+ if (unlikely(indexInfo->ii_Auxiliary))
+ {
+ for (i = 0; i < indexInfo->ii_NumIndexAttrs; i++)
+ {
+ values[i] = PointerGetDatum(NULL);
+ isnull[i] = true;
+ }
+ return;
+ }
+
if (indexInfo->ii_Expressions != NIL &&
indexInfo->ii_ExpressionsState == NIL)
{
diff --git a/src/backend/executor/execIndexing.c b/src/backend/executor/execIndexing.c
index ae11c1dd463..d070f80795d 100644
--- a/src/backend/executor/execIndexing.c
+++ b/src/backend/executor/execIndexing.c
@@ -434,11 +434,14 @@ ExecInsertIndexTuples(ResultRelInfo *resultRelInfo,
* There's definitely going to be an index_insert() call for this
* index. If we're being called as part of an UPDATE statement,
* consider if the 'indexUnchanged' = true hint should be passed.
+ *
+ * In case of auxiliary index always pass false as optimisation.
*/
- indexUnchanged = update && index_unchanged_by_update(resultRelInfo,
- estate,
- indexInfo,
- indexRelation);
+ indexUnchanged = update && likely(!indexInfo->ii_Auxiliary) &&
+ index_unchanged_by_update(resultRelInfo,
+ estate,
+ indexInfo,
+ indexRelation);
satisfiesConstraint =
index_insert(indexRelation, /* index relation */
--
2.43.0