v2-0002-Add-warning-about-dropped-stat-entries.patch

text/x-patch

Filename: v2-0002-Add-warning-about-dropped-stat-entries.patch
Type: text/x-patch
Part: 0
Message: Re: shared-memory based stats collector - v70

Patch

Format: format-patch
Series: patch v2-0002
Subject: Add warning about dropped stat entries at server shutdown.
File+
src/backend/utils/activity/pgstat.c 7 0
From 1becbfa1c873174f7311ad57569a4ce8a9e3a9c8 Mon Sep 17 00:00:00 2001
From: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>
Date: Sat, 7 Dec 2024 12:00:10 +0300
Subject: [PATCH] Add warning about dropped stat entries at server shutdown.

---
 src/backend/utils/activity/pgstat.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/backend/utils/activity/pgstat.c b/src/backend/utils/activity/pgstat.c
index 7533dea6407..a184c29f5ea 100644
--- a/src/backend/utils/activity/pgstat.c
+++ b/src/backend/utils/activity/pgstat.c
@@ -1665,7 +1665,14 @@ pgstat_write_statsfile(XLogRecPtr redo)
 		 */
 		Assert(!ps->dropped);
 		if (ps->dropped)
+		{
+			PgStat_HashKey key = ps->key;
+			elog(WARNING, "found non-deleted stats entry %u/%u/%llu"
+						  "at server shutdown",
+						   key.kind, key.dboid,
+						   (unsigned long long) key.objid);
 			continue;
+		}
 
 		/*
 		 * This discards data related to custom stats kinds that are unknown
-- 
2.47.0