v45.2-0001-Improve-internal-logical-replication-error-for.patch
text/plain
Filename: v45.2-0001-Improve-internal-logical-replication-error-for.patch
Type: text/plain
Part: 0
Message:
Re: SQL:2011 application time
Patch
Same data as JSON:
GET /api/v1/attachments/:id/patch
the parsed metadata as JSON — format, series position, per-file stats; never the diff bytes.
API reference →
Format: format-patch
Series: patch v45-0001
Subject: Improve internal logical replication error for missing equality strategy
| File | + | − |
|---|---|---|
| src/backend/executor/execReplication.c | 2 | 0 |
From 02a390446816da66204b696ac5ad189d5ce82835 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut <peter@eisentraut.org> Date: Wed, 4 Dec 2024 12:06:24 +0100 Subject: [PATCH v45.2 1/5] Improve internal logical replication error for missing equality strategy This "shouldn't happen", except right now it can with a temporal gist index (to be fixed soon), because of missing gist support in get_equal_strategy_number(). But right now, the error is not caught right away, but instead you get the subsequent error about a "missing operator 0". This makes the error more accurate. Discussion: https://www.postgresql.org/message-id/flat/CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mDHcY4_qQ0+noCUVg@mail.gmail.com --- src/backend/executor/execReplication.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/backend/executor/execReplication.c b/src/backend/executor/execReplication.c index cfdf2eedf4d..2ca8c5c50be 100644 --- a/src/backend/executor/execReplication.c +++ b/src/backend/executor/execReplication.c @@ -134,6 +134,8 @@ build_replindex_scan_key(ScanKey skey, Relation rel, Relation idxrel, optype = get_opclass_input_type(opclass->values[index_attoff]); opfamily = get_opclass_family(opclass->values[index_attoff]); eq_strategy = get_equal_strategy_number(opclass->values[index_attoff]); + if (!eq_strategy) + elog(ERROR, "missing equal strategy for opclass %u", opclass->values[index_attoff]); operator = get_opfamily_member(opfamily, optype, optype, base-commit: 7727049e8f663344d4d0457e1d9ec048d626f3d9 -- 2.47.1