v13-0002-Make-use-of-pg_memory_is_all_zeros-in-PageIsVeri.patch
text/x-diff
Filename: v13-0002-Make-use-of-pg_memory_is_all_zeros-in-PageIsVeri.patch
Type: text/x-diff
Part: 1
Patch
Format: format-patch
Series: patch v13-0002
Subject: Make use of pg_memory_is_all_zeros() in PageIsVerifiedExtended()
| File | + | − |
|---|---|---|
| src/backend/storage/page/bufpage.c | 1 | 12 |
From e5aaa29377f1d11d55ad781fdd17617a6e14f7df Mon Sep 17 00:00:00 2001
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Date: Fri, 8 Nov 2024 17:19:43 +0000
Subject: [PATCH v13 2/3] Make use of pg_memory_is_all_zeros() in
PageIsVerifiedExtended()
Now that pg_memory_is_all_zeros() is optimized to handle multi bytes comparison
(instead of byte per byte), let's make use of it in PageIsVerifiedExtended().
---
src/backend/storage/page/bufpage.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/src/backend/storage/page/bufpage.c b/src/backend/storage/page/bufpage.c
index be6f1f62d2..aa264f61b9 100644
--- a/src/backend/storage/page/bufpage.c
+++ b/src/backend/storage/page/bufpage.c
@@ -89,10 +89,8 @@ PageIsVerifiedExtended(Page page, BlockNumber blkno, int flags)
{
PageHeader p = (PageHeader) page;
size_t *pagebytes;
- int i;
bool checksum_failure = false;
bool header_sane = false;
- bool all_zeroes = false;
uint16 checksum = 0;
/*
@@ -126,18 +124,9 @@ PageIsVerifiedExtended(Page page, BlockNumber blkno, int flags)
}
/* Check all-zeroes case */
- all_zeroes = true;
pagebytes = (size_t *) page;
- for (i = 0; i < (BLCKSZ / sizeof(size_t)); i++)
- {
- if (pagebytes[i] != 0)
- {
- all_zeroes = false;
- break;
- }
- }
- if (all_zeroes)
+ if (pg_memory_is_all_zeros(pagebytes, BLCKSZ))
return true;
/*
--
2.45.2